Crash when joining objects with shape keys #60795

New Issue

lucas veber · 2019-01-23T16:13:43+01:00

lucas veber commented

2019-01-23 16:13:43 +01:00

System Information
Operating system: Win10
Graphics card: Gtx 980

Blender Version
Broken: Latest 2.8 build

Short description of error
When joining two objects that contain shape keys, Blender crashes

Exact steps for others to reproduce the error

Open the following blend
join_objects_shapes.blend
The two objects contain shape keys. They are selected. Press Ctr-J to join them.
It should crash instantly, if not, it should crash the second time (File > Revert and try again)

**System Information** Operating system: Win10 Graphics card: Gtx 980 **Blender Version** Broken: Latest 2.8 build **Short description of error** When joining two objects that contain shape keys, Blender crashes **Exact steps for others to reproduce the error** - Open the following blend [join_objects_shapes.blend](https://archive.blender.org/developer/F6379766/join_objects_shapes.blend) - The two objects contain shape keys. They are selected. Press Ctr-J to join them. - It should crash instantly, if not, it should crash the second time (File > Revert and try again)

lucas veber commented

2019-01-23 16:13:43 +01:00

Added subscriber: @LucasVeber

Philipp Oeser commented

2019-01-24 09:31:51 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-01-24 09:31:51 +01:00

this was still working in 7c438e5366, bisecting...

this was still working in 7c438e5366, bisecting...

Bastien Montagne was assigned by Philipp Oeser

2019-01-24 10:04:31 +01:00

Philipp Oeser commented

2019-01-24 10:04:31 +01:00

Added subscriber: @mont29

Philipp Oeser commented

2019-01-24 10:04:32 +01:00

Turns out since cae3750ff9 we are asserting in undo here

BLI_assert((id->tag & (LIB_TAG_NO_MAIN | LIB_TAG_NO_USER_REFCOUNT | LIB_TAG_NOT_ALLOCATED)) == 0);


1  raise                                                  0x7ffff466953f 
2  abort                                                  0x7ffff4653895 
3  write_file_handle               writefile.c       3892 0x290fa64      
4  BLO_write_file_mem              writefile.c       4234 0x29108b0      
5  BKE_memfile_undo_encode         blender_undo.c    128  0x29f0008      
6  memfile_undosys_step_encode     memfile_undo.c    84   0x1cbcb77      
7  undosys_step_encode             undo_system.c     151  0x2c45386      
8  BKE_undosys_step_push_with_type undo_system.c     502  0x2c46a2d      
9  BKE_undosys_step_push           undo_system.c     522  0x2c46b52      
10 ED_undo_push                    ed_undo.c         103  0x1cbb5ee      
11 ED_undo_push_op                 ed_undo.c         250  0x1cbbcb4      
12 wm_operator_finished            wm_event_system.c 888  0x1c7be3a

caused by change from
BKE_libblock_free_ex(bmain, nkey, false, false);
to
BKE_id_free_ex(bmain, nkey, LIB_ID_FREE_NO_UI_USER | LIB_ID_FREE_NO_USER_REFCOUNT, false);

@mont29: guess this is in good hands with you?

Turns out since cae3750ff9 we are asserting in undo here BLI_assert((id->tag & (LIB_TAG_NO_MAIN | LIB_TAG_NO_USER_REFCOUNT | LIB_TAG_NOT_ALLOCATED)) == 0); ``` 1 raise 0x7ffff466953f 2 abort 0x7ffff4653895 3 write_file_handle writefile.c 3892 0x290fa64 4 BLO_write_file_mem writefile.c 4234 0x29108b0 5 BKE_memfile_undo_encode blender_undo.c 128 0x29f0008 6 memfile_undosys_step_encode memfile_undo.c 84 0x1cbcb77 7 undosys_step_encode undo_system.c 151 0x2c45386 8 BKE_undosys_step_push_with_type undo_system.c 502 0x2c46a2d 9 BKE_undosys_step_push undo_system.c 522 0x2c46b52 10 ED_undo_push ed_undo.c 103 0x1cbb5ee 11 ED_undo_push_op ed_undo.c 250 0x1cbbcb4 12 wm_operator_finished wm_event_system.c 888 0x1c7be3a ``` caused by change from `BKE_libblock_free_ex(bmain, nkey, false, false);` to `BKE_id_free_ex(bmain, nkey, LIB_ID_FREE_NO_UI_USER | LIB_ID_FREE_NO_USER_REFCOUNT, false);` @mont29: guess this is in good hands with you?

blender-admin commented

2019-01-24 14:31:47 +01:00

This issue was referenced by 6ff4babfd4

This issue was referenced by 6ff4babfd420aa9697bfab193577f879db414265

Bastien Montagne commented

2019-01-24 14:33:45 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2019-01-24 14:33:45 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when joining objects with shape keys #60795