Clicking Preset doesn't change the settings immediately #62325

New Issue

Sebastian Koenig · 2019-03-07T18:06:15+01:00

Sebastian Koenig commented

2019-03-07 18:06:15 +01:00

System Information
Operating system: elementaryOS 0.4.1,
Graphics card: GTX 1080

Blender Version
Broken: 280, ed24315c63
Worked: 2.79
Short description of error
If you click on a preset menu entry to change e.g. the sampling settings, nothing happens. The values only update when you close the popup. So while you are clicking the different menu entries you think nothing happens and the presets are broken.

Exact steps for others to reproduce the error
Open startup file, change Render Engine to Cycles.
Click on the presets icon and choose one of the menu entries. Nothing seems to happen when you click. Maybe not technically a bug, but still feels super buggy ;)

**System Information** Operating system: elementaryOS 0.4.1, Graphics card: GTX 1080 **Blender Version** Broken: 280, ed24315c6309 Worked: 2.79 **Short description of error** If you click on a preset menu entry to change e.g. the sampling settings, nothing happens. The values only update when you close the popup. So while you are clicking the different menu entries you think nothing happens and the presets are broken. **Exact steps for others to reproduce the error** Open startup file, change Render Engine to Cycles. Click on the presets icon and choose one of the menu entries. Nothing seems to happen when you click. Maybe not technically a bug, but still feels super buggy ;)

Sebastian Koenig commented

2019-03-07 18:06:15 +01:00

Added subscriber: @sebastian_k

blender-admin commented

2019-03-07 18:06:15 +01:00

#87206 was marked as duplicate of this issue

blender-admin commented

2019-03-07 18:06:15 +01:00

#78908 was marked as duplicate of this issue

blender-admin commented

2019-03-07 18:06:15 +01:00

#68154 was marked as duplicate of this issue

blender-admin commented

2019-03-07 18:06:15 +01:00

#67750 was marked as duplicate of this issue

blender-admin commented

2019-03-07 18:06:15 +01:00

#66029 was marked as duplicate of this issue

blender-admin commented

2019-03-07 18:06:15 +01:00

#63299 was marked as duplicate of this issue

Jacques Lucke commented

2019-03-07 18:23:48 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-03-07 18:23:48 +01:00

checking...

Brecht Van Lommel commented

2019-04-05 12:53:24 +02:00

Added subscriber: @bliblubli

mathieu menuet commented

2019-04-05 18:38:50 +02:00

Note that in some scene, even closing the popup doesn't help. In the classroom scene, you have to click on the scene name and then validate to get the presets to apply.

Note that in some scene, even closing the popup doesn't help. In the classroom scene, you have to click on the scene name and then validate to get the presets to apply. ![bug preset classroom.png](https://archive.blender.org/developer/F6913242/bug_preset_classroom.png)

Brecht Van Lommel commented

2019-06-23 18:02:13 +02:00

Added subscriber: @ThomasFreye

Shane Ambler commented

2019-07-03 10:33:45 +02:00

Added subscriber: @sambler

Shane Ambler commented

2019-07-03 10:33:45 +02:00

Most presets work (now) a few don't.

Failing :-
Cycles sampling
Cycles Light paths
Fluid viscosity

Camera Safe areas - This refreshes the first time a preset is selected and then fails.

Maybe a little off topic, the hair dynamics panel has presets, the icon does not show until you enable hair dynamics, after that it stays visible while enabling/disabling.

Most presets work (now) a few don't. Failing :- Cycles sampling Cycles Light paths Fluid viscosity Camera Safe areas - This refreshes the first time a preset is selected and then fails. Maybe a little off topic, the hair dynamics panel has presets, the icon does not show until you enable hair dynamics, after that it stays visible while enabling/disabling.

Brecht Van Lommel commented

2019-08-02 14:08:13 +02:00

Added subscribers: @popqjp, @brecht, @WilliamReynish

Philipp Oeser commented

2019-12-19 17:53:45 +01:00

Added subscriber: @Fishy

Philipp Oeser commented

2020-07-31 13:45:26 +02:00

Added subscribers: @APEC, @lichtwerk

Ryan Inch commented

2020-11-17 09:47:55 +01:00

Added subscriber: @Imaginer

Philipp Oeser commented

2021-04-06 10:16:21 +02:00

Added subscriber: @Lumpengnom-3

blender-admin commented

2021-10-15 18:55:06 +02:00

This issue was referenced by 1b6752e599

This issue was referenced by 1b6752e599b5ed70823d09f90c418e448516d4b4

Brecht Van Lommel commented

2021-10-15 19:00:32 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue

2021-10-15 19:00:32 +02:00

Brecht Van Lommel self-assigned this 2021-10-15 19:00:32 +02:00

blender-admin commented

2021-10-16 13:54:29 +02:00

This issue was referenced by 5c961b3b58

This issue was referenced by 5c961b3b582f77f9f7e9fa99476217753c424d32

Brecht Van Lommel commented

2021-10-16 13:55:47 +02:00

Changed status from 'Resolved' to: 'Confirmed'

Brecht Van Lommel reopened this issue

2021-10-16 13:55:47 +02:00

Brecht Van Lommel commented

2021-10-16 13:55:47 +02:00

Fixed reverted because it caused constant redraws.

Steffen Dünner commented

2021-10-16 21:04:53 +02:00

Added subscriber: @SteffenD

Brecht Van Lommel commented

2021-10-19 16:58:52 +02:00

Added subscribers: @mont29, @ideasman42

Brecht Van Lommel commented

2021-10-19 16:58:53 +02:00

@ideasman42, @mont29, maybe you guys have some advice for how best to solve this.

The issue here is that currently RNA properties created by add-ons do not always get depsgraph updates or window redraws. It happens when they are edited through a button, but not through a Python script, including presets.

By enabling those kinds of updates we get constant redraws, since this then also includes operator properties which are set all the time while drawing the UI. Likely there are also add-ons that update other types of properties while redrawing.

I can think of a few solutions for this:

Do not solve the core issue right now, and work around it in Cycles presets by changing some other datablock property that will trigger a depsgraph update.
Add an opt-in flag to RNA properties to indicate if they require a depsgraph update.
Add an opt-in flag to RNA properties to indicate if they require a depsgraph update, but always do the depsgraph update when edited through a button for backwards compatibility.
Always update, with some exceptions that are known to be updated on redraws (workspace/screen/windowmanager owner ID?).

I'm tempted to go with (1) and postpone this problem, since I'm not really sure what the proper update/redraw mechanism would look like. A flag as in (2) or (3) feels not fine grained enough so could be another intermediate solution, and I'm not so happy to break compatibility until we have a proper solution. (4) is likely to cause hidden performance issues with some add-ons.

@ideasman42, @mont29, maybe you guys have some advice for how best to solve this. The issue here is that currently RNA properties created by add-ons do not always get depsgraph updates or window redraws. It happens when they are edited through a button, but not through a Python script, including presets. By enabling those kinds of updates we get constant redraws, since this then also includes operator properties which are set all the time while drawing the UI. Likely there are also add-ons that update other types of properties while redrawing. I can think of a few solutions for this: 1. Do not solve the core issue right now, and work around it in Cycles presets by changing some other datablock property that will trigger a depsgraph update. 2. Add an opt-in flag to RNA properties to indicate if they require a depsgraph update. 3. Add an opt-in flag to RNA properties to indicate if they require a depsgraph update, but always do the depsgraph update when edited through a button for backwards compatibility. 4. Always update, with some exceptions that are known to be updated on redraws (workspace/screen/windowmanager owner ID?). I'm tempted to go with (1) and postpone this problem, since I'm not really sure what the proper update/redraw mechanism would look like. A flag as in (2) or (3) feels not fine grained enough so could be another intermediate solution, and I'm not so happy to break compatibility until we have a proper solution. (4) is likely to cause hidden performance issues with some add-ons.

Bastien Montagne commented

2021-10-20 09:17:41 +02:00

The issue is also documented in #74000 (Property controlled drivers not updating from python) e.g. (where it was suggested to manually tag for updates from python code).

On the long run I would go for solution 2? Would match internal C-defined properties.

But for now, I think a workaround as suggested in solution 1 would be acceptable yes, a proper solution would need time to be properly designed.

The issue is also documented in #74000 (Property controlled drivers not updating from python) e.g. (where it was suggested to manually tag for updates from python code). On the long run I would go for solution 2? Would match internal C-defined properties. But for now, I think a workaround as suggested in solution 1 would be acceptable yes, a proper solution would need time to be properly designed.

blender-admin commented

2021-10-20 13:16:12 +02:00

This issue was referenced by 4f15c24705

This issue was referenced by 4f15c247052b6db49b5226b6c473bdb7b2be6293

Brecht Van Lommel commented

2021-10-20 13:34:30 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue

2021-10-20 13:34:30 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Clicking Preset doesn't change the settings immediately #62325