Update of material icons during animation 2x performance penalty (1/2 speed or worse). #64318

Closed
opened 2019-05-08 17:23:18 +02:00 by Ian Finnimore · 3 comments

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 650/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67

Blender Version
Broken: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-07 19:17, hash: 3dc9da3a74
Worked: (optional)

Short description of error
This is related to #64247 but different topic

The updating of the material icon is incurs a > 2x performance penalty (half speed or worse) when the material tab is selected during animation. #64247 has an .blend example of a very dynamic multi-driver based shader. I get > 25 fps animation on my setup when any other property tab is selected (and doesn't seem to crash), but when materials tab is selected performance drops to < 15 fps (and then occasionally crashes, reported in #64247). Even worse when preview panel is expanded as well. Note: The actual visual of the icon does not change during animation anyway.

Perhaps it would be better to suspend icon/preview update during animation and refresh at stop just like update is suspended if the tab is not selected,

This animation update has no particular benefit to offset the performance penalty (and seems like it may avoid the thread clash problem of #64247 (who's crash log seems to point to Icon Update Job) as it seems the Icon Preview is re-running the each materials node tree again.

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]
Run animation with any driven material with and without the Material property tab selected. #64247 has a blend file with such a material.

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 650/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.67 **Blender Version** Broken: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-07 19:17, hash: `3dc9da3a74` Worked: (optional) **Short description of error** This is related to #64247 but different topic The updating of the material icon is incurs a > 2x performance penalty (half speed or worse) when the material tab is selected during animation. #64247 has an .blend example of a very dynamic multi-driver based shader. I get > 25 fps animation on my setup when any other property tab is selected (and doesn't seem to crash), but when materials tab is selected performance drops to < 15 fps (and then occasionally crashes, reported in #64247). Even worse when preview panel is expanded as well. Note: The actual visual of the icon does not change during animation anyway. Perhaps it would be better to suspend icon/preview update during animation and refresh at stop just like update is suspended if the tab is not selected, This animation update has no particular benefit to offset the performance penalty (and seems like it may avoid the thread clash problem of #64247 (who's crash log seems to point to Icon Update Job) as it seems the Icon Preview is re-running the each materials node tree again. **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] Run animation with any driven material with and without the Material property tab selected. #64247 has a blend file with such a material.
Author

Added subscriber: @IanFinn

Added subscriber: @IanFinn
Clément Foucault was assigned by Sebastian Parborg 2019-05-10 11:04:33 +02:00

This issue was referenced by 30c0d780f9

This issue was referenced by 30c0d780f9d9012e45db4553e8df1c9526f03b27

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#64318
No description provided.