Missing text in the msgid entry, might be there is an error in the extraction code #66065

New Issue

Hoang Duy Tran · 2019-06-24T00:32:10+02:00

Hoang Duy Tran commented

2019-06-24 00:32:10 +02:00

The file 'vi.po' -- or the file 'blender.pot' -- has an entry like this:

. :src: scripts/addons/cycles/operators.py:101

msgid "Frame '' not found, animation must be complete."
msgstr ""

at the line number: 102959.

This is found at the following section:

              if not os.path.isfile(filepath):
                  scene.render.filepath = original_filepath
                  self.report({'ERROR'}, f"Frame '{filepath}' not found, animation must be complete.")
                  return {'CANCELLED'}

of the file

intern/cycles/blender/addon/operators.py

at the line number: 99

Notice that there is a word 'filepath' which resides between the pair of curly brackets, and the whole group of brackets and its contents have been omitted in the text of 'msgid' entry.

The file 'vi.po' -- or the file 'blender.pot' -- has an entry like this: # . :src: scripts/addons/cycles/operators.py:101 msgid "Frame '' not found, animation must be complete." msgstr "" at the line number: 102959. This is found at the following section: ``` if not os.path.isfile(filepath): scene.render.filepath = original_filepath self.report({'ERROR'}, f"Frame '{filepath}' not found, animation must be complete.") return {'CANCELLED'} ``` of the file intern/cycles/blender/addon/operators.py at the line number: 99 Notice that there is a word 'filepath' which resides between the pair of curly brackets, and the whole group of brackets and its contents have been omitted in the text of 'msgid' entry.

Hoang Duy Tran commented

2019-06-24 00:32:10 +02:00

Added subscriber: @hoanguk

Bastien Montagne commented

2019-06-24 22:35:51 +02:00

Added subscriber: @mont29

Bastien Montagne self-assigned this 2019-06-24 22:35:51 +02:00

Bastien Montagne commented

2019-06-24 22:35:51 +02:00

More like a missing update, we did not use those f-strings before… Guess I'll have to dust off my AST again to add support for those.

Bastien Montagne commented

2019-06-24 22:53:30 +02:00

Added subscriber: @ideasman42

Bastien Montagne commented

2019-06-24 22:53:30 +02:00

@ideasman42 this will generate an ast.JoinedStr (containing a list of regular ast.Str and ast.FormattedValue objects). Thing is, I don’t think we can properly translate this in any way, since bpy API will only get the already processed string, which obviously does not exist in translations…
We could try invoking explicitly the pgettext function there, but am pretty sure that would break the fstring too (as this has to be parsed together with the whole py code at load time)? And in any case, it would be super-ugly…

Will dig more later (this is not exactly top priority I think), but am not feeling optimistic here, unless am missing something, think we should avoid those fstrings in UI messages (anything that is translated) for now?

@ideasman42 this will generate an `ast.JoinedStr` (containing a list of regular `ast.Str` and `ast.FormattedValue` objects). Thing is, I don’t think we can properly translate this in any way, since bpy API will only get the already processed string, which obviously does not exist in translations… We could try invoking explicitly the pgettext function there, but am pretty sure that would break the fstring too (as this has to be parsed together with the whole py code at load time)? And in any case, it would be super-ugly… Will dig more later (this is not exactly top priority I think), but am not feeling optimistic here, unless am missing something, think we should avoid those fstrings in UI messages (anything that is translated) for now?

Campbell Barton commented

2019-06-25 11:14:20 +02:00

We could avoid f-strings for text which needs to be translated if this complicates things too much.