Make Instances Real: Keep Hierarchy option has no effect when duplicates are collection instances #66282
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#66282
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.39
Blender Version
Broken: version: 2.80 (sub 74), branch: blender2.8, commit date: 2019-06-30 15:32, hash:
7c8bf77e13
Short description of error
When using the make instance real function the hierarchy of the objects gets lost even if the keep hierarchy option is ticked which affects both the grouping of the objects inside the original collection as well as any object parenting that is involved in the collection.
Exact steps for others to reproduce the error
In the uploaded blender file execute the "Make Instance Real" operation and ensure "Keep Hierarchy" is ticked.
keep hiearchy bug.blend
Added subscriber: @bestdani
Make Instances Real: Keep Hiearchy option has no effect when duplicates are collection instancesto Make Instances Real: Keep Hierarchy option has no effect when duplicates are collection instancesAdded subscribers: @mont29, @lichtwerk
asking @mont29 for advice here: not 100% sure how instances are handled in this case, but the way it is handled atm. looks a little weird [duplicating collection instance contents as well as collection instances as well?]
Will confirm for the time being...
The behavior of creating object copies is working as expected (Collection copies are mere empties, not duplicollections anymore).
The problem is with re-parenting, that one is broken for anything but simplest cases, and reading the code, has been broken for years (it's trying to get parent object's new copy using child
persistent_id
...). Still trying to figure out the proper solution here.Pffff… this has been a nightmare to understand fully, and incoming fix only partially addresses the issue, which basically was that this code was not designed to handle recursive instancing at all.
The incoming commit, which extends/pushes a bit forward current code, is going to add some minimal support for recursive parenting (the case reported here will be working as expected e.g.), however it wont work fully in all complex cases. That would require some refactor, which is out of scope of this task, and not to be done before 2.80 is released anyway.
This issue was referenced by
699193713f
Changed status from 'Open' to: 'Resolved'