Incorrect Stretching Overlay of type "Area" when any face is hidden. #67299

New Issue

Yury · 2019-07-20T09:14:29+02:00

Yury commented

2019-07-20 09:14:29 +02:00

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.36

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-18 14:52, hash: 38d4483c6a
Worked: (optional)

Short description of error
[Please fill out a short description of the error here]

Exact steps for others to reproduce the error

Open attached file;
Enter edit mode;
See incosistent result of UV Stretching Overlay.

stratch_display_selection_bug.blend

**System Information** Operating system: Windows-10-10.0.18362 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.36 **Blender Version** Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-18 14:52, hash: `38d4483c6a` Worked: (optional) **Short description of error** [Please fill out a short description of the error here] **Exact steps for others to reproduce the error** 1. Open attached file; 2. Enter edit mode; 3. See incosistent result of UV Stretching Overlay. ![stratch_display_selection_bug.jpg](https://archive.blender.org/developer/F7623647/stratch_display_selection_bug.jpg) [stratch_display_selection_bug.blend](https://archive.blender.org/developer/F7623654/stratch_display_selection_bug.blend)

Yury commented

2019-07-20 09:14:29 +02:00

Added subscriber: @grecay

Germano Cavalcante commented

2019-07-22 15:33:08 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2019-07-22 15:33:08 +02:00

I can't replicate the problem by enabling the Streching overlay and selecting only 3 faces on the default cube.
We need more specific and detailed steps in order to reproduce the problem.

I can't replicate the problem by enabling the Streching overlay and selecting only 3 faces on the default cube. We need more specific and detailed steps in order to reproduce the problem.

Yury commented

2019-07-22 23:54:05 +02:00

Thanks for the answer. I added a blend file and a screenshot of the problem.

Germano Cavalcante self-assigned this 2019-07-23 00:51:20 +02:00

Germano Cavalcante changed title from ~~UV Edit mode in UV editon with turn on Overlays-Strething (type area) is flickering ang wrong display with not whole mesh selected~~ to Stretching Overlay of type "Area" produces incorrect results if any face is hidden.

2019-07-23 01:03:11 +02:00

Germano Cavalcante changed title from ~~Stretching Overlay of type "Area" produces incorrect results if any face is hidden.~~ to Incorrect Stretching Overlay of type "Area" when any face is hidden.

2019-07-23 01:04:55 +02:00

Germano Cavalcante removed their assignment 2019-07-23 01:09:38 +02:00

Clément Foucault was assigned by Germano Cavalcante

2019-07-23 01:09:38 +02:00

Germano Cavalcante commented

2019-07-23 01:09:38 +02:00

Added subscriber: @fclem

Germano Cavalcante commented

2019-07-23 01:09:38 +02:00

Here a possible solution:

diff --git a/source/blender/draw/intern/draw_cache_impl_mesh.c b/source/blender/draw/intern/draw_cache_impl_mesh.c
index 306031809d1..2376787a273 100644
--- a/source/blender/draw/intern/draw_cache_impl_mesh.c
+++ b/source/blender/draw/intern/draw_cache_impl_mesh.c
@@ -4830,7 +4830,7 @@ static void uvedit_fill_buffer_data(MeshRenderData *rdata,
     /* Tag hidden faces */
     BM_elem_flag_set(efa, BM_ELEM_TAG, uvedit_face_visible_nolocal_ex(rdata->toolsettings, efa));
 
-    if (vbo_area && BM_elem_flag_test(efa, BM_ELEM_TAG)) {
+    if (vbo_area) {
       edit_uv_preprocess_stretch_area(
           efa, cd_loop_uv_offset, fidx++, &totarea, &totuvarea, faces_areas);
     }

@fclem, that check if the face is visible was not part of the original code (781995a0)

Here a possible solution: ``` diff --git a/source/blender/draw/intern/draw_cache_impl_mesh.c b/source/blender/draw/intern/draw_cache_impl_mesh.c index 306031809d1..2376787a273 100644 --- a/source/blender/draw/intern/draw_cache_impl_mesh.c +++ b/source/blender/draw/intern/draw_cache_impl_mesh.c @@ -4830,7 +4830,7 @@ static void uvedit_fill_buffer_data(MeshRenderData *rdata, /* Tag hidden faces */ BM_elem_flag_set(efa, BM_ELEM_TAG, uvedit_face_visible_nolocal_ex(rdata->toolsettings, efa)); - if (vbo_area && BM_elem_flag_test(efa, BM_ELEM_TAG)) { + if (vbo_area) { edit_uv_preprocess_stretch_area( efa, cd_loop_uv_offset, fidx++, &totarea, &totuvarea, faces_areas); } ``` @fclem, that check if the face is visible was not part of the original code (781995a0)

Clément Foucault removed their assignment 2019-07-23 10:35:02 +02:00

Germano Cavalcante was assigned by Clément Foucault

2019-07-23 10:35:02 +02:00

Clément Foucault commented

2019-07-23 10:35:02 +02:00

@mano-wii You are correct. You can commit the fix. Maybe note in the commit log that we want it for 2.80 as it is pretty safe.

blender-admin commented

2019-07-23 12:51:16 +02:00

This issue was referenced by 19aa873f70

This issue was referenced by 19aa873f70026e4745584915466e9da6910457b8

Germano Cavalcante commented

2019-07-23 12:51:31 +02:00

Changed status from 'Open' to: 'Resolved'

Germano Cavalcante closed this issue

2019-07-23 12:51:31 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Incorrect Stretching Overlay of type "Area" when any face is hidden. #67299