Modifiers which deform spline points propagate across all users of the same data unexpectedly #71055

New Issue

Sam Brubaker · 2019-10-24T00:39:21+02:00

Sam Brubaker commented

2019-10-24 00:39:21 +02:00

Version: 2.81 build Oct 23 (Linux 64)

When a Curve Object Modifier uses the "Apply On Spline" setting, it seems to affect the curve data directly. This means that if a curve data block is used by multiple objects, a modifier on one of those objects will affect all the others.

curve_modifier_bug.blend

To reproduce, open and inspect the attached file. Notice that the objects on the left both have deformation modifiers, while their clones on the right do not. However, the curve object still appears to be modified because it uses the same data as the modified curve object. This is not how modifiers are supposed to behave.

The expected behavior is demonstrated by the two mesh objects. Like the curve objects, they also share the same data, but the effect of the modifier is limited to the owner of the modifier.

Version: 2.81 build Oct 23 (Linux 64) When a Curve Object Modifier uses the "Apply On Spline" setting, it seems to affect the curve data directly. This means that if a curve data block is used by multiple objects, a modifier on one of those objects will affect all the others. [curve_modifier_bug.blend](https://archive.blender.org/developer/F7851457/curve_modifier_bug.blend) To reproduce, open and inspect the attached file. Notice that the objects on the left both have deformation modifiers, while their clones on the right do not. However, the curve object still appears to be modified because it uses the same data as the modified curve object. This is not how modifiers are supposed to behave. The expected behavior is demonstrated by the two mesh objects. Like the curve objects, they also share the same data, but the effect of the modifier is limited to the owner of the modifier.

Sam Brubaker commented

2019-10-24 00:39:21 +02:00

Added subscriber: @rocketman

blender-admin commented

2019-10-24 00:39:21 +02:00

#74616 was marked as duplicate of this issue

blender-admin commented

2019-10-24 00:39:21 +02:00

#65007 was marked as duplicate of this issue

Germano Cavalcante commented

2019-10-24 21:32:36 +02:00

Added subscribers: @mont29, @ideasman42, @mano-wii

Bastien Montagne was assigned by Germano Cavalcante

2019-10-24 21:32:36 +02:00

Germano Cavalcante commented

2019-10-24 21:32:36 +02:00

I can confirm. Other objects are using the modified data.
This did not happen in Blender 2.79.

@mont29, according to the modules's page , you maintain modifiers and curves.
Could you take a look?

Cc @campbellbarton.

I can confirm. Other objects are using the modified data. This did not happen in Blender 2.79. @mont29, according to the [modules's page ](https://wiki.blender.org/wiki/Modules), you maintain modifiers and curves. Could you take a look? Cc @campbellbarton.

Bastien Montagne removed their assignment 2019-11-05 15:04:58 +01:00

Bastien Montagne commented

2019-11-05 15:04:59 +01:00

Added subscribers: @fclem, @Jeroen-Bakker

Bastien Montagne commented

2019-11-05 15:04:59 +01:00

this is not really my area, from quick look in code I have the impression that data onto which the modifier is applied is properly de-duplicated during eval, so I'd first suspect some issue in drawing code itself (also because outline does not follow shown geometry...). it also reminds me of some similar issue we had with meshes at some points, because drawing cache was per obdata and not per object or something like that... that was fixed for meshes, not sure if it was for other geometry types? We need @fclem or @Jeroen-Bakker to have a look at that first imho.

Nuno Conceicao commented

2019-11-12 16:49:58 +01:00

Added subscriber: @NunoAlexandreConceicao

Nuno Conceicao commented

2019-11-12 16:49:58 +01:00

Hi, sorry, is there any chance this bug been looked at before the final release?

Philipp Oeser commented

2019-11-12 17:12:31 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-11-12 17:12:31 +01:00

Also think thats an Eevee / drawing problem [Cycles renders this correctly...]

Philipp Oeser commented

2019-11-12 17:28:32 +01:00

This all seems to be related / holds more info:
a14735d11d
#61184 (linked curves with curve modifiers arent drawn correctly)
#63871 (Curves with curve modifiers are not translated to mesh correctly and can't be used as a target for constraints and modifiers predictably)
#65007 (Linked curves with curve modifiers are not deformed correctly)

This all seems to be related / holds more info: a14735d11d #61184 (linked curves with curve modifiers arent drawn correctly) #63871 (Curves with curve modifiers are not translated to mesh correctly and can't be used as a target for constraints and modifiers predictably) #65007 (Linked curves with curve modifiers are not deformed correctly)

Nuno Conceicao commented

2019-11-12 17:32:17 +01:00

Its seems like a problem that has been lingering for a while and very bad for people doing rigs that involve curves, even if just for view port representation. Just came across it recently because Im a newcomer from another 3D package but its a worrying issue.

Clément Foucault was assigned by Germano Cavalcante

2019-11-12 20:32:36 +01:00

Germano Cavalcante commented

2019-11-12 20:32:36 +01:00

Both objects have the same ob->data but different ob->runtime.curve_cache.
The problem is that all drawing information is cached in ((Curve *)ob->data)->batch_cache.
I see two possible solutions:

also create mesh_eval for this type of modifier (pretessellatePoint) or,
move batch_cache from cu to curve_cache.

Both objects have the same `ob->data` but different `ob->runtime.curve_cache`. The problem is that all drawing information is cached in `((Curve *)ob->data)->batch_cache`. I see two possible solutions: - also create `mesh_eval` for this type of modifier (`pretessellatePoint`) or, - move `batch_cache` from `cu` to `curve_cache`.

Bastien Montagne commented

2020-02-03 17:43:45 +01:00

Added subscribers: @Hickz, @brecht

Philipp Oeser commented

2020-03-10 14:03:35 +01:00

Added subscriber: @karja

Clément Foucault commented

2020-05-01 00:11:33 +02:00

I've pushed some workaround for 2.83 that should fix the common case. But this does not fix the issue in edit mode.

Clément Foucault removed their assignment 2020-05-14 16:27:26 +02:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Modifiers which deform spline points propagate across all users of the same data unexpectedly #71055