File browser puts focus on wrong window after closing the dialog #72693

New Issue

Vanessa Dannenberg · 2019-12-25T20:21:24+01:00

2019-12-25 20:21:24 +01:00

System Information
Applies to all operating systems

Blender Version
Broken: 2.81a
Worked: 2.80 (Before the new file browser)

Short description of error

Closing the file browser puts the focus on the newest child window, disregarding which window was originally in focus before the file browser was opened.

Exact steps for others to reproduce the error

Create a new window through Window > New Window
Focus on the original main window

Open a file browser dialog, e.g. through File > Append and close it

The focus switches to the child window, even though the dialog was started from there.

**System Information** Applies to all operating systems **Blender Version** Broken: 2.81a Worked: 2.80 (Before the new file browser) **Short description of error** Closing the file browser puts the focus on the newest child window, disregarding which window was originally in focus before the file browser was opened. **Exact steps for others to reproduce the error** - Create a new window through *Window > New Window* - Focus on the original main window # Open a file browser dialog, e.g. through *File > Append* and close it ``` ``` The focus switches to the child window, even though the dialog was started from there.

Vanessa Dannenberg commented

2019-12-25 20:21:25 +01:00

Added subscriber: @VanessaE

Robert Guetzkow commented

2019-12-25 23:12:01 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2019-12-25 23:12:01 +01:00

Thank you for the new report, I can reproduce this behavior. The missing key fact was that you don't close the image editor window. The behavior is not exclusive to the exporting of .STLs, it affects all file browser dialogs. It seems the most recently created window, that is a child of a main window, is getting the focus afterwards.

A simpler test is to create two new windows through Window > New Window with adjusted perspective in the 3D view in order to keep track what the most recently created one is. Select the main window and open a file browser windows, e.g. through File > Append and close it by pressing Cancel. The most recently created child window always gets the focus afterwards. This does not apply to a new main window created through Window >New Main Window when there aren't any new child windows yet. When opening and closing the file browser on the new main window it will still returns to the last child window of the original main window. When a child window for the new main window is created through Window > New Window, it will jump this one as well when the test is repeated.

Thank you for the new report, I can reproduce this behavior. The missing key fact was that you don't close the image editor window. The behavior is not exclusive to the exporting of .STLs, it affects all file browser dialogs. It seems the most recently created window, that is a child of a main window, is getting the focus afterwards. A simpler test is to create two new windows through *Window > New Window* with adjusted perspective in the 3D view in order to keep track what the most recently created one is. Select the main window and open a file browser windows, e.g. through *File > Append* and close it by pressing *Cancel*. The most recently created child window always gets the focus afterwards. This does not apply to a new main window created through *Window >New Main Window* when there aren't any new child windows yet. When opening and closing the file browser on the new main window it will still returns to the last child window of the original main window. When a child window for the new main window is created through *Window > New Window*, it will jump this one as well when the test is repeated.

Vanessa Dannenberg commented

2019-12-25 23:49:37 +01:00

Ah, yes, I noticed that behavior as well (in my case, opening the user preferences will re-use other windows such as the Image Editor, if it's open)

Jacques Lucke commented

2020-01-15 11:03:14 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2020-01-15 11:03:14 +01:00

I can reproduce the behavior using the steps described by @rjg.
However, before this task should be confirmed, the task title and description should be updated to reflect the actual bug better to help the developer who is going to work on this.

I can reproduce the behavior using the steps described by @rjg. However, before this task should be confirmed, the task title and description should be updated to reflect the actual bug better to help the developer who is going to work on this.

Robert Guetzkow changed title from ~~Export to STL pops-up Image Editor window~~ to Focus switches to newest child window after closing file browser dialog, not the window that originally had the focus

2020-01-15 21:39:39 +01:00

Robert Guetzkow commented

2020-01-15 21:39:39 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow changed title from ~~Focus switches to newest child window after closing file browser dialog, not the window that originally had the focus~~ to File Browser switches focus to wrong window after closing dialog

2020-01-15 21:40:54 +01:00

Robert Guetzkow changed title from ~~File Browser switches focus to wrong window after closing dialog~~ to File browser puts focus on wrong window after closing the dialog

2020-01-15 21:41:41 +01:00

Julian Eisel commented

2020-01-21 17:18:10 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2020-01-21 17:18:10 +01:00

The reported issue is caused by this workaround: https://developer.blender.org/diffusion/B/browse/master/source/blender/windowmanager/intern/wm_window.c$439

When opening the file browser, we register it in the OS as dialog window - as of now, it's the only kind of window we do that for. For that to work we also need to assign the window to a "parent" window (loosely speaking) to the OS. Now, the OS typically takes over the ordering of windows, moving other non-dialog windows like the Preferences to the back, so that the dialog window and its parent are in front. That makes it seem like the preferences got closed. The workaround is, that we just move other windows back in front when closing a dialog window (i.e. file browser).

Maybe we could workaround this issue too, i.e. by keeping a window selection history. However before too long, we should look into improving our dialog and secondary window behavior, see #69819. With that done, the window ordering workaround that causes this issue can be removed.
So I don't think it's worth the hassle of introducing a temporary workaround for this temporary workaround.
Marking this as "Known Issue".

The reported issue is caused by this workaround: https://developer.blender.org/diffusion/B/browse/master/source/blender/windowmanager/intern/wm_window.c$439 When opening the file browser, we register it in the OS as dialog window - as of now, it's the only kind of window we do that for. For that to work we also need to assign the window to a "parent" window (loosely speaking) to the OS. Now, the OS typically takes over the ordering of windows, moving other non-dialog windows like the Preferences to the back, so that the dialog window and its parent are in front. That makes it seem like the preferences got closed. The workaround is, that we just move other windows back in front when closing a dialog window (i.e. file browser). Maybe we could workaround this issue too, i.e. by keeping a window selection history. However before too long, we should look into improving our dialog and secondary window behavior, see #69819. With that done, the window ordering workaround that causes this issue can be removed. So I don't think it's worth the hassle of introducing a temporary workaround for this temporary workaround. Marking this as "Known Issue".

blender-admin commented

2020-05-20 17:02:36 +02:00

This issue was referenced by 796412dca0

This issue was referenced by 796412dca0a54a0f35400ea8ebf7a99ce891080d

Julian Eisel commented

2020-05-20 17:12:49 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2020-05-20 17:12:49 +02:00

Julian Eisel self-assigned this 2020-05-20 17:12:49 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

File browser puts focus on wrong window after closing the dialog #72693

Open a file browser dialog, e.g. through File > Append and close it