Crash on deleting current workspace from the outliner #75489

New Issue

Bent Hillerkus · 2020-04-07T16:22:52+02:00

Bent Hillerkus commented

2020-04-07 16:22:52 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.75

Blender Version
Broken: version: 2.83 (sub 12), branch: master, commit date: 2020-04-07 11:44, hash: 6feeede47f
Worked: technically 2.79b

Short description of error
You can use the outliner to delete workspace data. When you delete the workspace you are currently in Blender will crash.
I understand that this is something you have to provoke, but I guess that this could be handled a bit more gracefully

Exact steps for others to reproduce the error

Set the display mode in the outliner to "Blender File"
Twirl out "Workspaces"
Delete the one you are currently in

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.75 **Blender Version** Broken: version: 2.83 (sub 12), branch: master, commit date: 2020-04-07 11:44, hash: `6feeede47f` Worked: technically 2.79b **Short description of error** You can use the outliner to delete workspace data. When you delete the workspace you are currently in Blender will crash. I understand that this is something you have to provoke, but I guess that this could be handled a bit more gracefully **Exact steps for others to reproduce the error** - Set the display mode in the outliner to "Blender File" - Twirl out "Workspaces" - Delete the one you are currently in

Bent Hillerkus commented

2020-04-07 16:22:52 +02:00

Added subscriber: @bent

Philipp Oeser commented

2020-04-07 16:28:22 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-04-07 16:28:22 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-04-07 16:28:22 +02:00

Confirmed, checking...

Philipp Oeser changed title from ~~Crash on deleting current workspace~~ to Crash on deleting current workspace from the outliner

2020-04-07 16:29:44 +02:00

Philipp Oeser commented

2020-04-07 17:21:11 +02:00

Added subscribers: @JulianEisel, @mont29

Philipp Oeser commented

2020-04-07 17:21:11 +02:00

Seems like the screen is already invalid (WM_window_get_active_screen, CTX_wm_screen return NULL), while the workspace is still valid (WM_window_get_active_workspace still gets the only just deleted...)

1 ED_screen_do_listen   screen_edit.c     440 0x3549f9b 
2 wm_event_do_notifiers wm_event_system.c 521 0x2ea82b9 
3 WM_main               wm.c              453 0x2ea3b04 
4 main                  creator.c         524 0x2a63259

Not sure exactly how to do this, but instead of the generic BKE_id_delete, we would need the functionality of ED_workspace_delete [doing it properly with ED_workspace_change etc...]

I could dig some more, but maybe @mont29, @JulianEisel know right away?

Seems like the screen is already invalid (`WM_window_get_active_screen`, `CTX_wm_screen` return NULL), while the workspace is still valid (`WM_window_get_active_workspace` still gets the only just deleted...) ``` 1 ED_screen_do_listen screen_edit.c 440 0x3549f9b 2 wm_event_do_notifiers wm_event_system.c 521 0x2ea82b9 3 WM_main wm.c 453 0x2ea3b04 4 main creator.c 524 0x2a63259 ``` Not sure exactly how to do this, but instead of the generic `BKE_id_delete`, we would need the functionality of `ED_workspace_delete` [doing it properly with `ED_workspace_change` etc...] I could dig some more, but maybe @mont29, @JulianEisel know right away?

Brecht Van Lommel commented

2020-04-07 17:37:07 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2020-04-07 17:37:08 +02:00

Deleting a workspace that is in use should just not be allowed I think,

Philipp Oeser commented

2020-04-07 17:43:13 +02:00

In #75489#905563, @brecht wrote:
Deleting a workspace that is in use should just not be allowed I think,

(works if you do it from the workspace tab context menu directly -- just not in the outliner...)

> In #75489#905563, @brecht wrote: > Deleting a workspace that is in use should just not be allowed I think, (works if you do it from the workspace tab context menu directly -- just not in the outliner...)

Brecht Van Lommel commented

2020-04-07 17:48:34 +02:00

Right, but the workspace tab menu will change to another workspace first, and also will do nothing if there is only a single workspace.

For low-level access through the outliner or API I think we should only delete or refuse to delete, not change the active workspace.

Right, but the workspace tab menu will change to another workspace first, and also will do nothing if there is only a single workspace. For low-level access through the outliner or API I think we should only delete or refuse to delete, not change the active workspace.

Julian Eisel commented

2020-04-07 20:33:22 +02:00

I propose this as a simple fix: P1333: Possible fix for #75489

diff --git a/source/blender/editors/space_outliner/outliner_edit.c b/source/blender/editors/space_outliner/outliner_edit.c
index 60e6b423720..3ae100b6209 100644
--- a/source/blender/editors/space_outliner/outliner_edit.c
+++ b/source/blender/editors/space_outliner/outliner_edit.c
@@ -54,6 +54,7 @@
 #include "BKE_outliner_treehash.h"
 #include "BKE_report.h"
 #include "BKE_scene.h"
+#include "BKE_workspace.h"
 
 #include "DEG_depsgraph.h"
 #include "DEG_depsgraph_build.h"
@@ -473,6 +474,14 @@ static void id_delete(bContext *C, ReportList *reports, TreeElement *te, TreeSto
                 id->name);
     return;
   }
+  else if (te->idcode == ID_WS) {
+    BKE_workspace_id_tag_all_visible(bmain, LIB_TAG_DOIT);
+    if (id->tag & LIB_TAG_DOIT) {
+      BKE_reportf(
+          reports, RPT_WARNING, "Cannot delete currently visible workspace id '%s'", id->name);
+      return;
+    }
+  }
 
   BKE_id_delete(bmain, id);

I don't want it to fail silently but give an error message, so this seemed like the best place to do that without bigger changes.

I propose this as a simple fix: [P1333: Possible fix for #75489](https://archive.blender.org/developer/P1333.txt) ``` diff --git a/source/blender/editors/space_outliner/outliner_edit.c b/source/blender/editors/space_outliner/outliner_edit.c index 60e6b423720..3ae100b6209 100644 --- a/source/blender/editors/space_outliner/outliner_edit.c +++ b/source/blender/editors/space_outliner/outliner_edit.c @@ -54,6 +54,7 @@ #include "BKE_outliner_treehash.h" #include "BKE_report.h" #include "BKE_scene.h" +#include "BKE_workspace.h" #include "DEG_depsgraph.h" #include "DEG_depsgraph_build.h" @@ -473,6 +474,14 @@ static void id_delete(bContext *C, ReportList *reports, TreeElement *te, TreeSto id->name); return; } + else if (te->idcode == ID_WS) { + BKE_workspace_id_tag_all_visible(bmain, LIB_TAG_DOIT); + if (id->tag & LIB_TAG_DOIT) { + BKE_reportf( + reports, RPT_WARNING, "Cannot delete currently visible workspace id '%s'", id->name); + return; + } + } BKE_id_delete(bmain, id); ``` I don't want it to fail silently but give an error message, so this seemed like the best place to do that without bigger changes.

Bastien Montagne commented

2020-04-09 10:35:06 +02:00

@JulianEisel that fix looks good to me.

blender-admin commented

2020-04-10 17:28:26 +02:00

This issue was referenced by d216a0b505

This issue was referenced by d216a0b505735da432448c438982b5cac1cba9ee

Julian Eisel commented

2020-04-10 17:31:03 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2020-04-10 17:31:03 +02:00

Julian Eisel self-assigned this 2020-04-10 17:31:03 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash on deleting current workspace from the outliner #75489