Solidify modifier - Only Rim crash in Complex mode #75840

New Issue

Marcin Twarowski · 2020-04-17T18:44:22+02:00

Marcin Twarowski commented

2020-04-17 18:44:22 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 750 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version: 2.83 (sub 13), branch: master, commit date: 2020-04-16 15:38, hash: 8cb10c124e

Short description of error
Selecting Only Rim in Solidify modifier causes crash to desktop. Modifier has to be in Complex mode. It doesn't crash with a simple plane, so it depends on geometry.

solidify_crash.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 750 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87 **Blender Version** Broken: version: 2.83 (sub 13), branch: master, commit date: 2020-04-16 15:38, hash: `8cb10c124e` **Short description of error** Selecting **Only Rim** in **Solidify** modifier causes crash to desktop. Modifier has to be in **Complex** mode. It doesn't crash with a simple plane, so it depends on geometry. ![image.png](https://archive.blender.org/developer/F8479258/image.png) [solidify_crash.blend](https://archive.blender.org/developer/F8479264/solidify_crash.blend)

Marcin Twarowski commented

2020-04-17 18:44:22 +02:00

Added subscriber: @MarcinTwarowski

Vincent Blankfield commented

2020-04-17 19:16:57 +02:00

Added subscriber: @VincentBlankfield

Vincent Blankfield commented

2020-04-17 19:16:57 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Vincent Blankfield commented

2020-04-17 19:16:57 +02:00

Can confirm. Introduced in 35b1cc806f.

Can confirm. Introduced in 35b1cc806f76.

Brecht Van Lommel commented

2020-04-17 19:51:15 +02:00

Added subscriber: @HDMaster84

Brecht Van Lommel commented

2020-04-17 19:52:57 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2020-04-17 19:52:57 +02:00

@VincentBlankfield, for a task to be marked confirmed it needs to have appropriate tags, subscriber, priority, etc. Otherwise it can slip through.

When unsure about those, best to leave the status to Needs Triage and only leave a comment.

@VincentBlankfield, for a task to be marked confirmed it needs to have appropriate tags, subscriber, priority, etc. Otherwise it can slip through. When unsure about those, best to leave the status to Needs Triage and only leave a comment.

Robert Guetzkow commented

2020-04-17 20:31:39 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-04-17 20:31:39 +02:00

MOD_solidify_nonmanifold_applyModifier(ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh) Line 2015	C
applyModifier(ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh) Line 80	C
modwrap_applyModifier(ModifierData * md, const ModifierEvalContext * ctx, Mesh * me) Line 961	C
mesh_calc_modifiers(Depsgraph * depsgraph, Scene * scene, Object * ob, int useDeform, const bool need_mapping, const CustomData_MeshMasks * dataMask, const int index, const bool use_cache, const bool allow_shared_mesh, Mesh * * r_deform, Mesh * * r_final) Line 1179	C
mesh_build_data(Depsgraph * depsgraph, Scene * scene, Object * ob, const CustomData_MeshMasks * dataMask, const bool need_mapping) Line 1785	C
makeDerivedMesh(Depsgraph * depsgraph, Scene * scene, Object * ob, BMEditMesh * em, const CustomData_MeshMasks * dataMask) Line 1902	C
BKE_object_handle_data_update(Depsgraph * depsgraph, Scene * scene, Object * ob) Line 194	C
BKE_object_eval_uber_data(Depsgraph * depsgraph, Scene * scene, Object * ob) Line 385	C
[External Code]	
DEG::`anonymous namespace'::evaluate_node(const DEG::`anonymous-namespace'::DepsgraphEvalState * state, DEG::OperationNode * operation_node) Line 117	C++
DEG::`anonymous namespace'::deg_task_run_func(TaskPool * pool, void * taskdata, int thread_id) Line 129	C++
handle_local_queue(TaskThreadLocalStorage * tls, const int thread_id) Line 423	C++
task_scheduler_thread_run(void * thread_p) Line 462	C++
[External Code]

Crash happens at char bweight = medge[g->edges- [x]->new_edge].bweight;, where medge is accessed out of bounds. In my test new_edge was set to 2^32-1.

``` MOD_solidify_nonmanifold_applyModifier(ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh) Line 2015 C applyModifier(ModifierData * md, const ModifierEvalContext * ctx, Mesh * mesh) Line 80 C modwrap_applyModifier(ModifierData * md, const ModifierEvalContext * ctx, Mesh * me) Line 961 C mesh_calc_modifiers(Depsgraph * depsgraph, Scene * scene, Object * ob, int useDeform, const bool need_mapping, const CustomData_MeshMasks * dataMask, const int index, const bool use_cache, const bool allow_shared_mesh, Mesh * * r_deform, Mesh * * r_final) Line 1179 C mesh_build_data(Depsgraph * depsgraph, Scene * scene, Object * ob, const CustomData_MeshMasks * dataMask, const bool need_mapping) Line 1785 C makeDerivedMesh(Depsgraph * depsgraph, Scene * scene, Object * ob, BMEditMesh * em, const CustomData_MeshMasks * dataMask) Line 1902 C BKE_object_handle_data_update(Depsgraph * depsgraph, Scene * scene, Object * ob) Line 194 C BKE_object_eval_uber_data(Depsgraph * depsgraph, Scene * scene, Object * ob) Line 385 C [External Code] DEG::`anonymous namespace'::evaluate_node(const DEG::`anonymous-namespace'::DepsgraphEvalState * state, DEG::OperationNode * operation_node) Line 117 C++ DEG::`anonymous namespace'::deg_task_run_func(TaskPool * pool, void * taskdata, int thread_id) Line 129 C++ handle_local_queue(TaskThreadLocalStorage * tls, const int thread_id) Line 423 C++ task_scheduler_thread_run(void * thread_p) Line 462 C++ [External Code] ``` Crash happens at `char bweight = medge[g->edges- [x]->new_edge].bweight;`, where `medge` is accessed out of bounds. In my test `new_edge` was set to 2^32-1.

Henrik D. self-assigned this 2020-04-17 21:49:09 +02:00

Henrik D. commented

2020-04-17 21:49:09 +02:00

ok I am pretty sure I know what is happening, should be easy to fix, will do.

blender-admin commented

2020-04-20 16:15:53 +02:00

This issue was referenced by 7865185d98

This issue was referenced by 7865185d986558b5fd40e669c91f86f1967f0304

Bastien Montagne commented

2020-04-20 16:17:14 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2020-04-20 16:17:14 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Solidify modifier - Only Rim crash in Complex mode #75840