Rigid Body properties disappears after deleting rigid body constraint object and undoing #76053

Closed
opened 2020-04-24 15:44:16 +02:00 by Vidar Madsen · 7 comments

System Information
Operating system: Windows-10-10.0.17134-SP0 64 Bits
Graphics card: Quadro K1100M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 425.91

Blender Version
Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-04-23 21:07, hash: d712f1f83a
Worked: (newest version of Blender that worked as expected)

Short description of error
Rigid Body properties disappears from objects after deleting a Rigid Body Constraint and then undoing it.

Example file

  • From new scene, select the Default Cube and duplicate it. Move copy up a bit.
  • Add Mesh -> Plane, then move it down a bit. Object->Rigid Body->Add Passive.
  • Select both cubes and Object->Rigid Body->Add Active
  • With both cubes selected, Object->Rigid Body->Connect

Exact steps for others to reproduce the error
rb_test3.blend

  • Open file
  • Play animation
  • Delete "Constraint" object which holds the RB Constraint.
  • Undo.

Select one of the cubes and see that Physics / Rigid Body properties are now gone.

Interestingly, opening the file, deleting the constraint then immediately undoing without ever having played animation seems not to produce the bug. Perhaps the behaviour is related to frame change?

Deleting the Constraint then undoing twice (to the point before selecting the Constraint) seems to restore the correct state.

**System Information** Operating system: Windows-10-10.0.17134-SP0 64 Bits Graphics card: Quadro K1100M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 425.91 **Blender Version** Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-04-23 21:07, hash: `d712f1f83a` Worked: (newest version of Blender that worked as expected) **Short description of error** Rigid Body properties disappears from objects after deleting a Rigid Body Constraint and then undoing it. **Example file** - From new scene, select the Default Cube and duplicate it. Move copy up a bit. - Add Mesh -> Plane, then move it down a bit. Object->Rigid Body->Add Passive. - Select both cubes and Object->Rigid Body->Add Active - With both cubes selected, Object->Rigid Body->Connect **Exact steps for others to reproduce the error** [rb_test3.blend](https://archive.blender.org/developer/F8492556/rb_test3.blend) - Open file - Play animation - Delete "Constraint" object which holds the RB Constraint. - Undo. Select one of the cubes and see that Physics / Rigid Body properties are now gone. Interestingly, opening the file, deleting the constraint then immediately undoing without ever having played animation seems not to produce the bug. Perhaps the behaviour is related to frame change? Deleting the Constraint then undoing *twice* (to the point *before* selecting the Constraint) seems to restore the correct state.
Author

Added subscriber: @vidarino

Added subscriber: @vidarino
Richard Antalik changed title from Rigid Body properties disappears from objects after deleting a Rigid Body Constraint and then undoing it. to Rigid Body properties disappears after deleting rigid body constraint object and undoing 2020-04-27 16:20:31 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author

While v2.83-beta just got "confused", a current Debug build crashes with the following stack trace:

Info: Deleted 1 object(s)

35: BLI_system_backtrace - 0x7FF7969C5C80
34: rigidbody_update_simulation - 0x7FF78F85B9E0
33: BKE_rigidbody_rebuild_world - 0x7FF78F857D30
32: BKE_rigidbody_rebuild_sim - 0x7FF78F857C40
31: std::_Invoker_functor::_Call<void (__cdecl*&)(Depsgraph *,Scene *),Depsgraph *,Scene * &> - 0x7FF790F1A8E0
30: std::invoke<void (__cdecl*&)(Depsgraph *,Scene *),Depsgraph *,Scene * &> - 0x7FF790F2D780
29: std::_Invoker_ret<std::_Unforced,0>::_Call<void (__cdecl*&)(Depsgraph *,Scene *),Depsgraph *,Scene * &> - 0x7FF790F1A820
28: std::_Call_binder<std::_Unforced,0,1,void (__cdecl*)(Depsgraph *,Scene *),std::tuple<std::_Ph<1>,Scene *>,std::tuple<Depsgraph * &&> > - 0x7FF790F1E940
27: std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &>::operator()<Depsgraph *> - 0x7FF790F18B20
26: std::_Invoker_functor::_Call<std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &> &,Depsgraph *> - 0x7FF790F1C7A0
25: std::invoke<std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &> &,Depsgraph *> - 0x7FF790F2E6F0
24: std::_Invoker_ret<void,1>::_Call<std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &> &,Depsgraph *> - 0x7FF790F1C700
23: std::_Func_impl_no_alloc<std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &>,void,Depsgraph *>::_Do_call - 0x7FF790F3BD30
22: std::_Func_class<void,Depsgraph *>::operator() - 0x7FF790F7F180
21: DEG::`anonymous namespace'::evaluate_node - 0x7FF790F7FBB0
20: DEG::`anonymous namespace'::deg_task_run_func - 0x7FF790F7F8C0
19: BLI_task_pool_work_and_wait - 0x7FF796A72A50
18: DEG::deg_evaluate_on_refresh - 0x7FF790F7F670
17: DEG_evaluate_on_framechange - 0x7FF790EAA5B0
16: BKE_scene_graph_update_for_newframe - 0x7FF78F682480
15: ED_update_for_newframe - 0x7FF7903FEEC0
14: screen_animation_step - 0x7FF790428AA0
13: wm_operator_invoke - 0x7FF78FAACF10
12: wm_handler_operator_call - 0x7FF78FAA8330
11: wm_handlers_do_keymap_with_keymap_handler - 0x7FF78FAAB550
10: wm_handlers_do_intern - 0x7FF78FAAA8B0
9: wm_handlers_do - 0x7FF78FAA9350
8: wm_event_do_handlers - 0x7FF78FAA3F00
7: WM_main - 0x7FF78FA7A6A0
6: main - 0x7FF78F297840
5: invoke_main - 0x7FF797B3CFA0
4: __scrt_common_main_seh - 0x7FF797B3CD50
3: __scrt_common_main - 0x7FF797B3CD30
2: mainCRTStartup - 0x7FF797B3D060
1: BaseThreadInitThunk - 0x7FFD6FEE4020
0: RtlUserThreadStart - 0x7FFD722D3670
BLI_assert failed: c:\...\blender-git\blender\source\blender\blenkernel\intern\rigidbody.c:1729, rigidbody_update_simulation(), at '!"CoW object part of RBW object collection without RB object data, " "should not happen.\n"'

Probably not too useful, as I suspect the damage has been done prior to rigidbody_update_simulation(), but who knows.

While v2.83-beta just got "confused", a current Debug build crashes with the following stack trace: ``` Info: Deleted 1 object(s) 35: BLI_system_backtrace - 0x7FF7969C5C80 34: rigidbody_update_simulation - 0x7FF78F85B9E0 33: BKE_rigidbody_rebuild_world - 0x7FF78F857D30 32: BKE_rigidbody_rebuild_sim - 0x7FF78F857C40 31: std::_Invoker_functor::_Call<void (__cdecl*&)(Depsgraph *,Scene *),Depsgraph *,Scene * &> - 0x7FF790F1A8E0 30: std::invoke<void (__cdecl*&)(Depsgraph *,Scene *),Depsgraph *,Scene * &> - 0x7FF790F2D780 29: std::_Invoker_ret<std::_Unforced,0>::_Call<void (__cdecl*&)(Depsgraph *,Scene *),Depsgraph *,Scene * &> - 0x7FF790F1A820 28: std::_Call_binder<std::_Unforced,0,1,void (__cdecl*)(Depsgraph *,Scene *),std::tuple<std::_Ph<1>,Scene *>,std::tuple<Depsgraph * &&> > - 0x7FF790F1E940 27: std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &>::operator()<Depsgraph *> - 0x7FF790F18B20 26: std::_Invoker_functor::_Call<std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &> &,Depsgraph *> - 0x7FF790F1C7A0 25: std::invoke<std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &> &,Depsgraph *> - 0x7FF790F2E6F0 24: std::_Invoker_ret<void,1>::_Call<std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &> &,Depsgraph *> - 0x7FF790F1C700 23: std::_Func_impl_no_alloc<std::_Binder<std::_Unforced,void (__cdecl&)(Depsgraph *,Scene *),std::_Ph<1> const &,Scene * &>,void,Depsgraph *>::_Do_call - 0x7FF790F3BD30 22: std::_Func_class<void,Depsgraph *>::operator() - 0x7FF790F7F180 21: DEG::`anonymous namespace'::evaluate_node - 0x7FF790F7FBB0 20: DEG::`anonymous namespace'::deg_task_run_func - 0x7FF790F7F8C0 19: BLI_task_pool_work_and_wait - 0x7FF796A72A50 18: DEG::deg_evaluate_on_refresh - 0x7FF790F7F670 17: DEG_evaluate_on_framechange - 0x7FF790EAA5B0 16: BKE_scene_graph_update_for_newframe - 0x7FF78F682480 15: ED_update_for_newframe - 0x7FF7903FEEC0 14: screen_animation_step - 0x7FF790428AA0 13: wm_operator_invoke - 0x7FF78FAACF10 12: wm_handler_operator_call - 0x7FF78FAA8330 11: wm_handlers_do_keymap_with_keymap_handler - 0x7FF78FAAB550 10: wm_handlers_do_intern - 0x7FF78FAAA8B0 9: wm_handlers_do - 0x7FF78FAA9350 8: wm_event_do_handlers - 0x7FF78FAA3F00 7: WM_main - 0x7FF78FA7A6A0 6: main - 0x7FF78F297840 5: invoke_main - 0x7FF797B3CFA0 4: __scrt_common_main_seh - 0x7FF797B3CD50 3: __scrt_common_main - 0x7FF797B3CD30 2: mainCRTStartup - 0x7FF797B3D060 1: BaseThreadInitThunk - 0x7FFD6FEE4020 0: RtlUserThreadStart - 0x7FFD722D3670 BLI_assert failed: c:\...\blender-git\blender\source\blender\blenkernel\intern\rigidbody.c:1729, rigidbody_update_simulation(), at '!"CoW object part of RBW object collection without RB object data, " "should not happen.\n"' ``` Probably not too useful, as I suspect the damage has been done prior to rigidbody_update_simulation(), but who knows.

Added subscribers: @mont29, @brecht

Added subscribers: @mont29, @brecht

Might be an issue in the new undo code, so marking as high.

Might be an issue in the new undo code, so marking as high.
Bastien Montagne was assigned by Dalai Felinto 2020-05-11 14:34:02 +02:00

This issue was referenced by 8da7ab11cf

This issue was referenced by 8da7ab11cf63d36577b5bd1e96bae637b0bd464c

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Thomas Dinges added this to the 2.83 LTS milestone 2023-02-08 16:38:05 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#76053
No description provided.