DrawManager: Use Task Graph for mesh extraction #76298
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#76298
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This part of the design will go over the changes for improving the draw manager threading. The design is based on D7578: Task: Graph Flow Task Scheduling.
In order to create the MeshRenderData in a task we need to split
mesh_render_data_create
in two phases. First phase will not happen in the callers thread and is responsible to create theMeshRenderData
instance and fill it with the statistics of the mesh. These statistics are used to define how the scheduling would take place.The second phase would do the heavier lifting and would happen in a separate
TaskNode
(task_node_mesh_render_data
).There will be several additional task_nodes.
Single threaded extraction
in a single task. we can tweak afterwards if we need to split this into multiple tasks.One task for the whole VBO.
The
extract_lines_loose
should be removed and we based on the existance ofibo.lines
we should do it in the finalize of theextract_lines
or as part of the Single threaded extraction when the lines were already up to date. As we only need to callextract_lines_loose_finish
directly.The
TaskGraph
will be instantiated in thedraw_manager.c
Main Draw Loops
And stored in the DrawContext. We need to do this to keep the hacky-optimization that generates the batches during the free-ing of theghash
indrw_duplidata_free
.Added subscriber: @Jeroen-Bakker
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @geocentric_wage
Added subscriber: @AlexeyPerminov
This issue was referenced by
bf34b0c8f4
Changed status from 'Confirmed' to: 'Resolved'
Closing as the developments already landed in master.