blender
/
blender
126
393
Fork 565
Code Issues 6.2k Pull Requests 751 Projects 19 Wiki Activity

Properties Search Implementation #77824

New Issue
Closed
opened 2020-06-13 01:45:36 +02:00 by Hans Goudey · 20 comments
Hans Goudey commented 2020-06-13 01:45:36 +02:00
Member
Copy Link

Status: In polishing phase

Team
Commissioner: @WilliamReynish
Project leader: @HooglyBoogly

Description
Big picture: Method to filter properties in the properties editor, but general enough to use elsewhere too

Use cases:

  • A general way to find that one setting you always lose track of
  • In more complicated situations, a faster way to navigate to a property than to scroll to and expand the relevant panels

Design:
#71185

Engineer plan:
Two new "passes" will be needed:

  1. A filter for buttons that don't match the filter at the end of the layout code,
  2. A "simple layout" pass, which runs a simpler version of the layout code for panels in all tabs to highlight the ones with active items.
    It would also be conceivable to build the property search layout during the same pass as the regular layout code,
    but there are a few downsides to that method, mostly in the added complexity to the regular layout code.

Work plan

Milestone 1 - Poperty Search and Panels
Time estimate: A week or two

  • Search filter
    • RNA property buttons
    • Operator buttons
    • Search based on label buttons
    • Menu buttons
    • Box buttons
    • Add some fuzziness to the matching (D9145)
  • Highlighting and dimming of buttons
    • Highlight on panel headers
    • Highlight on subpanel label text
    • Dimming of icons_only=True buttons (e.g., lock)
    • Highlight button labels
  • Interaction with panels
    • Search closed panels and their subpanels
    • Change panel expansion
      • Auto expand matching panels and subpanels (and collapse others)
      • Revert expansion to before search (keep changes where user interacted) (D8984)
    • Panels animate as the search changes
    • Match entire panel if panel label matches search
  • Make pin button work in header
  • ctrl-F to activate search box
    • alt-F to clear seach box

Milestone 2 - Highlight Tabs with Filtered Items
Time estimate: A week

  • Duplicate the properties editor and run the search
    • Get search to run
    • Store "has property" per tab
    • Fix all consequences of duplicating the space / memory leaks
  • Add the ability to gray out some icons to tabs layout
  • Investigate performance
  • ? Switch to the next highlighted tab if the current tab is empty

Milestone 3 - Performance
Time estimate: About a week

  • ? Use ghash instead of string lookups
  • ? Look into using ED_region_tag_redraw_no_rebuild for some interactions

Branch: master

**Status:** In polishing phase --- **Team** **Commissioner:** @WilliamReynish **Project leader:** @HooglyBoogly **Description** **Big picture:** Method to filter properties in the properties editor, but general enough to use elsewhere too **Use cases**: * A general way to find that one setting you always lose track of * In more complicated situations, a faster way to navigate to a property than to scroll to and expand the relevant panels **Design:** #71185 **Engineer plan:** Two new "passes" will be needed: 1. A filter for buttons that don't match the filter at the end of the layout code, 2. A "simple layout" pass, which runs a simpler version of the layout code for panels in all tabs to highlight the ones with active items. It would also be conceivable to build the property search layout during the same pass as the regular layout code, but there are a few downsides to that method, mostly in the added complexity to the regular layout code. **Work plan** **Milestone 1 - Poperty Search and Panels** Time estimate: *A week or two* - [x] Search filter - [x] RNA property buttons - [x] Operator buttons - [x] Search based on label buttons - [x] Menu buttons - [x] Box buttons - [ ] Add some fuzziness to the matching ([D9145](https://archive.blender.org/developer/D9145)) - [x] Highlighting and dimming of buttons - [x] Highlight on panel headers - [x] Highlight on subpanel label text - [x] Dimming of icons_only=True buttons (e.g., lock) - [x] Highlight button labels - [x] Interaction with panels - [x] Search closed panels and their subpanels - [x] Change panel expansion - [x] Auto expand matching panels and subpanels (and collapse others) - [ ] Revert expansion to before search (keep changes where user interacted) ([D8984](https://archive.blender.org/developer/D8984)) - [x] Panels animate as the search changes - [x] Match entire panel if panel label matches search - [x] Make pin button work in header - [x] ctrl-F to activate search box - [x] alt-F to clear seach box **Milestone 2 - Highlight Tabs with Filtered Items** Time estimate: *A week* - [x] Duplicate the properties editor and run the search - [x] Get search to run - [x] Store "has property" per tab - [x] Fix all consequences of duplicating the space / memory leaks - [x] Add the ability to gray out some icons to tabs layout - [x] Investigate performance - [x] `?` Switch to the next highlighted tab if the current tab is empty **Milestone 3 - Performance** Time estimate: About a week - [ ] `?` Use ghash instead of string lookups - [ ] `?` Look into using `ED_region_tag_redraw_no_rebuild` for some interactions **Branch**: `master`
Hans Goudey self-assigned this 2020-06-13 01:45:36 +02:00
Hans Goudey commented 2020-06-13 01:45:36 +02:00
Author
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Hans Goudey commented 2020-06-13 01:45:36 +02:00
Author
Member
Copy Link

Added subscribers: @HooglyBoogly, @WilliamReynish

Added subscribers: @HooglyBoogly, @WilliamReynish
Duarte Farrajota Ramos commented 2020-06-13 02:11:31 +02:00
Copy Link

Added subscriber: @DuarteRamos

Added subscriber: @DuarteRamos
Manuel Grad commented 2020-07-30 22:58:18 +02:00
Copy Link

Added subscriber: @ManuelGrad

Added subscriber: @ManuelGrad
Manuel Grad commented 2020-07-30 22:58:18 +02:00
Copy Link

This comment was removed by @manuelgrad1

*This comment was removed by @manuelgrad1*
RedMser commented 2020-08-02 17:20:54 +02:00
Contributor
Copy Link

Added subscriber: @RedMser

Added subscriber: @RedMser
blender-admin commented 2020-09-11 21:08:38 +02:00
Copy Link

This issue was referenced by a550937116

This issue was referenced by a55093711644f1a87eb058d2bed20d530a4de155
blender-admin commented 2020-09-15 16:38:19 +02:00
Copy Link

This issue was referenced by 67e630609b

This issue was referenced by 67e630609bb408e366398cb7ea9fdc09f31190e7
blender-admin commented 2020-09-15 16:50:14 +02:00
Copy Link

This issue was referenced by 6b29c3fa07

This issue was referenced by 6b29c3fa07f54a0b0d123a90049fbad36a1334c2
blender-admin commented 2020-09-15 17:34:38 +02:00
Copy Link

This issue was referenced by f59ce4d55c

This issue was referenced by f59ce4d55c04a61a10d9e9567b53ee652972b60a
blender-admin commented 2020-09-15 18:25:49 +02:00
Copy Link

This issue was referenced by 8bcdcab659

This issue was referenced by 8bcdcab659fb688d976a50d892dcb4285ff2a180
blender-admin commented 2020-09-15 18:39:25 +02:00
Copy Link

This issue was referenced by bedbd8655e

This issue was referenced by bedbd8655ed1d331aeaf756874c46dbed93168a1
Vyacheslav Kobozev commented 2020-10-10 16:10:32 +02:00
Copy Link

Added subscriber: @Vyach

Added subscriber: @Vyach
Vyacheslav Kobozev commented 2020-10-10 16:10:32 +02:00
Copy Link

Thanks a lot for seach through addon list! It helps a lot now!
I use many addons and disabled some of them to keep workspace clean.
So search allow to switch em easier.

Thanks a lot for seach through addon list! It helps a lot now! I use many addons and disabled some of them to keep workspace clean. So search allow to switch em easier.
Hans Goudey commented 2020-10-13 01:01:01 +02:00
Author
Member
Copy Link

Thanks for mentioning that. I'm glad it helps!

Thanks for mentioning that. I'm glad it helps!
blender-admin commented 2020-10-13 19:43:28 +02:00
Copy Link

This issue was referenced by 96dd299055

This issue was referenced by 96dd299055a1ce35819480f3c4b938f8e6f91537
blender-admin commented 2020-10-13 20:10:41 +02:00
Copy Link

This issue was referenced by 7c633686e9

This issue was referenced by 7c633686e99512d33391f30e4602213ed3890802
blender-admin commented 2020-10-16 22:16:44 +02:00
Copy Link

This issue was referenced by 54da72d3cd

This issue was referenced by 54da72d3cd546ecbd2560d7d57cbed33064bbee1
Hans Goudey commented 2020-10-29 21:13:01 +01:00
Author
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Hans Goudey commented 2020-10-29 21:13:01 +01:00
Author
Member
Copy Link

#82236 contains some follow-up improvements

#82236 contains some follow-up improvements
Thomas Dinges added this to the 2.92 milestone 2023-02-08 16:16:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
brush-assets-project
universal-scene-description
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
2.92
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Hans Goudey
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#77824
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?