Adjust Last Operation: Other changes outside that panel are reverted back automatically #78171

New Issue

Vyacheslav Kobozev · 2020-06-23T19:35:39+02:00

2020-06-23 19:35:39 +02:00

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-22 22:06, hash: 51bf04383a
Worked: (newest version of Blender that worked as expected)

Short description of error
Here the demo and file
2020-06-23_20-30-11.mp4
Scene state reset.blend

Exact steps for others to reproduce the error

Add some objects, add last one
Change visibility for other objects via outliner
Change property in adjustment popup
Scene settings resetted to previous

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87 **Blender Version** Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-22 22:06, hash: `51bf04383a` Worked: (newest version of Blender that worked as expected) **Short description of error** Here the demo and file [2020-06-23_20-30-11.mp4](https://archive.blender.org/developer/F8639389/2020-06-23_20-30-11.mp4) [Scene state reset.blend](https://archive.blender.org/developer/F8639397/Scene_state_reset.blend) **Exact steps for others to reproduce the error** 1. Add some objects, add last one 2. Change visibility for other objects via outliner 3. Change property in adjustment popup 4. Scene settings resetted to previous

Vyacheslav Kobozev commented

2020-06-23 19:35:39 +02:00

Added subscriber: @Vyach

blender-admin commented

2020-06-23 19:35:39 +02:00

#103647 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#102239 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#96006 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#91038 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#92398 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#89460 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#88642 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#88224 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#85705 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#81370 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#80615 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#58839 was marked as duplicate of this issue

blender-admin commented

2020-06-23 19:35:39 +02:00

#63915 was marked as duplicate of this issue

Vyacheslav Kobozev changed title from ~~Scene state reset during changing property for new object~~ to Scene`s state resets during changing property for new object

2020-06-23 21:35:32 +02:00

Philipp Oeser commented

2020-06-24 11:40:10 +02:00

Added subscribers: @WilliamReynish, @JulianEisel, @ideasman42, @lichtwerk

Philipp Oeser commented

2020-06-24 11:40:10 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-06-24 11:40:10 +02:00

I think this is a general issue with Redo/Adjust Last Operation (but this could very well be a design limitation atm):

A similar issue also came up in #73302, see, my reply there #73302#856078

The Adjust Last Operation panel stays as long as you dont execute another operator. Change visibility for other objects via outliner [or basically any setting in the property editor] is not an operator (if it was another operator, the panel would close), so this panel stays open. Doing adjustments in this panel then will hop back in the undo stack, so changes done to settings after the operator execution get wiped again.
Not sure if this can easily be done, but I would propose to just close the Adjust Last Operation panel upon unrelated [non-operator] property changes, which should get rid of this confusion.

I assume this is not a bug, but maybe something the User Interface team can comment upon [or close if this is not considered to be changed anytime soon]?
Will update the tilte to reflect my findings.

CC @JulianEisel
CC @ideasman42
CC @WilliamReynish

I think this is a general issue with Redo/Adjust Last Operation (but this could very well be a design limitation atm): A similar issue also came up in #73302, see, my reply there #73302#856078 The Adjust Last Operation panel stays as long as you dont execute another **operator**. Change visibility for other objects via outliner [or basically any setting in the property editor] is not an **operator** (if it was another **operator**, the panel would close), so this panel stays open. Doing adjustments in this panel then will hop back in the undo stack, so changes done to settings after the operator execution get wiped again. Not sure if this can easily be done, but I would propose to just close the Adjust Last Operation panel upon unrelated [non-operator] property changes, which should get rid of this confusion. I *assume* this is not a bug, but maybe something the User Interface team can comment upon [or close if this is not considered to be changed anytime soon]? Will update the tilte to reflect my findings. CC @JulianEisel CC @ideasman42 CC @WilliamReynish

Philipp Oeser changed title from ~~Scene`s state resets during changing property for new object~~ to Operator Redo/Adjust Last Operation: panel stays open, changes to unrelated properties (done after operator execution) will get undone when changing properties in the panel again

2020-06-24 11:40:26 +02:00

Julian Eisel commented

2020-06-24 12:38:27 +02:00

This is indeed a design limitation/issue, not a bug.

We could clear the undo registry when doing the undo push for a button, removing the panel:

diff --git a/source/blender/editors/interface/interface_handlers.c b/source/blender/editors/interface/interface_handlers.c
index 3f3f0513184..305bcd1eb0f 100644
    - a/source/blender/editors/interface/interface_handlers.c
+++ b/source/blender/editors/interface/interface_handlers.c
@@ -946,6 +946,7 @@ static void ui_apply_but_funcs_after(bContext *C)

ui_afterfunc_update_preferences_dirty(&after);

if (after.undostr[0]) {

+      WM_operator_stack_clear(CTX_wm_manager(C));

 ED_undo_push(C, after.undostr);

}
}

diff --git a/source/blender/editors/interface/interface_region_hud.c b/source/blender/editors/interface/interface_region_hud.c
index 1f8af7b9e6e..c02047fef94 100644
    - a/source/blender/editors/interface/interface_region_hud.c
+++ b/source/blender/editors/interface/interface_region_hud.c
@@ -231,11 +231,27 @@ static void hud_region_draw(const bContext *C, ARegion *region)

}

 }
 
+static void hud_region_listener(wmWindow *UNUSED(win),
+                                ScrArea *UNUSED(area),
+                                ARegion *region,
+                                wmNotifier *wmn,
+                                const Scene *UNUSED(scene))
+{
+  switch (wmn->category) {
+    case NC_WM:
+      if (wmn->data == ND_HISTORY) {
+        ED_region_tag_redraw(region);
+      }
+      break;
+  }
+}
+
 ARegionType *ED_area_type_hud(int space_type)
 {

ARegionType *art = MEM_callocN(sizeof(ARegionType), func);
art->regionid = RGN_TYPE_HUD;
art->keymapflag = ED_KEYMAP_UI | ED_KEYMAP_VIEW2D;

+  art->listener = hud_region_listener;

art->layout = hud_region_layout;
art->draw = hud_region_draw;
art->init = hud_region_init;

This is quite a design change though, not sure if it's a good idea.

This is indeed a design limitation/issue, not a bug. We *could* clear the undo registry when doing the undo push for a button, removing the panel: ``` lines=10 diff --git a/source/blender/editors/interface/interface_handlers.c b/source/blender/editors/interface/interface_handlers.c index 3f3f0513184..305bcd1eb0f 100644 - a/source/blender/editors/interface/interface_handlers.c +++ b/source/blender/editors/interface/interface_handlers.c @@ -946,6 +946,7 @@ static void ui_apply_but_funcs_after(bContext *C) ``` ui_afterfunc_update_preferences_dirty(&after); ``` ``` if (after.undostr[0]) { ``` + WM_operator_stack_clear(CTX_wm_manager(C)); ``` ED_undo_push(C, after.undostr); } } ``` diff --git a/source/blender/editors/interface/interface_region_hud.c b/source/blender/editors/interface/interface_region_hud.c index 1f8af7b9e6e..c02047fef94 100644 - a/source/blender/editors/interface/interface_region_hud.c +++ b/source/blender/editors/interface/interface_region_hud.c @@ -231,11 +231,27 @@ static void hud_region_draw(const bContext *C, ARegion *region) ``` } ``` } +static void hud_region_listener(wmWindow *UNUSED(win), + ScrArea *UNUSED(area), + ARegion *region, + wmNotifier *wmn, + const Scene *UNUSED(scene)) +{ + switch (wmn->category) { + case NC_WM: + if (wmn->data == ND_HISTORY) { + ED_region_tag_redraw(region); + } + break; + } +} + ARegionType *ED_area_type_hud(int space_type) { ``` ARegionType *art = MEM_callocN(sizeof(ARegionType), __func__); art->regionid = RGN_TYPE_HUD; art->keymapflag = ED_KEYMAP_UI | ED_KEYMAP_VIEW2D; ``` + art->listener = hud_region_listener; ``` art->layout = hud_region_layout; art->draw = hud_region_draw; art->init = hud_region_init; ``` ``` This is quite a design change though, not sure if it's a good idea.

Julian Eisel commented

2020-06-26 18:40:24 +02:00

Added subscribers: @gadic, @demmordor, @iss, @SonicBlue, @ZedDB

Julian Eisel changed title from ~~Operator Redo/Adjust Last Operation: panel stays open, changes to unrelated properties (done after operator execution) will get undone when changing properties in the panel again~~ to Adjust Last Operation: Changes in Outliner are reverted back automatically

2020-06-26 18:48:16 +02:00

Julian Eisel commented

2020-06-26 18:57:01 +02:00

Added subscriber: @user1

Philipp Oeser changed title from ~~Adjust Last Operation: Changes in Outliner are reverted back automatically~~ to Adjust Last Operation: Other changes outside that panel are reverted back automatically

2020-09-11 18:21:50 +02:00

Philipp Oeser commented

2020-09-11 18:22:41 +02:00

Added subscriber: @3di

Richard Antalik commented

2020-10-08 21:48:06 +02:00

Added subscriber: @LostSense

Jer Bot commented

2020-12-30 02:45:34 +01:00

Added subscriber: @JerBot

Philipp Oeser commented

2021-02-16 19:30:18 +01:00

Added subscriber: @Benni334

Richard Antalik commented

2021-05-12 16:53:52 +02:00

Added subscriber: @SergeyIvanov

Julian Eisel commented

2021-05-12 17:07:57 +02:00

To be clear what I explained above would mean that after changing the object visibility, or any other (non-UI) setting, the Adjust Last Operation panel would disappear.

So it makes something impossible that was sort of possible before (editing operator properties after changing object visibility, or render settings or such), but it would behave unexpected and apparently broken. Users may not even notice that their changes were undone. I find that quite bad.

So maybe we should do what I suggested for 3.0. Curious what others think, e.g. what do you think @ideasman42?

To be clear what I explained above would mean that after changing the object visibility, or any other (non-UI) setting, the *Adjust Last Operation* panel would disappear. So it makes something impossible that was sort of possible before (editing operator properties after changing object visibility, or render settings or such), but it would behave unexpected and apparently broken. Users may not even notice that their changes were undone. I find that quite bad. So maybe we should do what I suggested for 3.0. Curious what others think, e.g. what do you think @ideasman42?

Evan Wilson commented

2021-05-28 09:47:25 +02:00

Added subscriber: @ephraimpauli

Philipp Oeser commented

2021-06-29 11:20:24 +02:00

Added subscriber: @Geposs

Germano Cavalcante commented

2021-10-26 22:40:38 +02:00

Added subscribers: @XDroid-3, @mano-wii, @PratikPB2123

Pratik Borhade commented

2021-10-28 12:01:25 +02:00

Added subscriber: @blenderrocket

Pratik Borhade commented

2022-11-03 04:59:36 +01:00

This looks identical to #96006 (The Replacement of Outliner Histories on use of Redo panel)
Can me merge these reports in either way?

This looks identical to #96006 (The Replacement of Outliner Histories on use of Redo panel) Can me merge these reports in either way?

Philipp Oeser commented

2022-11-03 06:19:47 +01:00

In #78171#1440351, @PratikPB2123 wrote:
This looks identical to #96006 (The Replacement of Outliner Histories on use of Redo panel)
Can me merge these reports in either way?

would merge into this one

> In #78171#1440351, @PratikPB2123 wrote: > This looks identical to #96006 (The Replacement of Outliner Histories on use of Redo panel) > Can me merge these reports in either way? would merge into this one

Pratik Borhade commented

2022-11-03 06:53:08 +01:00

Added subscriber: @toki46-3

Pratik Borhade commented

2022-11-03 11:14:44 +01:00

Added subscriber: @Luciano

Pratik Borhade commented

2023-01-05 06:45:48 +01:00

Added subscriber: @gfxcoder

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Adjust Last Operation: Other changes outside that panel are reverted back automatically #78171