2.83 shader editor mouse wheel zoom performance regression #78495

Closed
opened 2020-07-01 12:37:11 +02:00 by Ludvik Koutny · 16 comments
Contributor

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.48

Blender Version
Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: 211b6c29f7
Worked: 2.82 and earlier

Short description of error
In 2.83, there is unsettling, noticeable input lag when zooming in and out in shader editor using mouse wheel. When zooming using hotkey combination (smoothly) there is no difference, but when zooming using mouse wheel, the difference is noticeable. The lag is not present there in 2.82 and earlier.

Exact steps for others to reproduce the error

  1. Launch Blender 2.82, and open scene which has at least one shading node in the shader editor.
  2. Zoom in and out rapidly using mouse wheel
  3. Notice zooming is fast and immediate
  4. Launch Blender 2.83, and open scene which has at least one shading node in the shader editor.
  5. Zoom in and out rapidly using mouse wheel

Result: Zooming in and out in shader editor in 2.83 has noticeable lag/delay.
Expected: Zooming in and out in shader editor performs as well as it did in 2.82 and earlier.

Here is link to a video recorded at 240FPS and encoded at 60FPS (25% speed):
https://www.youtube.com/watch?v=clXM-gPvgvk
It's clearly visible that the zooming framerate is much worse in 2.83 in the identical scene. What's interesting is that it applies only to mouse wheel initiated zoom specifically.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.48 **Blender Version** Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: `211b6c29f7` Worked: 2.82 and earlier **Short description of error** In 2.83, there is unsettling, noticeable input lag when zooming in and out in shader editor using mouse wheel. When zooming using hotkey combination (smoothly) there is no difference, but when zooming using mouse wheel, the difference is noticeable. The lag is not present there in 2.82 and earlier. **Exact steps for others to reproduce the error** 1. Launch Blender 2.82, and open scene which has at least one shading node in the shader editor. 2. Zoom in and out rapidly using mouse wheel 3. Notice zooming is fast and immediate 4. Launch Blender 2.83, and open scene which has at least one shading node in the shader editor. 5. Zoom in and out rapidly using mouse wheel Result: Zooming in and out in shader editor in 2.83 has noticeable lag/delay. Expected: Zooming in and out in shader editor performs as well as it did in 2.82 and earlier. Here is link to a video recorded at 240FPS and encoded at 60FPS (25% speed): https://www.youtube.com/watch?v=clXM-gPvgvk It's clearly visible that the zooming framerate is much worse in 2.83 in the identical scene. What's interesting is that it applies only to mouse wheel initiated zoom specifically.
Author
Contributor

Added subscriber: @Rawalanche

Added subscriber: @Rawalanche

Added subscriber: @iss

Added subscriber: @iss

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'

I can not reproduce this issue.

Does this happen with default file and when you click on File > Defaults > Load Factory Settings?

I can not reproduce this issue. Does this happen with default file and when you click on File > Defaults > Load Factory Settings?
Author
Contributor

In #78495#971137, @iss wrote:
I can not reproduce this issue.

Does this happen with default file and when you click on File > Defaults > Load Factory Settings?

Yes, it does. Are you testing on Windows or Linux? Also, keep in mind the video is slowed down from 240 to 60FPS, so you won't actually see as much difference, but you can feel it if you keep zooming in and out using mouse wheel only rapidly.

I am quite sure that if you are on Windows, you are able to reproduce it but you aren't sensitive enough to lag to be able to tell. Regardless, it appears the mouse wheel zooming framerate is at least half of what it used to be in 2.82 (with factory default settings). So some profiling is in order.

I suggest you try to launch both at once, and place the windows next to each other like on the video. It's easier to feel/stop if you can switch between them rapidly and compare immediately.

> In #78495#971137, @iss wrote: > I can not reproduce this issue. > > Does this happen with default file and when you click on File > Defaults > Load Factory Settings? Yes, it does. Are you testing on Windows or Linux? Also, keep in mind the video is slowed down from 240 to 60FPS, so you won't actually see as much difference, but you can feel it if you keep zooming in and out using **mouse wheel only** rapidly. I am quite sure that if you are on Windows, you are able to reproduce it but you aren't sensitive enough to lag to be able to tell. Regardless, it appears the mouse wheel zooming framerate is at least half of what it used to be in 2.82 (with factory default settings). So some profiling is in order. I suggest you try to launch both at once, and place the windows next to each other like on the video. It's easier to feel/stop if you can switch between them rapidly and compare immediately.

I am testing on windows, and I can not feel any difference.

! In #78495#971272, @Rawalanche wrote:
I suggest you try to launch both at once, and place the windows next to each other like on the video. It's easier to feel/stop if you can switch between them rapidly and compare immediately.

That is exactly what I did

Does this happen when you hold down ctrl + middle mouse button and move mouse up and down in shader editor?

To be sure we compare same scenario as you report, please specify what software you used to record video at what settings, and upload example .blend file with ideally visibly bad performance.

I am testing on windows, and I can not feel any difference. >! In #78495#971272, @Rawalanche wrote: > I suggest you try to launch both at once, and place the windows next to each other like on the video. It's easier to feel/stop if you can switch between them rapidly and compare immediately. That is exactly what I did Does this happen when you hold down ctrl + middle mouse button and move mouse up and down in shader editor? To be sure we compare same scenario as you report, please specify what software you used to record video at what settings, and upload example .blend file with ideally visibly bad performance.
Author
Contributor

In #78495#971910, @iss wrote:
I am testing on windows, and I can not feel any difference.

In #78495#971272, @Rawalanche wrote:

I suggest you try to launch both at once, and place the windows next to each other like on the video. It's easier to feel/stop if you can switch between them rapidly and compare immediately.

That is exactly what I did

Does this happen when you hold down ctrl + middle mouse button and move mouse up and down in shader editor?

To be sure we compare same scenario as you report, please specify what software you used to record video at what settings, and upload example .blend file with ideally visibly bad performance.

  1. No, it does not happen with Ctrl+Middle Mouse smooth zoom, as I stated in the task description.
  2. It was recorded using OBS studio, set up to record at 240FPS:
    image.png
  3. There is no point providing the blend file. It happens even in a new scene with completely empty shader editor. The amount of nodes has no impact on the performance hit. It's constant regardless of if there is 0 or 100 nodes.
  4. I still think you are able to reproduce it, just not sensitive enough to the lag to actually notice it, but I do. That was actually the reason I had to record at 240FPS and then slow down the video to 25%. Because the lag is NOT visible, but it can be felt.

What's actually needed here is for someone to profile the execution time of the function responsible for zooming in shader editor using mouse wheel in both 2.82 and 2.83, and then compare the resulting execution times. Then I am pretty sure 2.83 will be less than half of 2.82.

> In #78495#971910, @iss wrote: > I am testing on windows, and I can not feel any difference. > > In #78495#971272, @Rawalanche wrote: >> I suggest you try to launch both at once, and place the windows next to each other like on the video. It's easier to feel/stop if you can switch between them rapidly and compare immediately. > > That is exactly what I did > > Does this happen when you hold down ctrl + middle mouse button and move mouse up and down in shader editor? > > To be sure we compare same scenario as you report, please specify what software you used to record video at what settings, and upload example .blend file with ideally visibly bad performance. 1. No, it does not happen with Ctrl+Middle Mouse smooth zoom, as I stated in the task description. 2. It was recorded using OBS studio, set up to record at 240FPS: ![image.png](https://archive.blender.org/developer/F8661089/image.png) 3. There is no point providing the blend file. It happens even in a new scene with completely empty shader editor. The amount of nodes has no impact on the performance hit. It's constant regardless of if there is 0 or 100 nodes. 4. I still think you are able to reproduce it, just not sensitive enough to the lag to actually notice it, but I do. That was actually the reason I had to record at 240FPS and then slow down the video to 25%. Because the lag is NOT visible, but it can be **felt**. What's actually needed here is for someone to profile the execution time of the function responsible for zooming in shader editor using mouse wheel in both 2.82 and 2.83, and then compare the resulting execution times. Then I am pretty sure 2.83 will be less than half of 2.82.

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

No difference there in my case unfortunately.

0586-0770.mp4

Does this happen if you collapse all other editors?

No difference there in my case unfortunately. [0586-0770.mp4](https://archive.blender.org/developer/F8672894/0586-0770.mp4) Does this happen if you collapse all other editors?
Author
Contributor

In #78495#974281, @iss wrote:
No difference there in my case unfortunately.

0586-0770.mp4

Does this happen if you collapse all other editors?

Actually I can see the difference even here! I assume 2.83 is on the right, as that one is visibly more choppy. You are just not zooming in and out fast enough. It needs to be really rapid to spot the lag. Meaning the the mouse wheel should make at least 10 "increment clicks" per second for it to be really visible (Of course assuming you are recording at high framerate and encoding the video slowed down so you can really see it).

But even on this video, you can see that the left one, 2.82 does about 2x more redraws than 2.83.

EDIT: Here is a realtime video of roughly how fast I was zooming in and out in that video I then slowed down to 25%:
2020-07-07 08-48-59.mp4
I can feel the lag even in real time, but when it comes to actual visibility, without holding mouse in your hand (so you can actually show it to others), then the video needs to be slowed down. But you can feel it in real time if you zoom in and out rapidly enough. It feels kinda like "mouse smoothing" that used to be an option in really old FPS shooter games.

> In #78495#974281, @iss wrote: > No difference there in my case unfortunately. > > [0586-0770.mp4](https://archive.blender.org/developer/F8672894/0586-0770.mp4) > > Does this happen if you collapse all other editors? Actually I can see the difference even here! I assume 2.83 is on the right, as that one is visibly more choppy. You are just not zooming in and out fast enough. It needs to be really rapid to spot the lag. Meaning the the mouse wheel should make at least 10 "increment clicks" per second for it to be really visible (Of course assuming you are recording at high framerate and encoding the video slowed down so you can really see it). But even on this video, you can see that the left one, 2.82 does about 2x more redraws than 2.83. EDIT: Here is a realtime video of roughly how fast I was zooming in and out in that video I then slowed down to 25%: [2020-07-07 08-48-59.mp4](https://archive.blender.org/developer/F8674534/2020-07-07_08-48-59.mp4) I can feel the lag even in real time, but when it comes to actual visibility, without holding mouse in your hand (so you can actually show it to others), then the video needs to be slowed down. But you can feel it in real time if you zoom in and out rapidly enough. It feels kinda like "mouse smoothing" that used to be an option in really old FPS shooter games.

I slowed down my footage to 24fps instead 60 so it is slower.

Even if I tested this with precisely timed mouse events and discovered 2ms slowdown for zoom, I wouldn't assumed this is a bug. Before this could be even investigated we first need developer that can reproduce regression at least similar to what you report.

I slowed down my footage to 24fps instead 60 so it is slower. Even if I tested this with precisely timed mouse events and discovered 2ms slowdown for zoom, I wouldn't assumed this is a bug. Before this could be even investigated we first need developer that can reproduce regression at least similar to what you report.
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Developer To Reproduce' to: 'Needs User Info'

Changed status from 'Needs Developer To Reproduce' to: 'Needs User Info'
Member

Any news? Does this issue remain in 3.3 bets?: https://builder.blender.org/download/daily

Any news? Does this issue remain in 3.3 bets?: https://builder.blender.org/download/daily
Member

Changed status from 'Needs User Info' to: 'Archived'

Changed status from 'Needs User Info' to: 'Archived'
Member

No activity for more than a week. As per the tracker policy we assume the issue is gone and can be closed.

Thanks again for the report. If the problem persists please open a new report with the required information.

No activity for more than a week. As per the tracker policy we assume the issue is gone and can be closed. Thanks again for the report. If the problem persists please open a new report with the required information.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#78495
No description provided.