Missing DNA Defaults ("Reset to Default Value" sets to 0) #80164

Open
opened 2020-08-27 18:11:53 +02:00 by Julian Eisel · 30 comments
Member

Since f5e0dfe59c, we have a simple & practical way of setting up defaults for DNA data. These defaults are used for the "Reset to Default Value" operator, available in the context menu for buttons.
Here's a helper script to extract the defaults: https://stackoverflow.com/a/55368203/432509

There are still a number of properties that don't have a default assigned. These can be reported here.

Note that these missing defaults typically appear in "groups" because the entire data-structure misses the default value definition. In that case there's no need to list each individual value, just mention where they are (e.g. Armature object, relation settings).

Since f5e0dfe59c, we have a simple & practical way of setting up defaults for DNA data. These defaults are used for the "Reset to Default Value" operator, available in the context menu for buttons. Here's a helper script to extract the defaults: https://stackoverflow.com/a/55368203/432509 There are still a number of properties that don't have a default assigned. These can be reported here. Note that these missing defaults typically appear in "groups" because the entire data-structure misses the default value definition. In that case there's no need to list each individual value, just mention where they are (e.g. Armature object, relation settings).
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel

#99109 was marked as duplicate of this issue

#99109 was marked as duplicate of this issue

#93656 was marked as duplicate of this issue

#93656 was marked as duplicate of this issue
Contributor

Added subscriber: @Gilberto.R

Added subscriber: @Gilberto.R
Contributor

In the render properties tab, i think that Simplify is missing Default values for render and grease pencil dropdowns. Also Cycles tile sizes differ from startup file value after resetting.
In Output Properties tab it defaults output color to BW instead of RGB.
In Scene Properties tab it's missing default value for Units.
In Object Properties tab it's missing for Relations and Motion Paths.
It's also missing default values for constraints.

In the render properties tab, i think that Simplify is missing Default values for render and grease pencil dropdowns. Also Cycles tile sizes differ from startup file value after resetting. In Output Properties tab it defaults output color to BW instead of RGB. In Scene Properties tab it's missing default value for Units. In Object Properties tab it's missing for Relations and Motion Paths. It's also missing default values for constraints.

Added subscriber: @NicolaSap

Added subscriber: @NicolaSap

All the sockets (including RGBA sockets, dropdowns, etc) default to 0.000 (or first element in the list¹) in all the nodes.

¹Only excepton I've found is that, in ColorRamp, interpolation correctly defaults to "Linear"

Peek 2020-09-01 09-39.gif

Edit: Maybe the issue with nodes is based on a different root cause, so probably this is not the right Task? See also: #76704

All the sockets (including RGBA sockets, dropdowns, etc) default to 0.000 (or first element in the list¹) in all the nodes. ¹Only excepton I've found is that, in ColorRamp, interpolation correctly defaults to "Linear" ![Peek 2020-09-01 09-39.gif](https://archive.blender.org/developer/F8829161/Peek_2020-09-01_09-39.gif) Edit: Maybe the issue with nodes is based on a different root cause, so probably this is not the right Task? See also: #76704

Added subscriber: @blenderrocket

Added subscriber: @blenderrocket
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

After some recent commits this should be working in more places:

There is still much more work to do. Maybe these commits could serve as helpful examples for anyone who wants to help out by making similar changes.

After some recent commits this should be working in more places: - d3b59d1358 - d6f409b862 - d3ba60b132 - e900f6ed14 - c3238bd500 - 8398050695 There is still much more work to do. Maybe these commits could serve as helpful examples for anyone who wants to help out by making similar changes.

Added subscriber: @ketanjainn

Added subscriber: @ketanjainn
Ketan Jain self-assigned this 2020-10-18 06:29:00 +02:00

This comment was removed by @ketanjainn

*This comment was removed by @ketanjainn*
Ketan Jain removed their assignment 2020-10-18 08:07:48 +02:00

Added subscriber: @sidd017

Added subscriber: @sidd017

Hi, Default values for radius and strength in brush properties of SculptDraw brush and detail size under dyntopo also seem to have incorrect default values. I'm new to Blender development and since this is a good first issue, I tried looking into this.

  • Radius : default on startup is 50px and reset to default value sets it to 0

  • Strength : default on startup is 0.5 and reset to default value sets it to 1

  • Dyntopo -> Detail Size : default on startup is 12.00px and reset to default value sets it to 0.00px (did annoy me a lot when I first tried sculpting)

From what I understand, default values are now defined under DNA_brush_defaults.h, but when I tried changing them it had no effect. The properties still had the old default values. I suspect some other implementation is overriding the DNA defaults, probably related to #47618 . Changing defaults like particle settings in DNA_particle_defaults.h, also seems to have no effect.
Can someone help me understand why changing default values in DNA_brush_defaults.h has no effect?

Hi, Default values for radius and strength in brush properties of SculptDraw brush and detail size under dyntopo also seem to have incorrect default values. **I'm new to Blender development** and since this is a **good first issue**, I tried looking into this. - Radius : default on startup is 50px and reset to default value sets it to 0 - Strength : default on startup is 0.5 and reset to default value sets it to 1 - Dyntopo -> Detail Size : default on startup is 12.00px and reset to default value sets it to 0.00px (did annoy me a lot when I first tried sculpting) From what I understand, default values are now defined under DNA_brush_defaults.h, but when I tried changing them it had no effect. The properties still had the old default values. I suspect some other implementation is overriding the DNA defaults, probably related to #47618 . Changing defaults like particle settings in DNA_particle_defaults.h, also seems to have no effect. Can someone help me understand why changing default values in DNA_brush_defaults.h has no effect?

Added subscriber: @gaurivn

Added subscriber: @gaurivn

I would like to work on this issue.

I would like to work on this issue.

Added subscriber: @George540

Added subscriber: @George540

This comment was removed by @George540

*This comment was removed by @George540*

Hi! I'm new to the Blender Development group and I decided to tackle this issue.

Currently changing the rna defaults for Simplify (Render Settings inCycles). The default for Texture limit dropdowns for Render and Viewport panels are at No Limit. Is that the correct default? If that's not the case, I think setting it to 2048 is ideal, since image textures already have a default size of 2048x2048 px

Hi! I'm new to the Blender Development group and I decided to tackle this issue. Currently changing the **rna defaults for Simplify** (Render Settings in**Cycles**). The default for Texture limit dropdowns for Render and Viewport panels are at *No Limit*. Is that the correct default? If that's not the case, I think setting it to 2048 is ideal, since image textures already have a default size of 2048x2048 px
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Not sure if VSE can use this system? If so, then Sequence needs to be covered, see #90406 (VSE: The blend and opacity settings that strips are created with does not match the default values they revert back to)

Not sure if VSE can use this system? If so, then `Sequence` needs to be covered, see #90406 (VSE: The blend and opacity settings that strips are created with does not match the default values they revert back to)
Member

Added subscriber: @OrestisKonstantinidis

Added subscriber: @OrestisKonstantinidis

Added subscriber: @SHREY-AGGARWAL

Added subscriber: @SHREY-AGGARWAL

Added subscriber: @SteffenD

Added subscriber: @SteffenD

Added subscriber: @Diogo_Valadares

Added subscriber: @Diogo_Valadares
Member

Added subscriber: @OmarEmaraDev

Added subscriber: @OmarEmaraDev
Member

UnitSettings in DNA_scene needs default values. See #99109.

`UnitSettings` in `DNA_scene` needs default values. See #99109.
Member

Added subscriber: @pixeltrain3d

Added subscriber: @pixeltrain3d

Added subscriber: @ralphw

Added subscriber: @ralphw
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:24:09 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
16 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#80164
No description provided.