Convert to Curve from Mesh crashes Blender #80596

New Issue

Simon Thommes · 2020-09-08T15:31:42+02:00

Simon Thommes commented

2020-09-08 15:31:42 +02:00

System Information
Operating system: Linux-5.4.0-7634-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-08 11:23, hash: ab6f59ff3b
Worked: v2.83.5

Short description of error
The convert Curve from Mesh operator does not work and in some cases crashes Blender immediately.

Exact steps for others to reproduce the error
Add a plane -> Convert to Curve from Mesh -> Crash

(Note: on the default cube it does not crash, but also does not do any conversion)

**System Information** Operating system: Linux-5.4.0-7634-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-08 11:23, hash: `ab6f59ff3b` Worked: v2.83.5 **Short description of error** The convert Curve from Mesh operator does not work and in some cases crashes Blender immediately. **Exact steps for others to reproduce the error** Add a plane -> Convert to Curve from Mesh -> Crash (Note: on the default cube it does not crash, but also does not do any conversion)

Simon Thommes commented

2020-09-08 15:31:42 +02:00

Added subscriber: @SimonThommes

blender-admin commented

2020-09-08 15:31:42 +02:00

#80618 was marked as duplicate of this issue

blender-admin commented

2020-09-08 15:31:42 +02:00

#80607 was marked as duplicate of this issue

Robert Guetzkow commented

2020-09-08 16:48:22 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-09-08 16:48:22 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-09-08 16:48:22 +02:00

I can confirm this issue. object_convert_exec tries to remove the object from the rigid bodies by calling ED_rigidbody_object_remove. However, since it isn't a rigid body and there's also no other rigid body in the scene the RigidBodyWorld is NULL when calling BKE_ptcache_id_from_rigidbody and it tries to dereference it.

If you add rigid body physics to the plane or any other object in the scene it won't crash, since a rigid body world exists.

BKE_ptcache_id_from_rigidbody(PTCacheID * pid, Object * ob, RigidBodyWorld * rbw) Line 1854	C
BKE_rigidbody_remove_object(Main * bmain, Scene * scene, Object * ob, const bool free_us) Line 1567	C
ED_rigidbody_object_remove(Main * bmain, Scene * scene, Object * ob) Line 106	C
object_convert_exec(bContext * C, wmOperator * op) Line 2577	C
WM_menu_invoke_ex(bContext * C, wmOperator * op, int opcontext) Line 972	C
WM_menu_invoke(bContext * C, wmOperator * op, const wmEvent * UNUSED_event) Line 993	C
wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1301	C
wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const short context, const bool poll_only, wmEvent * event) Line 1514	C
WM_operator_name_call_ptr(bContext * C, wmOperatorType * ot, short context, PointerRNA * properties) Line 1563	C
ui_apply_but_funcs_after(bContext * C) Line 928	C
ui_handler_region_menu(bContext * C, const wmEvent * event, void * UNUSED_userdata) Line 10739	C
wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Line 639	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2755	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2866	C
wm_event_do_handlers(bContext * C) Line 3290	C
WM_main(bContext * C) Line 485	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 531	C

I can confirm this issue. `object_convert_exec` tries to remove the object from the rigid bodies by calling `ED_rigidbody_object_remove`. However, since it isn't a rigid body and there's also no other rigid body in the scene the `RigidBodyWorld` is `NULL` when calling `BKE_ptcache_id_from_rigidbody` and it tries to dereference it. If you add rigid body physics to the plane or any other object in the scene it won't crash, since a rigid body world exists. ``` BKE_ptcache_id_from_rigidbody(PTCacheID * pid, Object * ob, RigidBodyWorld * rbw) Line 1854 C BKE_rigidbody_remove_object(Main * bmain, Scene * scene, Object * ob, const bool free_us) Line 1567 C ED_rigidbody_object_remove(Main * bmain, Scene * scene, Object * ob) Line 106 C object_convert_exec(bContext * C, wmOperator * op) Line 2577 C WM_menu_invoke_ex(bContext * C, wmOperator * op, int opcontext) Line 972 C WM_menu_invoke(bContext * C, wmOperator * op, const wmEvent * UNUSED_event) Line 993 C wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1301 C wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const short context, const bool poll_only, wmEvent * event) Line 1514 C WM_operator_name_call_ptr(bContext * C, wmOperatorType * ot, short context, PointerRNA * properties) Line 1563 C ui_apply_but_funcs_after(bContext * C) Line 928 C ui_handler_region_menu(bContext * C, const wmEvent * event, void * UNUSED_userdata) Line 10739 C wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Line 639 C wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2755 C wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2866 C wm_event_do_handlers(bContext * C) Line 3290 C WM_main(bContext * C) Line 485 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 531 C ```

Robert Guetzkow commented

2020-09-08 21:23:55 +02:00

Added subscriber: @Josephbburg

Joseph Brandenburg commented

2020-09-08 21:26:19 +02:00

thank you for closing mine. I am so embarrassed that I forgot to search 😭

Robert Guetzkow commented

2020-09-08 21:28:50 +02:00

@Josephbburg Don't worry about it.

Robert Guetzkow commented

2020-09-08 21:45:17 +02:00

Added subscriber: @ZedDB

Robert Guetzkow commented

2020-09-08 21:45:17 +02:00

@ZedDB This issue was introduced by f20f82ce3e with the changes to BKE_rigidbody_remove_object.

@ZedDB This issue was introduced by f20f82ce3e with the changes to `BKE_rigidbody_remove_object`.

blender-admin commented

2020-09-09 11:46:40 +02:00

This issue was referenced by d51c8f78ff

This issue was referenced by d51c8f78ff8a210675dae44048156c23e3793508

Sebastian Parborg commented

2020-09-09 11:49:32 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sebastian Parborg closed this issue

2020-09-09 11:49:32 +02:00

Sebastian Parborg self-assigned this 2020-09-09 11:49:32 +02:00

Sebastian Parborg commented

2020-09-09 11:51:58 +02:00

Thanks for bisecting and providing the backtrace!

The issue was two fold:

First I should check if rbw is null before trying to get a pointcache from it.
This would only trigger when using the convert function as it does not have a sanity check. (Is this object actually a rigid body object?)

So I fixed both.

Thanks for bisecting and providing the backtrace! The issue was two fold: 1. First I should check if rbw is null before trying to get a pointcache from it. 2. This would only trigger when using the convert function as it does not have a sanity check. (Is this object actually a rigid body object?) So I fixed both.

Robert Guetzkow commented

2020-09-09 12:11:28 +02:00

Added subscriber: @3di

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Convert to Curve from Mesh crashes Blender #80596