Images drawn with the Python gpu module no longer draw on top in the Image Editor #81002

New Issue

Inês Almeida · 2020-09-20T19:16:48+02:00

Inês Almeida commented

2020-09-20 19:16:48 +02:00

System Information
Operating system: Linux-5.4.43-x86_64-Intel-R-_Core-TM-i7-7500U_CPU@_2.70GHz-with-slackware-14.2 64 Bits
Graphics card: Mesa Intel(R) HD Graphics 620 (KBL GT2) Intel 4.6 (Core Profile) Mesa 20.1.0

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, hash: f470a02afa, commit date: 2020-09-20 05:59
Worked: version: 2.91.0 Alpha, branch: master, hash: 66078594d1

Short description of error
When drawing images with the python gpu module, they will no longer draw on top of the region's contents or of other python rendering.
This problem happens in the Image Editor, but not the Sequence Editor.

Before:
(2 square images and a circle are drawn with Python, 'POST_PIXEL' in the Image Editor, which shows a rectangular image)

After:
(the circle, drawn first, shows on top. The Image Editor's image also shows on top)

Exact steps for others to reproduce the error
See the attached .blend file.
python_gl_draw_image.blend

**System Information** Operating system: Linux-5.4.43-x86_64-Intel-R-_Core-TM-_i7-7500U_CPU_@_2.70GHz-with-slackware-14.2 64 Bits Graphics card: Mesa Intel(R) HD Graphics 620 (KBL GT2) Intel 4.6 (Core Profile) Mesa 20.1.0 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, hash: `f470a02afa`, commit date: 2020-09-20 05:59 Worked: version: 2.91.0 Alpha, branch: master, hash: `66078594d1` **Short description of error** When drawing images with the python gpu module, they will no longer draw on top of the region's contents or of other python rendering. This problem happens in the Image Editor, but not the Sequence Editor. Before: (2 square images and a circle are drawn with Python, 'POST_PIXEL' in the Image Editor, which shows a rectangular image) ![happy_froggo_good.png](https://archive.blender.org/developer/F8903609/happy_froggo_good.png) After: (the circle, drawn first, shows on top. The Image Editor's image also shows on top) ![happy_froggo_bad.png](https://archive.blender.org/developer/F8903608/happy_froggo_bad.png) **Exact steps for others to reproduce the error** See the attached .blend file. [python_gl_draw_image.blend](https://archive.blender.org/developer/F8903627/python_gl_draw_image.blend)

Inês Almeida commented

2020-09-20 19:16:48 +02:00

Added subscriber: @brita

Jeroen Bakker commented

2020-09-21 08:12:04 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2020-09-21 08:12:04 +02:00

Could this be related to the depth tricks that the image editor currently uses? https://wiki.blender.org/wiki/Source/EEVEE_%26_Viewport/Draw_Engines/Image_Engine#Depth_Buffer
What happens when you draw with DEPTH_ALWAYS on? Or with write depth.

Currently when drawing via python it draws directly to the overlay buffer. https://wiki.blender.org/wiki/Source/EEVEE_%26_Viewport/GPU_Module/GPUViewport when transferring to display it might not have the correct data inside the buffers.

I will check later today with renderdoc to see what is happening and what needs to be corrected/documented.
Thanks!

Could this be related to the depth tricks that the image editor currently uses? https://wiki.blender.org/wiki/Source/EEVEE_%26_Viewport/Draw_Engines/Image_Engine#Depth_Buffer What happens when you draw with DEPTH_ALWAYS on? Or with write depth. Currently when drawing via python it draws directly to the overlay buffer. https://wiki.blender.org/wiki/Source/EEVEE_%26_Viewport/GPU_Module/GPUViewport when transferring to display it might not have the correct data inside the buffers. I will check later today with renderdoc to see what is happening and what needs to be corrected/documented. Thanks!

Philipp Oeser commented

2020-09-21 15:36:33 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

blender-admin commented

2020-09-22 11:17:17 +02:00

This issue was referenced by 085329f114

This issue was referenced by 085329f114beb904ed3ef0c8ec6894ee26916704

Jeroen Bakker commented

2020-09-22 11:17:32 +02:00

The circle is rendered with gl_depth 0, write depth is on and depth function is less equal.
The textures are rendered with gl_depth 1, write depth is on and depth function is less equal.
The image of the image editor is drawn using gl_depth of 0.75 as part of the new draw pipeline.

Looking at https://developer.blender.org/diffusion/B/browse/master/source/blender/gpu/shaders/gpu_shader_2D_image_vert.glsl the gl_depth is set to 1 for images so they always render in the background.
This was introduced by https://developer.blender.org/rB648924333234a1fd0fee91851bb7ad8bc8639f3a what seems to be out dated as we have done several overhauls in this area. (workbench refactor, overlay engine refactor, color management pipeline).

The circle is rendered with gl_depth 0, write depth is on and depth function is `less equal`. The textures are rendered with gl_depth 1, write depth is on and depth function is `less equal`. The image of the image editor is drawn using gl_depth of 0.75 as part of the new draw pipeline. Looking at https://developer.blender.org/diffusion/B/browse/master/source/blender/gpu/shaders/gpu_shader_2D_image_vert.glsl the gl_depth is set to 1 for images so they always render in the background. This was introduced by https://developer.blender.org/rB648924333234a1fd0fee91851bb7ad8bc8639f3a what seems to be out dated as we have done several overhauls in this area. (workbench refactor, overlay engine refactor, color management pipeline).

Jeroen Bakker commented

2020-09-22 11:21:15 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-09-22 11:21:15 +02:00

Jeroen Bakker self-assigned this 2020-09-22 11:21:15 +02:00

Jeroen Bakker commented

2020-09-29 09:53:24 +02:00

Changed status from 'Resolved' to: 'Confirmed'

Jeroen Bakker reopened this issue

2020-09-29 09:53:24 +02:00

Jeroen Bakker commented

2020-09-29 09:53:24 +02:00

Reopening as this fix will be reverted. #81212 (Some Viewport Overlay is gone if you move the view in Cycles render view)

blender-admin commented

2020-09-29 09:53:55 +02:00

This issue was referenced by 32d4a67017

This issue was referenced by 32d4a67017ecf4af75a9bfde885526550a6534ba

Jeroen Bakker commented

2020-09-29 09:54:49 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-09-29 09:54:49 +02:00

Jeroen Bakker commented

2020-09-29 09:55:24 +02:00

Changed status from 'Resolved' to: 'Confirmed'

Jeroen Bakker reopened this issue

2020-09-29 09:55:24 +02:00

Jeroen Bakker removed their assignment 2020-10-20 13:55:34 +02:00

Pablo commented

2020-12-07 06:22:02 +01:00

Added subscriber: @OtherRealms

Pablo commented

2020-12-08 05:33:39 +01:00

A heads up, drawing images in POST_VIEW doesn't work at all in the 2.92 Image Editor, could this be related? I've tried various z positons without success in this case though it works fine in 2.91.

blender-admin commented

2022-09-05 16:48:06 +02:00

This issue was referenced by 89abc14d6c

This issue was referenced by 89abc14d6ce92dd5fd8cd32885d379d46f017f81

Germano Cavalcante commented

2022-09-05 17:36:19 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Germano Cavalcante closed this issue

2022-09-05 17:36:19 +02:00

Germano Cavalcante self-assigned this 2022-09-05 17:36:19 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Images drawn with the Python gpu module no longer draw on top in the Image Editor #81002