Projects
Docs
Blog
Forum
Builds

BLENDER.ORG
- Download
  
  Get the latest Blender, older versions, or experimental builds.
- What's New
  
  Stay up-to-date with the new features in the latest Blender releases.
LEARNING & RESOURCES
- Blender Studio
  
  Access production assets and knowledge from the open movies.
- Manual
  
  Documentation on the usage and features in Blender.
DEVELOPMENT
- Developers Blog
  
  Latest development updates, by Blender developers.
- Documentation
  
  Guidelines, release notes and development docs.
- Benchmark
  
  A platform to collect and share results of the Blender Benchmark.
- Blender Conference
  
  The yearly event that brings the community together.
DONATE
- Development Fund
  
  Support core development with a monthly contribution.
- One-time Donations
  
  Perform a single donation with more payment options available.

Explore

Modules

Animation & Rigging Asset System Core Grease Pencil Modeling Nodes & Physics Pipeline, Assets & I/O Platforms, Builds, Tests & Devices

Python & Add-ons

Python API & Text Editor Officially Maintained Add-ons Community Maintained Add-ons

Rendering

EEVEE & Viewport Render & Cycles

Sculpt, Paint & Texture Triaging User Interface VFX & Video

Report a Bug Help

blender

/

blender

128

396

You've already forked blender

Code Issues 6.2k Pull Requests 751 Projects 19 Wiki Activity

Implementation: Modal Key Manipulation Operators #81785

New Issue

Closed

opened 2020-10-16 22:54:41 +02:00 by Christoph Lendenfeld · 26 comments

Christoph Lendenfeld commented

2020-10-16 22:54:41 +02:00

Member

Copy Link

Status: Implement generic slider

Description
Big picture:
Blender already has the pose sliding tools, that allow you to interactively create breakdowns in Pose mode.
It uses a modal operator and the mouse cursor to interactively set the pose. Using the same interaction, we could add similar functionality to the graph editor to manipulate multiple keyframes.

Use cases:

During animation when using the graph editor and trying to change multiple keyframes.

Design:

#81836

Engineer plan:
In order to implement the new operators efficiently there is some cleanup work to do

Create a new file for all the keyframe operators to live in and move GRAPH_OT_decimate in there
Extract functions from GRAPH_OT_decimate into generic functions that can be shared between all new operators
Implement a generic slider that calculates the percentage based on cursor position
Then implement all new operators, with each new operator being a new patch.

Issues

Bezier keyframes with free or aligned tangent handles cause problems where the tangent handles don't follow the keyframe. Might be related to #81813
Use LISTBASE_FOREACH when iterating through lists. There are a lot of places where this could be used. Refactor at the end.
Decimate/Sample can be combined on one slider "Key Density"

Work plan

Cleanup

The sliding functionality should only exist once in code. At the moment it does exist in the pose sliding tools and also for the keyframe decimate operator. Maybe also in different areas that I haven’t found yet.
All the keyframe operators will work on selection and most of them on keyframe segments (a segment being a continuous selection of keyframes) Some operators already calculate segments, but I think this would be better in a function as well.
Make it easy to implement new operators, that will share a lot of functionality

Phase 1 (Moving code around. Commits are independent)
D9312 Break up graph_edit.c. This file is scraping the 4000 lines and if I recall correctly that is the limit for files defined in the docs.
D9313 Create editors/util/ed_draw.c as the place in which the generic slider will be located
Phase 2 (Implement generic slider)
D9314 Implement generic slider as it currently is in Blender
D11878 Change color of slider to make proper use of theme
D11883 Remove auto hiding when using the pose sliding tools
D9361 Change GRAPH_OT_decimate to use the generic slider
D12024 Fix hiding bones instantly when hitting 'H'
Phase 3 (Refactoring Code. Dependent on Phase 1 and dependent on patches coming before)
D12486 D12487 D12489 D12490 Extract helper functions from GRAPH_OT_decimate so they can be reused for future ops
D9326 Implement generic ´invoke´, ´modal´ and ´exec´ for GRAPH_OT_decimate
D9360 Function to calculate keyframe selection segments in keyframes_general.c
D13476 Renames
D13477 fix one line

Implement keyframe manipulation operators

D13531 create function to get segment list
D9374 Blend to neighbour (blend to left or right keyframe from currrent keyframe value)
D9375 Tween (similar to Pose Slide Breakdowner but for keyframes)
D9376 Blend to default
D9477 Smooth (There is a smooth operator already, but it would be better if it is interactive)
D9478 Sample keyframes (Decimate already exists, but the other way is useful as well)
D9479 Ease (Align keyframe segments in a gamma curve that either favors the left or the right key)

Improvements

TODO Change Generic slider to make use of keymap
TODO Cleanup code to use const as much as possible (graph_slider_ops: remove_ratio)
TODO Move code that throws a warning to invoke of the decimate OP
TODO Refactor ..._draw_status_header to use common code

UI and UX
Once all operators are implemented it is time for user testing. Apart from general feedback I'd like to test multiple ways of calling the tools:

Floating panel like the quick favorites panel. This would scale quite well, but it is not as fast or intuitive as pie menus. An option to improve that would be to add hotkeys to the entries.
Embedded in a pie menu. This would make a lot of them accessible with only one hotkey. However I think the pie menu would be quite crowded and if more operators get added where would we put them?
I will definitely put them in a menu in the graph editor, but I think this is just for discoverability. They are not easy to access there. However the hotkeys will be listed there as well for the user to discover.
An idea by @LucianoMunoz is that there would be a dropdown to choose the active slider, which can then be called with just a hotkey

D9512 add operators to menu and pie menu

**Status:** `Implement generic slider` --- **Description** **Big picture:** Blender already has the pose sliding tools, that allow you to interactively create breakdowns in Pose mode. It uses a modal operator and the mouse cursor to interactively set the pose. Using the same interaction, we could add similar functionality to the graph editor to manipulate multiple keyframes. **Use cases**: * During animation when using the graph editor and trying to change multiple keyframes. **Design:** * #81836 **Engineer plan:** In order to implement the new operators efficiently there is some cleanup work to do * Create a new file for all the keyframe operators to live in and move `GRAPH_OT_decimate` in there * Extract functions from `GRAPH_OT_decimate` into generic functions that can be shared between all new operators * Implement a generic slider that calculates the percentage based on cursor position Then implement all new operators, with each new operator being a new patch. **Issues** * Bezier keyframes with *free* or *aligned* tangent handles cause problems where the tangent handles don't follow the keyframe. Might be related to #81813 * Use LISTBASE_FOREACH when iterating through lists. There are a lot of places where this could be used. Refactor at the end. * Decimate/Sample can be combined on one slider "Key Density" **Work plan** **Cleanup** * The sliding functionality should only exist once in code. At the moment it does exist in the pose sliding tools and also for the keyframe decimate operator. Maybe also in different areas that I haven’t found yet. * All the keyframe operators will work on selection and most of them on keyframe segments (a segment being a continuous selection of keyframes) Some operators already calculate segments, but I think this would be better in a function as well. * Make it easy to implement new operators, that will share a lot of functionality - [x] Phase 1 (Moving code around. Commits are independent) - [x] [D9312](https://archive.blender.org/developer/D9312) Break up `graph_edit.c`. This file is scraping the 4000 lines and if I recall correctly that is the limit for files defined in the docs. - [x] [D9313](https://archive.blender.org/developer/D9313) Create `editors/util/ed_draw.c` as the place in which the generic slider will be located - [x] Phase 2 (Implement generic slider) - [x] [D9314](https://archive.blender.org/developer/D9314) Implement generic slider as it currently is in Blender - [x] [D11878](https://archive.blender.org/developer/D11878) Change color of slider to make proper use of theme - [x] [D11883](https://archive.blender.org/developer/D11883) Remove auto hiding when using the pose sliding tools - [x] [D9361](https://archive.blender.org/developer/D9361) Change `GRAPH_OT_decimate` to use the generic slider - [x] [D12024](https://archive.blender.org/developer/D12024) Fix hiding bones instantly when hitting 'H' - [x] Phase 3 (Refactoring Code. Dependent on Phase 1 and dependent on patches coming before) - [x] [D12486](https://archive.blender.org/developer/D12486) [D12487](https://archive.blender.org/developer/D12487) [D12489](https://archive.blender.org/developer/D12489) [D12490](https://archive.blender.org/developer/D12490) Extract helper functions from `GRAPH_OT_decimate` so they can be reused for future ops - [x] [D9326](https://archive.blender.org/developer/D9326) Implement generic ´invoke´, ´modal´ and ´exec´ for `GRAPH_OT_decimate` - [x] [D9360](https://archive.blender.org/developer/D9360) Function to calculate keyframe selection segments in `keyframes_general.c` - [x] [D13476](https://archive.blender.org/developer/D13476) Renames - [x] [D13477](https://archive.blender.org/developer/D13477) fix one line **Implement keyframe manipulation operators** - [x] [D13531](https://archive.blender.org/developer/D13531) create function to get segment list - [x] [D9374](https://archive.blender.org/developer/D9374) Blend to neighbour (blend to left or right keyframe from currrent keyframe value) - [x] [D9375](https://archive.blender.org/developer/D9375) Tween (similar to Pose Slide Breakdowner but for keyframes) - [x] [D9376](https://archive.blender.org/developer/D9376) Blend to default - [ ] [D9477](https://archive.blender.org/developer/D9477) Smooth (There is a smooth operator already, but it would be better if it is interactive) - [ ] [D9478](https://archive.blender.org/developer/D9478) Sample keyframes (Decimate already exists, but the other way is useful as well) - [x] [D9479](https://archive.blender.org/developer/D9479) Ease (Align keyframe segments in a gamma curve that either favors the left or the right key) **Improvements** - [ ] TODO Change Generic slider to make use of keymap - [ ] TODO Cleanup code to use const as much as possible (graph_slider_ops: remove_ratio) - [ ] TODO Move code that throws a warning to invoke of the decimate OP - [ ] TODO Refactor ..._draw_status_header to use common code **UI and UX** Once all operators are implemented it is time for user testing. Apart from general feedback I'd like to test multiple ways of calling the tools: * Floating panel like the quick favorites panel. This would scale quite well, but it is not as fast or intuitive as pie menus. An option to improve that would be to add hotkeys to the entries. * Embedded in a pie menu. This would make a lot of them accessible with only one hotkey. However I think the pie menu would be quite crowded and if more operators get added where would we put them? * I will definitely put them in a menu in the graph editor, but I think this is just for discoverability. They are not easy to access there. However the hotkeys will be listed there as well for the user to discover. * An idea by @LucianoMunoz is that there would be a dropdown to choose the active slider, which can then be called with just a hotkey - [x] [D9512](https://archive.blender.org/developer/D9512) add operators to menu and pie menu

Christoph Lendenfeld self-assigned this 2020-10-16 22:54:41 +02:00

Christoph Lendenfeld commented

2020-10-16 22:54:41 +02:00

Author

Member

Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Christoph Lendenfeld commented

2020-10-16 22:54:41 +02:00

Author

Member

Copy Link

Added subscriber: @ChrisLend

Added subscriber: @ChrisLend

RedMser commented

2020-10-17 10:19:19 +02:00

Contributor

Copy Link

Added subscriber: @RedMser

Added subscriber: @RedMser

Christoph Lendenfeld changed title from ~~New Graph Editor Key Manipulation Operators~~ to Implementation: Modal Key Manipulation Operators

2020-10-20 14:42:42 +02:00

Christoph Lendenfeld commented

2020-11-09 13:52:39 +01:00

Author

Member

Copy Link

Added subscriber: @LucianoMunoz

Added subscriber: @LucianoMunoz

blender-admin commented

2020-11-23 15:11:51 +01:00

Copy Link

This issue was referenced by 1f09dcc121

This issue was referenced by 1f09dcc121ab31fe08c76947820ed59ec8f76788

Wayde Moss commented

2020-12-11 21:33:30 +01:00

Member

Copy Link

Added subscriber: @wbmoss_dev

Added subscriber: @wbmoss_dev

blender-admin commented

2021-03-01 16:20:55 +01:00

Copy Link

This issue was referenced by fdb2c24c09

This issue was referenced by fdb2c24c097d9a4613493659533863efc3c6f809

blender-admin commented

2021-07-23 00:44:53 +02:00

Copy Link

This issue was referenced by fafd21b14c

This issue was referenced by fafd21b14c2337c2a5ca580d444d05cb1bb92566

blender-admin commented

2021-07-26 22:42:04 +02:00

Copy Link

This issue was referenced by 6a903d9088

This issue was referenced by 6a903d90887848803decd5242e25df5d24f85970

blender-admin commented

2021-09-07 21:10:53 +02:00

Copy Link

This issue was referenced by adbafe3b43

This issue was referenced by adbafe3b43d6131c74d96128b23ed24ae904d487

blender-admin commented

2021-10-31 12:08:57 +01:00

Copy Link

This issue was referenced by a06abbac92

This issue was referenced by a06abbac92f2029269375ced69a2c4f75ecce5e1

blender-admin commented

2021-10-31 12:19:40 +01:00

Copy Link

This issue was referenced by 1b6daa871d

This issue was referenced by 1b6daa871da9acc7c17aae9965633a4da604ba63

blender-admin commented

2021-10-31 12:28:10 +01:00

Copy Link

This issue was referenced by b2e9f35c5e

This issue was referenced by b2e9f35c5eb21f63f5c20e06e910ef03965556ce

blender-admin commented

2021-11-04 22:20:26 +01:00

Copy Link

This issue was referenced by 6986b43b3d

This issue was referenced by 6986b43b3d2d633fe4bf3be96d0da474cc6ba333

blender-admin commented

2021-11-04 22:35:28 +01:00

Copy Link

This issue was referenced by 3364a5bea6

This issue was referenced by 3364a5bea6c977069210c3325111dc28051ee1cb

blender-admin commented

2021-11-23 22:38:23 +01:00

Copy Link

This issue was referenced by 6b4405d757

This issue was referenced by 6b4405d7579da65c35d8f9424440d58002aa1f9c

blender-admin commented

2021-12-03 23:24:41 +01:00

Copy Link

This issue was referenced by d5920744f4

This issue was referenced by d5920744f4429423e89a56112ede8a8ea87ccbbb

blender-admin commented

2021-12-06 23:19:00 +01:00

Copy Link

This issue was referenced by ae6f3056fc

This issue was referenced by ae6f3056fcb4d0b952b2c55abdb505d51725ca05

blender-admin commented

2021-12-06 23:27:04 +01:00

Copy Link

This issue was referenced by b1696702cd

This issue was referenced by b1696702cdb74c2b6d7c8c3f9d204f108607a8ab

blender-admin commented

2021-12-17 23:43:02 +01:00

Copy Link

This issue was referenced by 8e31e53aa0

This issue was referenced by 8e31e53aa0ee9693582ad5b72cfe5732b57c72fd

blender-admin commented

2021-12-25 13:40:53 +01:00

Copy Link

This issue was referenced by 9085b4a731

This issue was referenced by 9085b4a731fd5315eb97c00fc4bbf7c163698ebc

blender-admin commented

2021-12-25 20:58:47 +01:00

Copy Link

This issue was referenced by f7ddb1ed8a

This issue was referenced by f7ddb1ed8a2a646e3d04d5e2e46929673084149c

blender-admin commented

2022-02-16 21:55:42 +01:00

Copy Link

This issue was referenced by b626edd751

This issue was referenced by b626edd751d64b269da12ef8e774ced2836c3c9e

blender-admin commented

2022-03-18 20:07:16 +01:00

Copy Link

This issue was referenced by 37b93b5df8

This issue was referenced by 37b93b5df85c9e7acac989c86cf658bf8a0bc1e5

blender-admin commented

2023-01-05 10:11:24 +01:00

Copy Link

This issue was referenced by 76a68649c1

This issue was referenced by 76a68649c1c1f3db28b069397c71daf10f1c4ea4

Philipp Oeser removed the

Animation & Rigging

label 2023-02-09 14:36:09 +01:00

Christoph Lendenfeld commented

2023-04-14 09:44:16 +02:00

Author

Member

Copy Link

Work continues in #106639

Work continues in #106639

Christoph Lendenfeld closed this issue

2023-04-14 09:44:18 +02:00

Blender Bot added

and removed

labels 2023-04-14 09:44:19 +02:00

Sign in to join this conversation.

No Branch/Tag Specified

main

brush-assets-project

blender-v4.1-release

blender-v3.3-release

blender-v3.6-release

universal-scene-description

blender-v3.6-temp_wmoss_animrig_public

temp-sculpt-dyntopo

gpencil-next

anim/animation-id-113594

blender-v4.0-release

blender-projects-basics

bridge-curves

sculpt-blender

asset-browser-frontend-split

asset-shelf

tmp-usd-python-mtl

tmp-usd-3.6

blender-v3.5-release

blender-v2.93-release

realtime-clock

sculpt-dev

bevelv2

xr-dev

v4.1.1

v3.6.11

v3.3.18

v4.1.0

v3.3.17

v3.6.10

v3.6.9

v3.3.16

v3.6.8

v3.6.7

v3.3.14

v4.0.2

v4.0.1

v4.0.0

v3.6.5

v3.3.12

v3.6.4

v3.6.3

v3.3.11

v3.6.2

v3.3.10

v3.6.1

v3.3.9

v3.6.0

v3.3.8

v3.3.7

v2.93.18

v3.5.1

v3.3.6

v2.93.17

v3.5.0

v2.93.16

v3.3.5

v3.3.4

v2.93.15

v2.93.14

v3.3.3

v2.93.13

v2.93.12

v3.4.1

v3.3.2

v3.4.0

v3.3.1

v2.93.11

v3.3.0

v3.2.2

v2.93.10

v3.2.1

v3.2.0

v2.83.20

v2.93.9

v3.1.2

v3.1.1

v3.1.0

v2.83.19

v2.93.8

v3.0.1

v2.93.7

v3.0.0

v2.93.6

v2.93.5

v2.83.18

v2.93.4

v2.93.3

v2.83.17

v2.93.2

v2.93.1

v2.83.16

v2.93.0

v2.83.15

v2.83.14

v2.83.13

v2.92.0

v2.83.12

v2.91.2

v2.83.10

v2.91.0

v2.83.9

v2.83.8

v2.83.7

v2.90.1

v2.83.6.1

v2.83.6

v2.90.0

v2.83.5

v2.83.4

v2.83.3

v2.83.2

v2.83.1

v2.83

v2.82a

v2.82

v2.81a

v2.81

v2.80

v2.80-rc3

v2.80-rc2

v2.80-rc1

v2.79b

v2.79a

v2.79

v2.79-rc2

v2.79-rc1

v2.78c

v2.78b

v2.78a

v2.78

v2.78-rc2

v2.78-rc1

v2.77a

v2.77

v2.77-rc2

v2.77-rc1

v2.76b

v2.76a

v2.76

v2.76-rc3

v2.76-rc2

v2.76-rc1

v2.75a

v2.75

v2.75-rc2

v2.75-rc1

v2.74

v2.74-rc4

v2.74-rc3

v2.74-rc2

v2.74-rc1

v2.73a

v2.73

v2.73-rc1

v2.72b

2.72b

v2.72a

v2.72

v2.72-rc1

v2.71

v2.71-rc2

v2.71-rc1

v2.70a

v2.70

v2.70-rc2

v2.70-rc

v2.69

v2.68a

v2.68

v2.67b

v2.67a

v2.67

v2.66a

v2.66

v2.65a

v2.65

v2.64a

v2.64

v2.63a

v2.63

v2.61

v2.60a

v2.60

v2.59

v2.58a

v2.58

v2.57b

v2.57a

v2.57

v2.56a

v2.56

v2.55

v2.54

v2.53

v2.52

v2.51

v2.50

v2.49b

v2.49a

v2.49

v2.48a

v2.48

v2.47

v2.46

v2.45

v2.44

v2.43

v2.42a

v2.42

v2.41

v2.40

v2.37a

v2.37

v2.36

v2.35a

v2.35

v2.34

v2.33a

v2.33

v2.32

v2.31a

v2.31

v2.30

v2.28c

v2.28a

v2.28

v2.27

v2.26

v2.25

Labels

Clear labels

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

This issue affects/is about backward or forward compatibility

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Issues relating to Wayland windowing support.

Issues relating to Xorg/X11 support.

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

Clear milestone

No items

No Milestone

Clear projects

No project

Clear assignees

No Assignees

Christoph Lendenfeld

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#81785

Reference in New Issue

Repository

blender/blender

Title

Body

No description provided.

Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Powered by Gitea Page: 562ms Template: 51ms

English

Bahasa Indonesia Deutsch English Español Français Italiano Latviešu Magyar nyelv Nederlands Polski Português de Portugal Português do Brasil Suomi Svenska Türkçe Čeština Ελληνικά Български Русский Українська فارسی മലയാളം 日本語简体中文繁體中文（台灣）繁體中文（香港） 한국어

Licenses API