problem with parenting GreasePencil Layer to armature Bone #82793

Closed
opened 2020-11-17 16:29:37 +01:00 by mchaptel · 18 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 960/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 432.00

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-11-16 21:13, hash: 906ff7b8fe
Worked: 2.79 ?

Short description of error
When parenting a GP layer to an animated bone, an offset seems to occur.

bug_gp_parenting_frame1.PNG

bug_gp_parenting_frame13.PNG

bug_gp_parenting_setup.PNG

Exact steps for others to reproduce the error

  • Open any of the attached files
  • In pose mode, transform the bone that has parenting with the layer of the Grese pencil object
    Parenting a sphere to the bone DEF-spine.006 works as expected.
    However, the same parenting applied to the grease pencil layer does not follow the sphere.
    Note that parenting the layer to the sphere does not take into account the sphere's own parenting.

Simple file:
ex_parentage_broken_simple.blend

Complex file:
ex_parentage_broken.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 960/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 432.00 **Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-11-16 21:13, hash: `906ff7b8fe` Worked: 2.79 ? **Short description of error** When parenting a GP layer to an animated bone, an offset seems to occur. ![bug_gp_parenting_frame1.PNG](https://archive.blender.org/developer/F9312016/bug_gp_parenting_frame1.PNG) ![bug_gp_parenting_frame13.PNG](https://archive.blender.org/developer/F9312015/bug_gp_parenting_frame13.PNG) ![bug_gp_parenting_setup.PNG](https://archive.blender.org/developer/F9312014/bug_gp_parenting_setup.PNG) **Exact steps for others to reproduce the error** - Open any of the attached files - In pose mode, transform the bone that has parenting with the layer of the Grese pencil object Parenting a sphere to the bone DEF-spine.006 works as expected. However, the same parenting applied to the grease pencil layer does not follow the sphere. Note that parenting the layer to the sphere does not take into account the sphere's own parenting. Simple file: [ex_parentage_broken_simple.blend](https://archive.blender.org/developer/F9550405/ex_parentage_broken_simple.blend) Complex file: [ex_parentage_broken.blend](https://archive.blender.org/developer/F9312026/ex_parentage_broken.blend)
Author

Added subscriber: @Awk

Added subscriber: @Awk

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'

Can you simplify the .blend file further?
Unlike the sphere, the Grease Pencil object does not have a parent:
image.png

Both do not have similar configurations so it is not strange that they behave differently.

Can you simplify the .blend file further? Unlike the sphere, the Grease Pencil object does not have a parent: ![image.png](https://archive.blender.org/developer/F9319097/image.png) Both do not have similar configurations so it is not strange that they behave differently.
Author

Hello,

I don't want to parent the grease pencil object, but the single layer, as I may want to parent different layers to different bones. Having a separate grease pencil object for each bone would be too heavy for my workflow which is based on this feature that used to work in 2.79.

However, the relations of the layer itself and the sphere's are the same, as shown in the screen capture I posted above. This information is only visible while the grease pencil object is selected, in the grease pencil layers window.

I'm afraid I can't simplify the blend further because while trying with a simpler file, I could not replicate the bug.

Hello, I don't want to parent the grease pencil object, but the single layer, as I may want to parent different layers to different bones. Having a separate grease pencil object for each bone would be too heavy for my workflow which is based on this feature that used to work in 2.79. However, the relations of the layer itself and the sphere's are the same, as shown in the screen capture I posted above. This information is only visible while the grease pencil object is selected, in the grease pencil layers window. I'm afraid I can't simplify the blend further because while trying with a simpler file, I could not replicate the bug.
Author

Changed status from 'Needs User Info' to: 'Needs Triage'

Changed status from 'Needs User Info' to: 'Needs Triage'

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @filedescriptor

Added subscriber: @filedescriptor

Thanks @filedescriptor for providing a simplified file that helps confirm the problem and will help developers to detect and fix the bug.
Perhaps it is by design or a limitation that the transformation matrix of the Grease Pencil object is not considered in the parenting of layers with bones.
But my first impression is that it is a bug, so I am confirming it.

Thanks @filedescriptor for providing a simplified file that helps confirm the problem and will help developers to detect and fix the bug. Perhaps it is by design or a limitation that the transformation matrix of the Grease Pencil object is not considered in the parenting of layers with bones. But my first impression is that it is a bug, so I am confirming it.

Added subscriber: @antoniov

Added subscriber: @antoniov

Actually the layer parenting is not considering the GPencil object transform. Layer parenting is a special overrride of the parenting and disable any object parenting. If we change that, we could break a lot of files because this is how works, since several versions, so not sure we must change that.

Actually the layer parenting is not considering the GPencil object transform. Layer parenting is a special overrride of the parenting and disable any object parenting. If we change that, we could break a lot of files because this is how works, since several versions, so not sure we must change that.
Author

It seems to me in our recent tests that applying the transform to the grease pencil object and resetting it to a neutral transform fixed the problem.

If that's the case, then most likely all grease pencil objects in files making use of this feature will have a neutral transform otherwise parenting is unusable.

In that sense, it feels like changing this behavior should be compatible with any file making use of this feature.

It seems to me in our recent tests that applying the transform to the grease pencil object and resetting it to a neutral transform fixed the problem. If that's the case, then most likely all grease pencil objects in files making use of this feature will have a neutral transform otherwise parenting is unusable. In that sense, it feels like changing this behavior should be compatible with any file making use of this feature.

@Awk Yes, if you move the gpencil object to origin the problem is fixed... I will think about this and study the implications of the change to verify if we can do it or it's better keep it as a limitation.

@Awk Yes, if you move the gpencil object to origin the problem is fixed... I will think about this and study the implications of the change to verify if we can do it or it's better keep it as a limitation.
Author

Thank you, I appreciate this.

As I said before, from my testing the feature does not work currently, as layers from a gp object that isn't in neutral transform, parented to bones just do not follow what they are parented to, it's very unpredictable.

So to me there aren't really any drawbacks to implementing a complete override for the layers that would take into account the transform on the GP object so that they can follow the bones properly.

I think in fact not fixing it could be very detrimental to the ability to rig greasepencil designs, and that would be a shame.

Thank you, I appreciate this. As I said before, from my testing the feature does not work currently, as layers from a gp object that isn't in neutral transform, parented to bones just do not follow what they are parented to, it's very unpredictable. So to me there aren't really any drawbacks to implementing a complete override for the layers that would take into account the transform on the GP object so that they can follow the bones properly. I think in fact not fixing it could be very detrimental to the ability to rig greasepencil designs, and that would be a shame.
Member

I can confirm that the problem is the GP object origin. If I reset the origin to the world center, the parenting looks good. I don't see an issue with fixing this and breaking older files. As @Awk pointed out, the only way to use layer parenting at the moment is to have the origin at the world center which would not be affected by a patch.

I can confirm that the problem is the GP object origin. If I reset the origin to the world center, the parenting looks good. I don't see an issue with fixing this and breaking older files. As @Awk pointed out, the only way to use layer parenting at the moment is to have the origin at the world center which would not be affected by a patch.
Antonio Vazquez self-assigned this 2021-01-05 10:17:59 +01:00
Member

Added subscriber: @HDMaster84

Added subscriber: @HDMaster84
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Member

Fixed by 9a41b44197

Fixed by 9a41b44197
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#82793
No description provided.