Undo assert changing property in redo panel #85124

New Issue

Hans Goudey · 2021-01-27T19:29:22+01:00

Hans Goudey commented

2021-01-27 19:29:22 +01:00

System Information
Operating system: Linux-5.9.16-100.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.45.01

Blender Version
Caused by 2a8122fb65

Short description of error
Move cube, adjust property, see assert

Exact steps for others to reproduce the error

Move the default cube
Open adjust last operation panel
Tweak a value
Blender closes with an assert:

  /* This function is currently not supposed to redo ever.
   * TODO: Will be fixed in future in continuing undo code refactor effort. */
  BLI_assert(undo_dir == STEP_UNDO);

_BLI_assert_abort() (/home/hans/Documents/Blender-Git/blender/source/blender/blenlib/intern/BLI_assert.c:50)
ed_undo_step_by_name(bContext * C, const char * undo_name, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:335)
ED_undo_pop_op(bContext * C, wmOperator * op) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:418)
ED_undo_operator_repeat(bContext * C, wmOperator * op) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:693)
ED_undo_operator_repeat_cb_evt(bContext * C, void * arg_op, int UNUSED_arg_unused) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:739)
ui_apply_but_funcs_after(bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/interface/interface_handlers.c:963)
ui_handler_region_menu(bContext * C, const wmEvent * event, void * UNUSED_userdata) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/interface/interface_handlers.c:10833)
wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:661)
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:2796)
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:2906)
wm_event_do_handlers(bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:3329)
WM_main(bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm.c:637)
main(int argc, const char ** argv) (/home/hans/Documents/Blender-Git/blender/source/creator/creator.c:522)

**System Information** Operating system: Linux-5.9.16-100.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.45.01 **Blender Version** Caused by 2a8122fb65 **Short description of error** Move cube, adjust property, see assert **Exact steps for others to reproduce the error** - Move the default cube - Open adjust last operation panel - Tweak a value - Blender closes with an assert: ``` /* This function is currently not supposed to redo ever. * TODO: Will be fixed in future in continuing undo code refactor effort. */ BLI_assert(undo_dir == STEP_UNDO); ``` ``` _BLI_assert_abort() (/home/hans/Documents/Blender-Git/blender/source/blender/blenlib/intern/BLI_assert.c:50) ed_undo_step_by_name(bContext * C, const char * undo_name, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:335) ED_undo_pop_op(bContext * C, wmOperator * op) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:418) ED_undo_operator_repeat(bContext * C, wmOperator * op) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:693) ED_undo_operator_repeat_cb_evt(bContext * C, void * arg_op, int UNUSED_arg_unused) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:739) ui_apply_but_funcs_after(bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/interface/interface_handlers.c:963) ui_handler_region_menu(bContext * C, const wmEvent * event, void * UNUSED_userdata) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/interface/interface_handlers.c:10833) wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:661) wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:2796) wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:2906) wm_event_do_handlers(bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:3329) WM_main(bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm.c:637) main(int argc, const char ** argv) (/home/hans/Documents/Blender-Git/blender/source/creator/creator.c:522) ```

Hans Goudey commented

2021-01-27 19:29:22 +01:00

Added subscriber: @HooglyBoogly