free style does not work if there are nested collections #85451

Open
opened 2021-02-07 16:04:56 +01:00 by stefano · 8 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 2.91.2, branch: master, commit date: 2021-01-19 16:15, hash: 5be9ef4177
Worked: (newest version of Blender that worked as expected)

Short description of error
I'm not sure it can be called "bug", but if I apply freestyle to a collection (which I call "Lines") that contains others, it doesn't work

Exact steps for others to reproduce the error
I create objects to which I want to apply freestyle, I put them inside each of its collections. If I apply the freestyle option to the "Lines" collection it doesn't work. It only works if the objects are directly inside the "Lines" collection. It is a problem when I work on very complex scenes where it is useful to organize objects within many collections and I want to apply freestyle only to some of these collections by inserting them into a larger one (Lines) and leaving the others in another call " no lines "freestyle.blend

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 2.91.2, branch: master, commit date: 2021-01-19 16:15, hash: `5be9ef4177` Worked: (newest version of Blender that worked as expected) **Short description of error** I'm not sure it can be called "bug", but if I apply freestyle to a collection (which I call "Lines") that contains others, it doesn't work **Exact steps for others to reproduce the error** I create objects to which I want to apply freestyle, I put them inside each of its collections. If I apply the freestyle option to the "Lines" collection it doesn't work. It only works if the objects are directly inside the "Lines" collection. It is a problem when I work on very complex scenes where it is useful to organize objects within many collections and I want to apply freestyle only to some of these collections by inserting them into a larger one (Lines) and leaving the others in another call " no lines "[freestyle.blend](https://archive.blender.org/developer/F9703246/freestyle.blend)
Author

Added subscriber: @stefanocioncoloni

Added subscriber: @stefanocioncoloni
Member

Added subscriber: @filedescriptor

Added subscriber: @filedescriptor
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

I can confirm this issue on the latest 2.93.0 Alpha, branch: master, commit date: 2021-02-08 10:36, hash: ecfd5360a1. The console shows an error:

Error: strokes set empty

which is triggered in blender/source/blender/freestyle/intern/stroke/StyleModule.h:

Operators::StrokesContainer *strokes_set = Operators::getStrokesSet();
if (strokes_set->empty()) {
  cerr << "Error: strokes set empty" << endl;
  Operators::reset();
  return NULL;
}
I can confirm this issue on the latest 2.93.0 Alpha, branch: master, commit date: 2021-02-08 10:36, hash: `ecfd5360a1`. The console shows an error: ``` Error: strokes set empty ``` which is triggered in `blender/source/blender/freestyle/intern/stroke/StyleModule.h`: ``` Operators::StrokesContainer *strokes_set = Operators::getStrokesSet(); if (strokes_set->empty()) { cerr << "Error: strokes set empty" << endl; Operators::reset(); return NULL; } ```

Added subscriber: @XB982

Added subscriber: @XB982

I can also confirm that the same is true when excluding collections (as opposed to including them). Only the objects at the top level in the excluded collection are excluded from freestyle stroke rendering, any objects in any collections within the excluded collection are included in the render.

If this is looked into, it might be worthwhile to add the possibility to include/exclude several different collections at once, e.g. a button to add more "Collection:" boxes or having a list box like for Line Sets. Now the Parameter Editor Mode UI is limited to selecting one collection for either inclusion/exclusion, and you need to go to Python Scripting Mode to make more complex arrangements.

I can also confirm that the same is true when excluding collections (as opposed to including them). Only the objects at the top level in the excluded collection are excluded from freestyle stroke rendering, any objects in any collections within the excluded collection are included in the render. If this is looked into, it might be worthwhile to add the possibility to include/exclude several different collections at once, e.g. a button to add more "Collection:" boxes or having a list box like for Line Sets. Now the Parameter Editor Mode UI is limited to selecting *one* collection for either inclusion/exclusion, and you need to go to Python Scripting Mode to make more complex arrangements.

Added subscriber: @UtenteFittizio

Added subscriber: @UtenteFittizio
Author

the problem is still present in version 3.1.2. Any news on the horizon?
thank you

the problem is still present in version 3.1.2. Any news on the horizon? thank you
Philipp Oeser removed the
Interest
Render & Cycles
label 2023-02-09 14:01:56 +01:00
Philipp Oeser added the
Interest
VFX & Video
label 2023-02-10 11:36:38 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#85451
No description provided.