Crash when evaluating object with unsupported modifier #87232

Closed
opened 2021-04-06 11:41:40 +02:00 by Antonio Vazquez · 12 comments

Opening a rig that worked in 2.91 produce a total crash.

Exception Address     : 0x00007FF7BCA26710
Exception Module      : blender.exe
Exception Flags       : 0x00000000
Exception Parameters  : 0x2
	Parameters- [x] : 0x0000000000000001
	Parameters- [x] : 0x0000000000000068


Stack trace:
blender.exe         :0x00007FF7BCA26420  blender::deg::`anonymous namespace'::update_id_after_copy
blender.exe         :0x00007FF7BCA254B0  blender::deg::deg_expand_copy_on_write_datablock
blender.exe         :0x00007FF7BCA259C0  blender::deg::deg_update_copy_on_write_datablock
blender.exe         :0x00007FF7BCA25450  blender::deg::deg_evaluate_copy_on_write
blender.exe         :0x00007FF7BCA33F20  blender::deg::`anonymous namespace'::evaluate_node
blender.exe         :0x00007FF7BCA33ED0  blender::deg::`anonymous namespace'::deg_task_run_func
tbb.dll             :0x00007FFD719154A0  tbb::interface7::internal::isolate_within_arena
blender.exe         :0x00007FF7BCEBBAE0  tbb::internal::function_task<Task>::execute
tbb.dll             :0x00007FFD719254D0  tbb::recursive_mutex::scoped_lock::internal_try_acquire
tbb.dll             :0x00007FFD719254D0  tbb::recursive_mutex::scoped_lock::internal_try_acquire
tbb.dll             :0x00007FFD719154A0  tbb::interface7::internal::isolate_within_arena
tbb.dll             :0x00007FFD7191AA50  tbb::task_scheduler_init::terminate
tbb.dll             :0x00007FFD719236F0  tbb::thread_bound_filter::try_process_item
tbb.dll             :0x00007FFD719236F0  tbb::thread_bound_filter::try_process_item
ucrtbase.dll        :0x00007FFD961C1B20  configthreadlocale
KERNEL32.DLL        :0x00007FFD97877020  BaseThreadInitThunk
ntdll.dll           :0x00007FFD98822630  RtlUserThreadStart```

Windows 10
RTX2080TI

Works: 2.91.2

Caused by bc95c249a7

Fails: I have tested in 2.92 and 2.93 last master code.

Test file: [Red-Nelb_2.82.blend](https://archive.blender.org/developer/F9921623/Red-Nelb_2.82.blend)

Opening a rig that worked in 2.91 produce a total crash. ```ExceptionCode : EXCEPTION_ACCESS_VIOLATION Exception Address : 0x00007FF7BCA26710 Exception Module : blender.exe Exception Flags : 0x00000000 Exception Parameters : 0x2 Parameters- [x] : 0x0000000000000001 Parameters- [x] : 0x0000000000000068 Stack trace: blender.exe :0x00007FF7BCA26420 blender::deg::`anonymous namespace'::update_id_after_copy blender.exe :0x00007FF7BCA254B0 blender::deg::deg_expand_copy_on_write_datablock blender.exe :0x00007FF7BCA259C0 blender::deg::deg_update_copy_on_write_datablock blender.exe :0x00007FF7BCA25450 blender::deg::deg_evaluate_copy_on_write blender.exe :0x00007FF7BCA33F20 blender::deg::`anonymous namespace'::evaluate_node blender.exe :0x00007FF7BCA33ED0 blender::deg::`anonymous namespace'::deg_task_run_func tbb.dll :0x00007FFD719154A0 tbb::interface7::internal::isolate_within_arena blender.exe :0x00007FF7BCEBBAE0 tbb::internal::function_task<Task>::execute tbb.dll :0x00007FFD719254D0 tbb::recursive_mutex::scoped_lock::internal_try_acquire tbb.dll :0x00007FFD719254D0 tbb::recursive_mutex::scoped_lock::internal_try_acquire tbb.dll :0x00007FFD719154A0 tbb::interface7::internal::isolate_within_arena tbb.dll :0x00007FFD7191AA50 tbb::task_scheduler_init::terminate tbb.dll :0x00007FFD719236F0 tbb::thread_bound_filter::try_process_item tbb.dll :0x00007FFD719236F0 tbb::thread_bound_filter::try_process_item ucrtbase.dll :0x00007FFD961C1B20 configthreadlocale KERNEL32.DLL :0x00007FFD97877020 BaseThreadInitThunk ntdll.dll :0x00007FFD98822630 RtlUserThreadStart``` Windows 10 RTX2080TI Works: 2.91.2 Caused by bc95c249a7 Fails: I have tested in 2.92 and 2.93 last master code. Test file: [Red-Nelb_2.82.blend](https://archive.blender.org/developer/F9921623/Red-Nelb_2.82.blend)
Author
Member

Added subscriber: @antoniov

Added subscriber: @antoniov
Author
Member
[Red-Nelb_2.82.crash.txt](https://archive.blender.org/developer/F9921625/Red-Nelb_2.82.crash.txt)
Member

Added subscriber: @filedescriptor

Added subscriber: @filedescriptor
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

I can confirm this crash on both 2.93.0 Alpha (branch: master, commit date: 2021-04-06 09:14, hash: 663a82b10d) and 2.92.0

I can confirm this crash on both 2.93.0 Alpha (branch: master, commit date: 2021-04-06 09:14, hash: `663a82b10d`) and 2.92.0
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Can confirm, will bisect.

Can confirm, will bisect.
Member

Caused by bc95c249a7

Caused by bc95c249a7
Sybren A. Stüvel self-assigned this 2021-04-08 18:30:17 +02:00

The crash seems to be caused by an Armature Object having a Subsurf modifier. This is not a valid modifier for the object type, which means that it is not copied over to the evaluated copy of the object (see BKE_object_modifier_stack_copy() as called from object_copy_data() in object.c). This causes the crash when the depsgraph code tries to set the "original data" pointer on the non-existent modifier.

I'll fix this by adding an extra check on the "set original data pointer" loop, so that it doesn't crash any more. However, it's still a mystery to me how that modifier was assigned to the Armature object in the first place.

The crash seems to be caused by an Armature Object having a Subsurf modifier. This is not a valid modifier for the object type, which means that it is not copied over to the evaluated copy of the object (see `BKE_object_modifier_stack_copy()` as called from `object_copy_data()` in `object.c`). This causes the crash when the depsgraph code tries to set the "original data" pointer on the non-existent modifier. I'll fix this by adding an extra check on the "set original data pointer" loop, so that it doesn't crash any more. However, it's still a mystery to me how that modifier was assigned to the Armature object in the first place.
Sybren A. Stüvel changed title from Crash opening rig in 2.92 and 2.93 to Crash when evaluating object with unsupported modifier 2021-04-08 18:51:02 +02:00

This issue was referenced by b51562ed76

This issue was referenced by b51562ed76d5428ed4d511cd248d1b059e341661

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Author
Member

@dr.sybren I don't know how the modifier was created because the rig is not mine.

@dr.sybren I don't know how the modifier was created because the rig is not mine.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#87232
No description provided.