Crash when adding an object to asset with geometry nodes modifier #87417

New Issue

Sergey · 2021-04-12T12:38:38+02:00

Sergey commented

2021-04-12 12:38:38 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: Intel(R) HD Graphics 630 Intel 4.5.0 - Build 25.20.100.6471

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-04-11 20:10, hash: 09d7d88cc4
Caused by c6ff722a1f

Short description of error
Crash when adding an object to asset.
I cleaned the file and it looks like there is still something in it what make it crash. I did not manage to reproduce the crash with a new file. Don't know what can be the reason of it but without geometry node modifier it stops crashing.

Exact steps for others to reproduce the error
test.blend

Open the file
In Outliner editor RMB on the Test object -> ID Data -> Mark Asset
Crash

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: Intel(R) HD Graphics 630 Intel 4.5.0 - Build 25.20.100.6471 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-04-11 20:10, hash: `09d7d88cc4` Caused by c6ff722a1f **Short description of error** Crash when adding an object to asset. I cleaned the file and it looks like there is still something in it what make it crash. I did not manage to reproduce the crash with a new file. Don't know what can be the reason of it but without geometry node modifier it stops crashing. **Exact steps for others to reproduce the error** [test.blend](https://archive.blender.org/developer/F9930326/test.blend) 1. Open the file 2. In Outliner editor RMB on the `Test` object -> `ID Data` -> `Mark Asset` 3. Crash

Sergey commented

2021-04-12 12:38:38 +02:00

Added subscriber: @randum

Falk David commented

2021-04-14 09:00:23 +02:00

Added subscriber: @filedescriptor

Falk David commented

2021-04-14 09:00:23 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Falk David commented

2021-04-14 09:00:23 +02:00

I can confirm this crash on the latest 2.93.0 Alpha, branch: master, commit date: 2021-04-14 06:18, hash: a425b2b25c.
Will take a look.

I can confirm this crash on the latest 2.93.0 Alpha, branch: master, commit date: 2021-04-14 06:18, hash: `a425b2b25c`. Will take a look.

Falk David commented

2021-04-14 14:45:55 +02:00

So this crashes sometimes because the assert BLI_assert(imm->shader == nullptr); in void immBindShader(GPUShader *shader) fails. imm->shader is populated. But I think that this might just be some memory that got overwritten, so the issue might be somewhere else.

libc.so.6!__GI_raise(int sig) (raise.c:49)
libc.so.6!__GI_abort() (abort.c:79)
_BLI_assert_abort() (/blender/source/blender/blenlib/intern/BLI_assert.c:56)
immBindShader(GPUShader * shader) (/blender/source/blender/gpu/intern/gpu_immediate.cc:62)
immBindBuiltinProgram(eGPUBuiltinShader shader_id) (/blender/source/blender/gpu/intern/gpu_immediate.cc:80)
DRW_draw_cursor() (/blender/source/blender/draw/intern/draw_view.c:144)
DRW_draw_region_info() (/blender/source/blender/draw/intern/draw_view.c:56)
DRW_draw_callbacks_post_scene() (/blender/source/blender/draw/intern/draw_manager.c:1450)
DRW_draw_render_loop_ex(struct Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) (/blender/source/blender/draw/intern/draw_manager.c:1644)
DRW_draw_view(const bContext * C) (/blender/source/blender/draw/intern/draw_manager.c:1513)
view3d_draw_view(const bContext * C, ARegion * region) (/blender/source/blender/editors/space_view3d/view3d_draw.c:1560)
view3d_main_region_draw(const bContext * C, ARegion * region) (/blender/source/blender/editors/space_view3d/view3d_draw.c:1582)
ED_region_do_draw(bContext * C, ARegion * region) (/blender/source/blender/editors/screen/area.c:558)
wm_draw_window_offscreen(bContext * C, wmWindow * win, _Bool stereo) (/blender/source/blender/windowmanager/intern/wm_draw.c:724)
wm_draw_window(bContext * C, wmWindow * win) (/blender/source/blender/windowmanager/intern/wm_draw.c:864)
wm_draw_update(bContext * C) (/blender/source/blender/windowmanager/intern/wm_draw.c:1065)
WM_main(bContext * C) (/blender/source/blender/windowmanager/intern/wm.c:652)
main(int argc, const char ** argv) (/blender/source/creator/creator.c:520)

So this crashes **sometimes** because the assert `BLI_assert(imm->shader == nullptr);` in `void immBindShader(GPUShader *shader)` fails. `imm->shader` is populated. But I think that this might just be some memory that got overwritten, so the issue might be somewhere else. ``` libc.so.6!__GI_raise(int sig) (raise.c:49) libc.so.6!__GI_abort() (abort.c:79) _BLI_assert_abort() (/blender/source/blender/blenlib/intern/BLI_assert.c:56) immBindShader(GPUShader * shader) (/blender/source/blender/gpu/intern/gpu_immediate.cc:62) immBindBuiltinProgram(eGPUBuiltinShader shader_id) (/blender/source/blender/gpu/intern/gpu_immediate.cc:80) DRW_draw_cursor() (/blender/source/blender/draw/intern/draw_view.c:144) DRW_draw_region_info() (/blender/source/blender/draw/intern/draw_view.c:56) DRW_draw_callbacks_post_scene() (/blender/source/blender/draw/intern/draw_manager.c:1450) DRW_draw_render_loop_ex(struct Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) (/blender/source/blender/draw/intern/draw_manager.c:1644) DRW_draw_view(const bContext * C) (/blender/source/blender/draw/intern/draw_manager.c:1513) view3d_draw_view(const bContext * C, ARegion * region) (/blender/source/blender/editors/space_view3d/view3d_draw.c:1560) view3d_main_region_draw(const bContext * C, ARegion * region) (/blender/source/blender/editors/space_view3d/view3d_draw.c:1582) ED_region_do_draw(bContext * C, ARegion * region) (/blender/source/blender/editors/screen/area.c:558) wm_draw_window_offscreen(bContext * C, wmWindow * win, _Bool stereo) (/blender/source/blender/windowmanager/intern/wm_draw.c:724) wm_draw_window(bContext * C, wmWindow * win) (/blender/source/blender/windowmanager/intern/wm_draw.c:864) wm_draw_update(bContext * C) (/blender/source/blender/windowmanager/intern/wm_draw.c:1065) WM_main(bContext * C) (/blender/source/blender/windowmanager/intern/wm.c:652) main(int argc, const char ** argv) (/blender/source/creator/creator.c:520) ```

Andrew Pluzhnikov commented

2021-04-26 01:50:28 +02:00

Added subscriber: @Andrew_Pluzhnikov

Andrew Pluzhnikov commented

2021-04-26 01:50:29 +02:00

Using Windows 10 build from current ToT (hash: c204e0c385), blender crashes every time with consistent stack trace:

blender.exe         :0x00007FF69014F900  find_sockets_to_preview C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1193
blender.exe         :0x00007FF69014D160  compute_geometry C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1314
blender.exe         :0x00007FF690150D50  modifyGeometry C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1419
blender.exe         :0x00007FF68FF43540  modifier_modify_mesh_and_geometry_set C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:955
blender.exe         :0x00007FF68FF42160  mesh_calc_modifiers C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1304
blender.exe         :0x00007FF68FF41E60  mesh_build_data C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1941
blender.exe         :0x00007FF68FF44730  makeDerivedMesh C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:2072
blender.exe         :0x00007FF68FF20060  BKE_object_handle_data_update C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\object_update.c:204
blender.exe         :0x00007FF68FF1FD90  BKE_object_eval_uber_data C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\object_update.c:389
blender.exe         :0x00007FF6944B4CA0  blender::deg::`anonymous namespace'::evaluate_node C:\Users\Andrew\blender-all\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:115
blender.exe         :0x00007FF6944B4C50  blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Andrew\blender-all\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:127
tbb.dll             :0x00007FFC562C54A0  tbb::interface7::internal::isolate_within_arena
blender.exe         :0x00007FF69493CDF0  tbb::internal::function_task<Task>::execute C:\Users\Andrew\blender-all\lib\win64_vc15\tbb\include\tbb\task.h:1059
tbb.dll             :0x00007FFC562D54D0  tbb::recursive_mutex::scoped_lock::internal_try_acquire
tbb.dll             :0x00007FFC562D54D0  tbb::recursive_mutex::scoped_lock::internal_try_acquire
tbb.dll             :0x00007FFC562C54A0  tbb::interface7::internal::isolate_within_arena
tbb.dll             :0x00007FFC562CAA50  tbb::task_scheduler_init::terminate
tbb.dll             :0x00007FFC562D36F0  tbb::thread_bound_filter::try_process_item
tbb.dll             :0x00007FFC562D36F0  tbb::thread_bound_filter::try_process_item
ucrtbase.dll        :0x00007FFC88E40F70  beginthreadex
KERNEL32.DLL        :0x00007FFC8AB97C10  BaseThreadInitThunk
ntdll.dll           :0x00007FFC8BE6D700  RtlUserThreadStart

test.crash.txt

Using Windows 10 build from current ToT (hash: c204e0c38531), blender crashes every time with consistent stack trace: ``` blender.exe :0x00007FF69014F900 find_sockets_to_preview C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1193 blender.exe :0x00007FF69014D160 compute_geometry C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1314 blender.exe :0x00007FF690150D50 modifyGeometry C:\Users\Andrew\blender-all\blender\source\blender\modifiers\intern\MOD_nodes.cc:1419 blender.exe :0x00007FF68FF43540 modifier_modify_mesh_and_geometry_set C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:955 blender.exe :0x00007FF68FF42160 mesh_calc_modifiers C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1304 blender.exe :0x00007FF68FF41E60 mesh_build_data C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1941 blender.exe :0x00007FF68FF44730 makeDerivedMesh C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\DerivedMesh.cc:2072 blender.exe :0x00007FF68FF20060 BKE_object_handle_data_update C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\object_update.c:204 blender.exe :0x00007FF68FF1FD90 BKE_object_eval_uber_data C:\Users\Andrew\blender-all\blender\source\blender\blenkernel\intern\object_update.c:389 blender.exe :0x00007FF6944B4CA0 blender::deg::`anonymous namespace'::evaluate_node C:\Users\Andrew\blender-all\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:115 blender.exe :0x00007FF6944B4C50 blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Andrew\blender-all\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:127 tbb.dll :0x00007FFC562C54A0 tbb::interface7::internal::isolate_within_arena blender.exe :0x00007FF69493CDF0 tbb::internal::function_task<Task>::execute C:\Users\Andrew\blender-all\lib\win64_vc15\tbb\include\tbb\task.h:1059 tbb.dll :0x00007FFC562D54D0 tbb::recursive_mutex::scoped_lock::internal_try_acquire tbb.dll :0x00007FFC562D54D0 tbb::recursive_mutex::scoped_lock::internal_try_acquire tbb.dll :0x00007FFC562C54A0 tbb::interface7::internal::isolate_within_arena tbb.dll :0x00007FFC562CAA50 tbb::task_scheduler_init::terminate tbb.dll :0x00007FFC562D36F0 tbb::thread_bound_filter::try_process_item tbb.dll :0x00007FFC562D36F0 tbb::thread_bound_filter::try_process_item ucrtbase.dll :0x00007FFC88E40F70 beginthreadex KERNEL32.DLL :0x00007FFC8AB97C10 BaseThreadInitThunk ntdll.dll :0x00007FFC8BE6D700 RtlUserThreadStart ``` [test.crash.txt](https://archive.blender.org/developer/F10038151/test.crash.txt)

Andrew Pluzhnikov commented

2021-04-26 02:16:10 +02:00

Possible fix. Not sure if correct.

#87417.patch.txt

Possible fix. Not sure if correct. [#87417.patch.txt](https://archive.blender.org/developer/F10038179/T87417.patch.txt)

Pratik Borhade commented

2021-05-01 11:28:30 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-05-01 11:28:30 +02:00

crash caused by c6ff722a1f

@Andrew_Pluzhnikov , if you want to contribute the code, refer https://wiki.blender.org/wiki/Process/Contributing_Code to submit a patch :)

crash caused by c6ff722a1fcc632eacebcfc94417df466742ce5f @Andrew_Pluzhnikov , if you want to contribute the code, refer https://wiki.blender.org/wiki/Process/Contributing_Code to submit a patch :)

Pratik Borhade self-assigned this 2021-05-12 15:53:30 +02:00

Pratik Borhade commented

2021-05-12 15:53:30 +02:00

Will take a look.
Single check can fix the problem, I guess

Will take a look. Single check can fix the problem, I guess

blender-admin commented

2021-05-14 13:43:30 +02:00

This issue was referenced by 16bcf7dc8e

This issue was referenced by 16bcf7dc8e70890b8ad75c84f8699a4507477668

Jacques Lucke commented

2021-05-14 13:45:54 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2021-05-14 13:45:54 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when adding an object to asset with geometry nodes modifier #87417