Undo "SVG as Grease Pencil" Crashes #87999

New Issue

adam · 2021-05-03T02:22:50+02:00

adam commented

2021-05-03 02:22:50 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 750/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.89

Blender Version
Broken: version: 2.93.0 Beta, branch: master, commit date: 2021-05-02 20:37, hash: 28bf1d4037
Broken: version: 3.0.0 Alpha

Description
Undoing after Import -> SVG as Grease Pencil crashes Blender.

Steps

Select "2D Animation" preset
Import -> SVG as Grease Pencil -> SVG File
Ctrl-Z (undo) crashes Blender

Note: When "2D Animation" preset is not selected, it doesn't crash, but also doesn't delete the imported file.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 750/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.89 **Blender Version** Broken: version: 2.93.0 Beta, branch: master, commit date: 2021-05-02 20:37, hash: `28bf1d4037` Broken: version: 3.0.0 Alpha **Description** Undoing after Import -> SVG as Grease Pencil crashes Blender. **Steps** - Select "2D Animation" preset - Import -> SVG as Grease Pencil -> SVG File - Ctrl-Z (undo) crashes Blender Note: When "2D Animation" preset is not selected, it doesn't crash, but also doesn't delete the imported file.

adam commented

2021-05-03 02:22:50 +02:00

Added subscriber: @adm

Falk David commented

2021-05-03 11:22:41 +02:00

Added subscriber: @filedescriptor

Falk David commented

2021-05-03 11:22:41 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Falk David commented

2021-05-03 11:22:41 +02:00

I cannot reproduce the crash in the Alpha nor Beta on Linux.

@adm Could you add your system information to the task? (We assume all bug reports to follow the bug report template).

I cannot reproduce the crash in the Alpha nor Beta on Linux. @adm Could you add your system information to the task? (We assume all bug reports to follow the [bug report template](https://developer.blender.org/maniphest/task/edit/form/1/)).

adam commented

2021-05-03 15:09:45 +02:00

This comment was removed by @adm

*This comment was removed by @adm*

Antonio Vazquez commented

2021-05-03 15:44:10 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Antonio Vazquez commented

2021-05-03 15:44:33 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2021-05-03 15:44:33 +02:00

Crash in BKE_scene_object_base_flag_sync_from_base()

Crash in `BKE_scene_object_base_flag_sync_from_base()`

Antonio Vazquez commented

2021-05-03 16:32:44 +02:00

Added subscriber: @mont29

Antonio Vazquez commented

2021-05-03 16:32:44 +02:00

I have been testing and this is the result:

Default scene, Cube is active but the focus is not on the cube, Import, Undo->No crash, but NO undo.
Default scene with cube selected, Import, Undo->Crash
Default scene, clear all objects, Import, Undo->Crash

All crashes are in void BKE_scene_object_base_flag_sync_from_base(Base *base) because base->object is NULL

@mont29 Could you help us here? Problem looks related to Undo, maybe a bug or maybe I missed to tag something.

Here a test file:

I have been testing and this is the result: 1) Default scene, Cube is active but the focus is not on the cube, Import, Undo->No crash, but NO undo. 2) Default scene with cube selected, Import, Undo->Crash 3) Default scene, clear all objects, Import, Undo->Crash All crashes are in `void BKE_scene_object_base_flag_sync_from_base(Base *base)` because `base->object` is `NULL` @mont29 Could you help us here? Problem looks related to Undo, maybe a bug or maybe I missed to tag something. Here a test file: ![SVG_Rocket_new.svg](https://archive.blender.org/developer/F10051440/SVG_Rocket_new.svg)

Bastien Montagne commented

2021-05-03 19:00:49 +02:00

Hrmmm.... This smells like some ID being added or changed without proper tagging, or without proper call to collections/layercollections update functions (guys like BKE_main_collection_sync_remap). Or maybe a missing object cache clearing (BKE_collection_object_cache_free)?

Fairly hard to help more without spending time investigating the addon and the RNA functions/properties it uses am afraid.

Hrmmm.... This smells like some ID being added or changed without proper tagging, or without proper call to collections/layercollections update functions (guys like `BKE_main_collection_sync_remap`). Or maybe a missing object cache clearing (`BKE_collection_object_cache_free`)? Fairly hard to help more without spending time investigating the addon and the RNA functions/properties it uses am afraid.

Antonio Vazquez commented

2021-05-03 19:25:23 +02:00

@mont29 The code (C++) is adding a new object and I guess something is missing.

You can see the code in Object *GpencilImporter::create_object()

The function is calling to ED_gpencil_add_object and this calls to ED_object_add_type(C, OB_GPENCIL, NULL, loc, rot, false, local_view_bits);

Sure I need call to something else... could you tell me what I'm missing?

@mont29 The code (C++) is adding a new object and I guess something is missing. You can see the code in `Object *GpencilImporter::create_object()` The function is calling to `ED_gpencil_add_object` and this calls to `ED_object_add_type(C, OB_GPENCIL, NULL, loc, rot, false, local_view_bits);` Sure I need call to something else... could you tell me what I'm missing?

Antonio Vazquez commented

2022-06-06 09:39:56 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2022-06-06 09:39:56 +02:00

Antonio Vazquez self-assigned this 2022-06-06 09:39:56 +02:00

Antonio Vazquez commented

2022-06-06 09:39:56 +02:00

This is fixed in last versions.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Undo "SVG as Grease Pencil" Crashes #87999