Unable to change Effect parameters for Grease Pencil objects created with Library Override #88974

Closed
opened 2021-06-08 21:43:26 +02:00 by Kei Muratagawa · 15 comments

(Edited June 10, 2021) I'm sorry for typos. Corrected the description.


System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.59

Blender Version
Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: 84da05a8b8
Worked: none

Short description of error

{F10163153, size=full}

When you add a Visual Effect to Grease Pencil object created with Library Override, you cannot change the parameters.

For Modifiers, you can change the parameters of the newly added one. I expected the same behavior for Effect.

Exact steps for others to reproduce the error

First, create a GPencil object:

  • Open new file
  • Shift+A -> Grease Pencil -> Monkey
  • Select Suzanne
  • Add a new Visual Effect (e.g.: Blur)

Save to .blend file

Next, link the above file from another file:

  • Open new file
  • File -> Link
  • Specify the above .blend file and the collection
  • Select linked Suzanne
  • Object -> Relations -> Make Library Override...
  • Open "Visual Effect Properties" tab

Now when you add a new Effect, the parameters are grayed out and cannot be changed.
(I think it should be editable.)

Also, if you hover the mouse cursor over the input field, the following error message will be displayed.

Disabled: Cannot edit this property from the override data block.
(Edited June 10, 2021) I'm sorry for typos. Corrected the description. ---- **System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.59 **Blender Version** Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: `84da05a8b8` Worked: none **Short description of error** {[F10163153](https://archive.blender.org/developer/F10163153/locked_parameters.jpg), size=full} When you add a Visual Effect to Grease Pencil object created with Library Override, you cannot change the parameters. For Modifiers, you can change the parameters of the newly added one. I expected the same behavior for Effect. **Exact steps for others to reproduce the error** First, create a GPencil object: - Open new file - *Shift+A -> Grease Pencil -> Monkey* - Select Suzanne - Add a new Visual Effect (e.g.: Blur) # Save to .blend file Next, link the above file from another file: - Open new file - *File -> Link* - Specify the above .blend file and the collection - Select linked Suzanne - *Object -> Relations -> Make Library Override...* - Open "Visual Effect Properties" tab Now when you add a new Effect, the parameters are grayed out and cannot be changed. (I think it should be editable.) Also, if you hover the mouse cursor over the input field, the following error message will be displayed. ``` Disabled: Cannot edit this property from the override data block. ```
Author

Added subscriber: @muratagawa

Added subscriber: @muratagawa
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Can confirm for 3.0.0 alpha (8c3f4f7edf)

Can confirm for 3.0.0 alpha (`8c3f4f7edf`)

Added subscribers: @mont29, @antoniov

Added subscribers: @mont29, @antoniov

@mont29 Could you take a look at this? Not sure if this is a non supported feature as override materials.

@mont29 Could you take a look at this? Not sure if this is a non supported feature as override materials.

This is just missing RNA code...

Will keep the 'adding new shaderfx to an override' for later though (process will be similar to the one for modifiers, but we need to refactor this one first, so better not add more to this for now).

This is just missing RNA code... Will keep the 'adding new shaderfx to an override' for later though (process will be similar to the one for modifiers, but we need to refactor this one first, so better not add more to this for now).

This issue was referenced by 2856f3b583

This issue was referenced by 2856f3b58392a64204c808c8760739820da287f4

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Bastien Montagne self-assigned this 2021-06-09 18:49:06 +02:00
Author

I have confirmed the issue is fixed in the recent daily build (blender-3.0.0-alpha+master.461ba4438f90-windows.amd64). Thank you!

However, "Name" field is still not editable. Shouldn't it also be editable?

effect_name_field_uneditable.jpg

I have confirmed the issue is fixed in the recent daily build (blender-3.0.0-alpha+master.461ba4438f90-windows.amd64). Thank you! However, **"Name"** field is still not editable. Shouldn't it also be editable? ![effect_name_field_uneditable.jpg](https://archive.blender.org/developer/F10166469/effect_name_field_uneditable.jpg)

@muratagawa no, names are used to link overrides to their original linked data, so they must not be editable.

@muratagawa no, names are used to link overrides to their original linked data, so they must not be editable.
Author

Excuse me, my explanation was insufficient.

I thought the "Name" field of Visual Effect added after Linked Override should be editable -- like Modifiers. Is this wrong?


I'll explain it with images. I checked it in the recent daily build (blender-3.0.0-alpha+master.461ba4438f90-windows.amd64).

modifier_linked_override.png

For Modifiers, you can not edit the "Name" of the Modifier which was added to the original file.
And the "Name" of the newly added Modifier is editable. These are as expected.

effect_linked_override.png

However, for Visual Effects, you cannot edit the "Name" of the newly added Effect. Shouldn't it be editable?

Excuse me, my explanation was insufficient. I thought the "Name" field of Visual Effect added after Linked Override should be editable -- like Modifiers. Is this wrong? ---- I'll explain it with images. I checked it in the recent daily build (blender-3.0.0-alpha+master.461ba4438f90-windows.amd64). ![modifier_linked_override.png](https://archive.blender.org/developer/F10167355/modifier_linked_override.png) For Modifiers, you can not edit the "Name" of the Modifier which was added to the original file. And the "Name" of the newly added Modifier is editable. These are as expected. ![effect_linked_override.png](https://archive.blender.org/developer/F10167354/effect_linked_override.png) However, for Visual Effects, you cannot edit the "Name" of the newly added Effect. Shouldn't it be editable?

As I said, you should not be able to add new shaderfx to an override currently, those will be lost on save/reload anyway...

Working of preventing adding those on overrides for now (again, this feature will be added once we have fixed issues in underlying system).

As I said, you should not be able to add new shaderfx to an override currently, those will be lost on save/reload anyway... Working of preventing adding those on overrides for now (again, this feature will be added once we have fixed issues in underlying system).

This issue was referenced by 0cebe554d1

This issue was referenced by 0cebe554d13bf1ea4c81fd4addee30dd4ea4d2f1
Author

Thank you for explanation. I hope the feature will be implemented. {icon smile-o}

Thank you for explanation. I hope the feature will be implemented. {icon smile-o}
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#88974
No description provided.