Segfault on unregistering operator/menu with open props dialog. #89123

New Issue

Will · 2021-06-13T23:01:09+02:00

Will commented

2021-06-13 23:01:09 +02:00

System Information
Operating system: Linux
Graphics card: Intel

Blender Version
Broken: 2.92, 2.93

Short description of error

When an operator currently has a wm.props_dialog_(self) open, unregistering it will cause a segfault.

This only seems to happen reliably when the module it's from has at least one bpy.types.Menu subclass that's also been registered.

The displayed values of property fields in the dialog will sometimes flicker and switch values with each other for a split second before the segfault.

Exact steps for others to reproduce the error

InvokeSegfault.blend

Open the attached file.
Invoke the operator from the 3DView toolbar.
Use a system hotkey (E.G. ALT+TAB) to switch to the window with the text editor space while leaving the props dialog open.
Run the script again from the text editor window.

**System Information** Operating system: Linux Graphics card: Intel **Blender Version** Broken: 2.92, 2.93 **Short description of error** When an operator currently has a `wm.props_dialog_(self)` open, unregistering it will cause a segfault. This only seems to happen reliably when the module it's from has at least one `bpy.types.Menu` subclass that's also been registered. The displayed values of property fields in the dialog will sometimes flicker and switch values with each other for a split second before the segfault. **Exact steps for others to reproduce the error** [InvokeSegfault.blend](https://archive.blender.org/developer/F10169997/InvokeSegfault.blend) 1. Open the attached file. 2. Invoke the operator from the 3DView toolbar. 3. Use a system hotkey (E.G. `ALT`+`TAB`) to switch to the window with the text editor space while leaving the props dialog open. 4. Run the script again from the text editor window.

Will commented

2021-06-13 23:01:09 +02:00

Added subscriber: @WCN

Will commented

2021-06-13 23:10:39 +02:00

Here's a somewhat shorter reproducer that triggers invokes the operator and triggers the crash automatically:

InvokeSegfaultB.blend

As with before, I could only get it to happen reliably when there's also a menu class that gets (un) regsitered.

"""Press the Run Script button for a segfault."""

import bpy


class InvokeOperator(bpy.types.Operator):
	"""Tooltip"""
	bl_idname = "object.invoke_segfault"
	bl_label = "Invoke"
	bl_options = {'REGISTER', 'UNDO'}

	prop: bpy.props.EnumProperty(name="prop", items=[(c,)*3 for c in "ABC"], default="A")
	prop2: bpy.props.StringProperty(name="prop2", default="value")
	
	def invoke(self, context, event):
		context.window_manager.invoke_props_dialog(self)
		return {'RUNNING_MODAL'}

	def execute(self, context):
		return {'FINISHED'}


class SomeMenu(bpy.types.Menu):
	bl_idname = "TEST_MT_menu"
	bl_label = "InvokeMenu"

	def draw(self, context):
		pass


def register():
	bpy.utils.register_class(InvokeOperator)
	bpy.utils.register_class(SomeMenu)

def unregister():
	bpy.utils.unregister_class(InvokeOperator)
	bpy.utils.unregister_class(SomeMenu)


if __name__ == "__main__":
	register()
	bpy.ops.object.invoke_segfault('INVOKE_DEFAULT')
	unregister()

Here's a somewhat shorter reproducer that triggers invokes the operator and triggers the crash automatically: [InvokeSegfaultB.blend](https://archive.blender.org/developer/F10170017/InvokeSegfaultB.blend) As with before, I could only get it to happen reliably when there's also a menu class that gets (un) regsitered. ``` """Press the Run Script button for a segfault.""" import bpy class InvokeOperator(bpy.types.Operator): """Tooltip""" bl_idname = "object.invoke_segfault" bl_label = "Invoke" bl_options = {'REGISTER', 'UNDO'} prop: bpy.props.EnumProperty(name="prop", items=[(c,)*3 for c in "ABC"], default="A") prop2: bpy.props.StringProperty(name="prop2", default="value") def invoke(self, context, event): context.window_manager.invoke_props_dialog(self) return {'RUNNING_MODAL'} def execute(self, context): return {'FINISHED'} class SomeMenu(bpy.types.Menu): bl_idname = "TEST_MT_menu" bl_label = "InvokeMenu" def draw(self, context): pass def register(): bpy.utils.register_class(InvokeOperator) bpy.utils.register_class(SomeMenu) def unregister(): bpy.utils.unregister_class(InvokeOperator) bpy.utils.unregister_class(SomeMenu) if __name__ == "__main__": register() bpy.ops.object.invoke_segfault('INVOKE_DEFAULT') unregister() ```

Pratik Borhade commented

2021-07-07 12:26:04 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-07-07 12:26:04 +02:00

Can recreate the crash with version 3.0.0 (7af40ccf5f)

 	blender.exe!ui_but_text_password_hide(unsigned char * password_str, uiBut * but, const bool restore) Line 2830
 	blender.exe!widget_draw_text_icon(const uiFontStyle * fstyle, const uiWidgetColors * wcol, uiBut * but, rcti * rect) Line 2360
 	blender.exe!ui_draw_but(const bContext * C, ARegion * region, uiStyle * style, uiBut * but, rcti * rect) Line 4944
 	blender.exe!UI_block_draw(const bContext * C, uiBlock * block) Line 2054
 	blender.exe!ui_block_region_draw(const bContext * C, ARegion * region) Line 410
 	blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 563
 	blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 758
 	blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 867
 	blender.exe!wm_draw_update(bContext * C) Line 1066
 	blender.exe!WM_main(bContext * C) Line 654
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 562

Can recreate the crash with version 3.0.0 (`7af40ccf5f`) ``` blender.exe!RNA_property_subtype(PropertyRNA * prop) Line 1184 blender.exe!ui_but_text_password_hide(unsigned char * password_str, uiBut * but, const bool restore) Line 2830 blender.exe!widget_draw_text_icon(const uiFontStyle * fstyle, const uiWidgetColors * wcol, uiBut * but, rcti * rect) Line 2360 blender.exe!ui_draw_but(const bContext * C, ARegion * region, uiStyle * style, uiBut * but, rcti * rect) Line 4944 blender.exe!UI_block_draw(const bContext * C, uiBlock * block) Line 2054 blender.exe!ui_block_region_draw(const bContext * C, ARegion * region) Line 410 blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 563 blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 758 blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 867 blender.exe!wm_draw_update(bContext * C) Line 1066 blender.exe!WM_main(bContext * C) Line 654 blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 562 ```

Pratik Borhade commented

2021-07-07 12:33:16 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-12-09 11:38:23 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Pratik Borhade commented

2022-12-09 11:38:23 +01:00

@WCN hi, I'm not able to repro the crash anymore. Could you check again in 2.93.11 or any succeeding version?: https://builder.blender.org/download/daily/

Pratik Borhade commented

2022-12-23 05:09:05 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'

Pratik Borhade commented

2022-12-23 05:09:05 +01:00

Sorry, can still confirm the crash

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Segfault on unregistering operator/menu with open props dialog. #89123