Reordering FCurves can cause crash or corruption #89435

New Issue

Frankie Hobbins · 2021-06-25T17:32:57+02:00

Frankie Hobbins commented

2021-06-25 17:32:57 +02:00

System Information
Operating system: Win10
Graphics card: 2080ti

Blender Version
Broken: 2.93
Worked: Never (2.80+)

Short description of error
When moving f curves up and down (changing order) in the dopesheet it can cause an instant crash.

I have recorded a video and attached the blend file. I think it works ok in simple rigs/objects.
SyQtuJ3RwV.mp4

Exact steps for others to reproduce the error

#89435-move-fcurves-crash-mine.blend
Open the above file and try to move a channel (with page up/down keys) to the edge of a channel group. Things will go wrong and channels will disappear.

To reproduce from scratch:

Start Blender with the default scene
Create a keyframe for the location of the cube
Rename the "Object Transforms" channel group to "Other Group" -- name is irrelevant, as long as it's been changed
Create a keyframe for the rotation of the cube
You now have two groups with three animation channels each.
Move a channel in the first group towards the second group, and see how things misbehave.

Original steps to reproduce:

#89435.blend

Open file
In Action Editor click on menu > Channel > Move > Up

Crashes on NULL dereference - group_fcurves_last was NULL

**System Information** Operating system: Win10 Graphics card: 2080ti **Blender Version** Broken: 2.93 Worked: Never (2.80+) **Short description of error** When moving f curves up and down (changing order) in the dopesheet it can cause an instant crash. I have recorded a video and attached the blend file. I think it works ok in simple rigs/objects. [SyQtuJ3RwV.mp4](https://archive.blender.org/developer/F10202267/SyQtuJ3RwV.mp4) **Exact steps for others to reproduce the error** [#89435-move-fcurves-crash-mine.blend](https://archive.blender.org/developer/F10205801/T89435-move-fcurves-crash-mine.blend) Open the above file and try to move a channel (with page up/down keys) to the edge of a channel group. Things will go wrong and channels will disappear. To reproduce from scratch: - Start Blender with the default scene - Create a keyframe for the location of the cube - Rename the "Object Transforms" channel group to "Other Group" -- name is irrelevant, as long as it's been changed - Create a keyframe for the rotation of the cube - You now have two groups with three animation channels each. - Move a channel in the first group towards the second group, and see how things misbehave. **Original steps to reproduce:** [#89435.blend](https://archive.blender.org/developer/F10204667/T89435.blend) - Open file - In Action Editor click on menu > Channel > Move > Up Crashes on NULL dereference - `group_fcurves_last` was NULL

Frankie Hobbins commented

2021-06-25 17:32:57 +02:00

Added subscriber: @FrankieHobbins

Richard Antalik commented

2021-06-25 17:59:20 +02:00

Added subscriber: @iss

Richard Antalik commented

2021-06-25 17:59:20 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Richard Antalik commented

2021-06-25 17:59:20 +02:00

Please click on Help > Save System Info and upload saved file.

This is functionality provided by addon, do you know which addon it is?

Please click on Help > Save System Info and upload saved file. This is functionality provided by addon, do you know which addon it is?

Frankie Hobbins commented

2021-06-25 20:34:35 +02:00

Here is the system info, system-info.txt

are you sure its an addon? I just checked on a clean install and have the options there.

Here is the system info, [system-info.txt](https://archive.blender.org/developer/F10202436/system-info.txt) are you sure its an addon? I just checked on a clean install and have the options there.

Frankie Hobbins commented

2021-06-26 13:55:06 +02:00

here's a link to the blender docs with the command in https://docs.blender.org/api/2.93/bpy.ops.anim.html#bpy.ops.anim.channels_move

Richard Antalik commented

2021-06-28 12:18:20 +02:00

In #89435#1182854, @FrankieHobbins wrote:
are you sure its an addon? I just checked on a clean install and have the options there.

Sorry I got myself confused, You are correct, this is builtin functionality. I have re-checked this and can't reproduce this bug with file created from scratch. Can you please provide sample .blend file?

On the other hand if you look at the end of provided system-info.txt file you can see that you have quite a few addons enabled which may cause problems like this. So please check if this happens when you click on File > Defaults > Load Factory Settings, open sample file and redo buggy action.

> In #89435#1182854, @FrankieHobbins wrote: > are you sure its an addon? I just checked on a clean install and have the options there. Sorry I got myself confused, You are correct, this is builtin functionality. I have re-checked this and can't reproduce this bug with file created from scratch. Can you please provide sample .blend file? On the other hand if you look at the end of provided `system-info.txt` file you can see that you have quite a few addons enabled which may cause problems like this. So please check if this happens when you click on File > Defaults > Load Factory Settings, open sample file and redo buggy action.

Frankie Hobbins commented

2021-06-28 12:45:26 +02:00

oh no! I forgot to attach the blend file in the initial report. Sorry about that
Here it is; Moving F curves up and down in the dope sheet can cause blender to crash immediately.blend

If I do load factory settings will it override all my pre-sets forever?

oh no! I forgot to attach the blend file in the initial report. Sorry about that Here it is; [Moving F curves up and down in the dope sheet can cause blender to crash immediately.blend](https://archive.blender.org/developer/F10204653/Moving_F_curves_up_and_down_in_the_dope_sheet_can_cause_blender_to_crash_immediately.blend) If I do load factory settings will it override all my pre-sets forever?

Richard Antalik commented

2021-06-28 12:58:25 +02:00

In #89435#1183783, @FrankieHobbins wrote:
If I do load factory settings will it override all my pre-sets forever?

No, it lasts only for session, so when you restert Blender your saved preferences will be used.

But I can reproduce issue with your file, so no addon is involved here.

> In #89435#1183783, @FrankieHobbins wrote: > If I do load factory settings will it override all my pre-sets forever? No, it lasts only for session, so when you restert Blender your saved preferences will be used. But I can reproduce issue with your file, so no addon is involved here.

Richard Antalik commented

2021-06-28 13:03:41 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Richard Antalik commented

2021-06-28 13:04:24 +02:00

Stacktrace:

>	blender.exe!split_groups_action_temp(bAction * act, bActionGroup * tgrp) Line 1275	C

 	blender.exe!rearrange_action_channels(bAnimContext * ac, bAction * act, eRearrangeAnimChan_Mode mode) Line 1380	C
 	blender.exe!animchannels_rearrange_exec(bContext * C, wmOperator * op) Line 1529	C
 	blender.exe!wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1361	C
 	blender.exe!wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const short context, const bool poll_only, wmEvent * event) Line
 1556	C
 	blender.exe!WM_operator_name_call_ptr(bContext * C, wmOperatorType * ot, short context, PointerRNA * properties) Line 1605	C
 	blender.exe!ui_apply_but_funcs_after(bContext * C) Line 959	C
 	blender.exe!ui_handler_region_menu(bContext * C, const wmEvent * event, void * UNUSED_userdata) Line 11038	C
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Line 692	C
 	blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2841	C
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2957	C
 	blender.exe!wm_event_do_handlers(bContext * C) Line 3377	C
 	blender.exe!WM_main(bContext * C) Line 650	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 562	C
 	[External Code]

Stacktrace: ``` > blender.exe!split_groups_action_temp(bAction * act, bActionGroup * tgrp) Line 1275 C blender.exe!rearrange_action_channels(bAnimContext * ac, bAction * act, eRearrangeAnimChan_Mode mode) Line 1380 C blender.exe!animchannels_rearrange_exec(bContext * C, wmOperator * op) Line 1529 C blender.exe!wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1361 C blender.exe!wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const short context, const bool poll_only, wmEvent * event) Line 1556 C blender.exe!WM_operator_name_call_ptr(bContext * C, wmOperatorType * ot, short context, PointerRNA * properties) Line 1605 C blender.exe!ui_apply_but_funcs_after(bContext * C) Line 959 C blender.exe!ui_handler_region_menu(bContext * C, const wmEvent * event, void * UNUSED_userdata) Line 11038 C blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Line 692 C blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2841 C blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2957 C blender.exe!wm_event_do_handlers(bContext * C) Line 3377 C blender.exe!WM_main(bContext * C) Line 650 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 562 C [External Code] ```

Sybren A. Stüvel commented

2021-06-29 19:20:16 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2021-06-29 19:20:16 +02:00

This is probably caused by 8c74c35ecb, as that also introduces issues with a simpler file:

#89435-move-fcurves-crash-mine.blend

This is probably caused by 8c74c35ecb, as that also introduces issues with a simpler file: [#89435-move-fcurves-crash-mine.blend](https://archive.blender.org/developer/F10205801/T89435-move-fcurves-crash-mine.blend)

Philipp Oeser commented

2021-07-05 09:50:53 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-07-05 09:50:53 +02:00

@dr.sybren: I think the behavior was present before, but 8c74c35ecb made it so it crashes when moving up/down twice

@dr.sybren: I think the behavior was present before, but 8c74c35ecb made it so it crashes when moving up/down twice

Sybren A. Stüvel self-assigned this 2021-07-05 12:08:05 +02:00

Sybren A. Stüvel changed title from ~~Moving F curves up and down in the dope sheet can cause blender to crash immediately~~ to Reordering FCurves can cause crash or corruption

2021-07-05 15:29:00 +02:00

blender-admin commented

2021-07-06 14:36:27 +02:00

This issue was referenced by c04cceb40e

This issue was referenced by c04cceb40ed5574dcba8a55cfe97a1132c869895

Alexander Gavrilov commented

2021-07-09 11:22:12 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Alexander Gavrilov closed this issue

2021-07-09 11:22:12 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Reordering FCurves can cause crash or corruption #89435