UILayout.emboss missing UI_EMBOSS_NONE_OR_STATUS #89891

New Issue

Mikhail Rachinskiy · 2021-07-16T06:13:32+02:00

2021-07-16 06:13:32 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 860M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-15 20:23, hash: 98c4224ff0
Worked: 2.93 release and earlier revisions of 3.0

Short description of error
UI_EMBOSS_NONE_OR_STATUS missing from UILayout.emboss. There is new NONE_OR_STATUS, but it does not work the same.

Here is the difference:

UI_EMBOSS_NONE_OR_STATUS in Blender 2.93 makes emboss look None, but keeping UI active.
NONE_OR_STATUS in Blender 3.0 makes emboss None and UI not active.

emboss.mp4

Exact steps for others to reproduce the error

Run script from attached blend file in 3.0 and 2.93 versions.
Try to interact with popover elements.

emboss.blend

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 860M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-15 20:23, hash: `98c4224ff0` Worked: 2.93 release and earlier revisions of 3.0 **Short description of error** `UI_EMBOSS_NONE_OR_STATUS` missing from `UILayout.emboss`. There is new `NONE_OR_STATUS`, but it does not work the same. Here is the difference: * `UI_EMBOSS_NONE_OR_STATUS` in Blender 2.93 makes emboss look `None`, but keeping UI active. * `NONE_OR_STATUS` in Blender 3.0 makes emboss `None` and UI not active. [emboss.mp4](https://archive.blender.org/developer/F10225662/emboss.mp4) **Exact steps for others to reproduce the error** - Run script from attached blend file in 3.0 and 2.93 versions. - Try to interact with popover elements. [emboss.blend](https://archive.blender.org/developer/F10225664/emboss.blend)

Mikhail Rachinskiy commented

2021-07-16 06:13:32 +02:00

Added subscriber: @MikhailRachinskiy

Hans Goudey self-assigned this 2021-07-16 06:53:50 +02:00

Pratik Borhade commented

2021-07-16 12:05:53 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2021-07-16 12:05:59 +02:00

Added subscriber: @PratikPB2123

Hans Goudey commented

2021-08-02 22:28:58 +02:00

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Hans Goudey commented

2021-08-02 22:28:58 +02:00

Added subscriber: @JulianEisel

Hans Goudey commented

2021-08-02 22:28:58 +02:00

Okay, this is a little more interesting (less straightforward) than I expected. It seems, in adding the "NONE_OR_STATUS" item here we actually added a feature, the ability to edit text with no emboss.
That's because we treated them differently in just the right way to allow that, though it wasn't really purposeful.

In fixing a related bug, c0fb8375f6 also made that impossible again. That's sort of too bad, since it's nice to have that option.
I wish I understood this code a bit better, I find it hard to reason about even on a design level though-- what do we even want it to do?

@JulianEisel Do you have a thought here?

Okay, this is a little more interesting (less straightforward) than I expected. It seems, in adding the "NONE_OR_STATUS" item here we actually added a feature, the ability to edit text with no emboss. That's because we treated them differently in just the right way to allow that, though it wasn't really purposeful. In fixing a related bug, c0fb8375f6 also made that impossible again. That's sort of too bad, since it's nice to have that option. I wish I understood this code a bit better, I find it hard to reason about even on a design level though-- what do we even want it to do? @JulianEisel Do you have a thought here?

Mikhail Rachinskiy commented

2021-08-06 13:37:06 +02:00

New value can be introduced NONE_OR_ACTIVE, it will behave exactly like UI_EMBOSS_NONE_OR_STATUS in 2.93.
This solves current issue and keeps existing code working.

New value can be introduced `NONE_OR_ACTIVE`, it will behave exactly like `UI_EMBOSS_NONE_OR_STATUS` in 2.93. This solves current issue and keeps existing code working.

Julian Eisel commented

2021-09-20 11:32:27 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Needs User Info'

Julian Eisel commented

2021-09-20 11:32:27 +02:00

The fact that this worked before wasn't intentional, and I'm reluctant to adding this kind of behavior back. If I may say so, I don't think what I see in the video above is a good UI pattern at all :) Can you show us a real world example where you'd want to use this?

Mikhail Rachinskiy commented

2021-09-20 13:02:51 +02:00

I use it in my materials library popup, where I wanted to make it look similar to presets, but have functionality of UI list.

Materials Library.mp4

I use it in my materials library popup, where I wanted to make it look similar to presets, but have functionality of UI list. [Materials Library.mp4](https://archive.blender.org/developer/F10512284/Materials_Library.mp4)

Aaron Carlisle commented

2021-09-28 04:49:58 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Mikhail Rachinskiy commented

2021-10-14 18:42:06 +02:00

Here is example of Blender UI where it is following the same principle of emboss-less look, with active highlight to indicate interactable elements.

You already allow it in various places in Blender, I don't see any reason to be extra selective now in this particular case.

Sidebar collections.mp4

Here is example of Blender UI where it is following the same principle of emboss-less look, with active highlight to indicate interactable elements. You already allow it in various places in Blender, I don't see any reason to be extra selective now in this particular case. [Sidebar collections.mp4](https://archive.blender.org/developer/F11102176/Sidebar_collections.mp4)

Philipp Oeser commented

2022-02-16 12:40:53 +01:00

Added subscriber: @lichtwerk