Weird group/collection collapsing behaviour #90038

New Issue

Adrian · 2021-07-22T08:39:32+02:00

Adrian commented

2021-07-22 08:39:32 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3070 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.89

Blender Version
Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: 84da05a8b8

Short description of error
This is my scene hierarchy:

When you left-click on the arrow next to Collection 1 you collapse the hierarchy beneath it, but when you shift left-click on the arrow you open the full hierarchy beneath it, even though the arrow always works like a toggle, but not in this case. You can only shift left-click on an fully opened hierarchy to collapse it. Quite unintuitive , isn’t it?

Exact steps for others to reproduce the error

Create a cube
Create a collection
parent the cube under the collection, so it looks like the screenshot
Shift-left-click on the arrow next to the collection
weirdCollapsingBehaviour.blend

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3070 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.89 **Blender Version** Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: `84da05a8b8` **Short description of error** This is my scene hierarchy: ![58f9ec068382c3a234976963274f3c6a.jpeg](https://archive.blender.org/developer/F10233311/58f9ec068382c3a234976963274f3c6a.jpeg) When you left-click on the arrow next to Collection 1 you collapse the hierarchy beneath it, but when you shift left-click on the arrow you open the full hierarchy beneath it, even though the arrow always works like a toggle, but not in this case. You can only shift left-click on an fully opened hierarchy to collapse it. Quite unintuitive , isn’t it? **Exact steps for others to reproduce the error** 1. Create a cube 2. Create a collection 3. parent the cube under the collection, so it looks like the screenshot 4. Shift-left-click on the arrow next to the collection [weirdCollapsingBehaviour.blend](https://archive.blender.org/developer/F10233320/weirdCollapsingBehaviour.blend)

Adrian commented

2021-07-22 08:39:32 +02:00

Added subscriber: @LalaGhost

Pratik Borhade commented

2021-07-22 10:15:12 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-07-22 10:15:12 +02:00

Thanks for the report. I think this is expected.

Shift + LMB will expand all the data blocks of the parent. So in following case it will first expand all child data blocks of Cube then on another attempt it will collapse the list.

(Will check the code to confirm if this is intentional)

Thanks for the report. I think this is expected. `Shift + LMB` will expand all the data blocks of the parent. So in following case it will first expand all child data blocks of Cube then on another attempt it will collapse the list. (Will check the code to confirm if this is intentional)

Pratik Borhade commented

2021-07-22 12:01:58 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Pratik Borhade closed this issue

2021-07-22 12:01:58 +02:00

Pratik Borhade commented

2021-07-22 12:01:58 +02:00

Looked at the code. Can say this is expected.

Present logic checks if flag TSE_CLOSED is set or not for every element present in the outliner. If at least one parent data block has the flag value set then all the unexpanded data block will expand.

If not a single element has TSE_CLOSED flag set then function outliner_flag_is_any_test will return 0 to unset the flag TSE_CLOSED. Which means the list will collapse.

In other words, list will expand even if the single Parent block is not expanded.

I will close the report since this is expected. Feel free to comment if reported problem is different than what I consider.

(Developers can correct if commented explanation is wrong)

Looked at the code. Can say this is expected. Present logic checks if flag `TSE_CLOSED` is set or not for every element present in the outliner. If at least one parent data block has the flag value set then all the unexpanded data block will expand. If not a single element has `TSE_CLOSED` flag set then function `outliner_flag_is_any_test` will return 0 to unset the flag `TSE_CLOSED`. Which means the list will collapse. In other words, list will expand even if the single Parent block is not expanded. I will close the report since this is expected. Feel free to comment if reported problem is different than what I consider. (Developers can correct if commented explanation is wrong)

Adrian commented

2021-07-22 12:12:55 +02:00

It is rather that this behaviour is unintuitive rather than "wrong" on a code level.
Since a LMB works as a toggle on the arrows wouldn't it make more sense that the Shift + LMB works as a toggle, too?

Proposal:

Case:
Hierarchy is collapsed completely, arrow of parent is pointing to the right
Shift + LMB on the arrow of the parent expands the hierarchy and all its childrens hierarchy
Case:
Hierarchy is expanded completely, arrow is pointing to the bottom, as well for all children
Shift + LMB on the arrow of the parent collapses the hierarchy, so that the children are hierarchely hidden
Case:
Hierarchy is expanded partially, arrow of parent is pointing to the bottom, but childrens arrow point to the right
Shift + LMB on the arrow of the parent collapses the hierarchy, so that the children are hierarchely hidden
The third case is the only difference to the current behaviour and would underline the toggle nature of the clicks on the arrows

It is rather that this behaviour is unintuitive rather than "wrong" on a code level. Since a LMB works as a toggle on the arrows wouldn't it make more sense that the Shift + LMB works as a toggle, too? **Proposal:** 1. Case: Hierarchy is collapsed completely, arrow of parent is pointing to the right Shift + LMB on the arrow of the parent expands the hierarchy and all its childrens hierarchy 2. Case: Hierarchy is expanded completely, arrow is pointing to the bottom, as well for all children Shift + LMB on the arrow of the parent collapses the hierarchy, so that the children are hierarchely hidden 3. Case: Hierarchy is expanded partially, arrow of parent is pointing to the bottom, but childrens arrow point to the right Shift + LMB on the arrow of the parent collapses the hierarchy, so that the children are hierarchely hidden The third case is the only difference to the current behaviour and would underline the toggle nature of the clicks on the arrows

Adrian commented

2021-07-27 13:32:20 +02:00

In #90038#1194689, @PratikPB2123 wrote:
Looked at the code. Can say this is expected.

Present logic checks if flag TSE_CLOSED is set or not for every element present in the outliner. If at least one parent data block has the flag value set then all the unexpanded data block will expand.

If not a single element has TSE_CLOSED flag set then function outliner_flag_is_any_test will return 0 to unset the flag TSE_CLOSED. Which means the list will collapse.

In other words, list will expand even if the single Parent block is not expanded.

I will close the report since this is expected. Feel free to comment if reported problem is different than what I consider.

(Developers can correct if commented explanation is wrong)

Why was this closed?

> In #90038#1194689, @PratikPB2123 wrote: > Looked at the code. Can say this is expected. > > Present logic checks if flag `TSE_CLOSED` is set or not for every element present in the outliner. If at least one parent data block has the flag value set then all the unexpanded data block will expand. > > If not a single element has `TSE_CLOSED` flag set then function `outliner_flag_is_any_test` will return 0 to unset the flag `TSE_CLOSED`. Which means the list will collapse. > > In other words, list will expand even if the single Parent block is not expanded. > > I will close the report since this is expected. Feel free to comment if reported problem is different than what I consider. > > (Developers can correct if commented explanation is wrong) Why was this closed?

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Weird group/collection collapsing behaviour #90038