Case-insensitivity of catalog IDs #90541

New Issue

Sybren A. Stüvel · 2021-08-09T13:09:29+02:00

Sybren A. Stüvel commented

2021-08-09 13:09:29 +02:00

Catalog IDs are intended to be simple, human-readable identifiers for a node in the catalog tree. For simpicity I think it's a good idea to have these case-insensitive.

A few options for technical implementations:

Always store catalog IDs as input by the user (and compare both sides of a comparison to lower case every time), or
always store catalog IDs as lower/upper case (and thus always compare the same case without having to do lowercasing every time).

I'm in favour of the first one, as that gives the most flexibility to artists.

Catalog IDs are intended to be simple, human-readable identifiers for a node in the catalog tree. For simpicity I think it's a good idea to have these case-insensitive. A few options for technical implementations: - Always store catalog IDs as input by the user (and compare both sides of a comparison to lower case every time), or - always store catalog IDs as lower/upper case (and thus always compare the same case without having to do lowercasing every time). I'm in favour of the first one, as that gives the most flexibility to artists.

Sybren A. Stüvel commented

2021-08-09 13:09:29 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel commented

2021-08-09 13:09:29 +02:00

Added subscriber: @dr.sybren

Antonio Vazquez commented

2021-08-09 13:14:20 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2021-08-09 13:14:20 +02:00

As a Windows user, for me is more logic the Case Insensitivity. I know in Linux case matters, but in windows don't.

Sybren A. Stüvel commented

2021-08-09 13:34:55 +02:00

@antoniov You make a good point. In Windows you can't reliably change the case of a filename (so thename.txt → TheName.txt); it might error out saying "This file already exists". This is something I want to avoid. My perspective on this is that people are intrinsically case-sensitive, they just don't want to care about it.

@antoniov You make a good point. In Windows you can't reliably change the case of a filename (so `thename.txt` → `TheName.txt`); it might error out saying "This file already exists". This is something I want to avoid. My perspective on this is that people are intrinsically case-sensitive, they just don't want to care about it.

Jeroen Bakker commented

2021-08-09 13:54:28 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2021-08-09 13:54:28 +02:00

I would keep the casing to what the user entered. This will keep it readable when using pascal casing for example. And just convert to one casing when checking.

Julian Eisel commented

2021-08-09 14:21:42 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2021-08-09 14:21:42 +02:00

The catalog name that is displayed in the UI should use whatever case the user entered. E.g. entering "AbC DeF" should display the exact same way. When renaming it to "Abc Def" that should just work.
For comparisons and for writing the CATALOG_ID to the catalog definition files, it can just be converted to a lower-case format, e.g. abc-def. Or at least the case shouldn't matter for internal logic.

The catalog name that is displayed in the UI should use whatever case the user entered. E.g. entering "AbC DeF" should display the exact same way. When renaming it to "Abc Def" that should just work. For comparisons and for writing the `CATALOG_ID` to the catalog definition files, it can just be converted to a lower-case format, e.g. `abc-def`. Or at least the case shouldn't matter for internal logic.

Antonio Vazquez commented

2021-08-09 15:26:24 +02:00

I agree to keep case typed by user... I'm talking only internally for checking.

Antonio Vazquez commented

2021-08-12 10:23:52 +02:00

Maybe is something that never happens in these programming languages, but I had in the past some problems changing/comparing case in databases with different languages (character sets)...specially when using non Western Languages. I mean, for example, saving a catalog in a Russian system and open it in a Spanish one. I write this note to be sure we test that.

Julian Eisel commented

2021-09-16 12:01:01 +02:00

Changed status from 'Confirmed' to: 'Archived'

Julian Eisel closed this issue

2021-09-16 12:01:01 +02:00

Julian Eisel commented

2021-09-16 12:01:01 +02:00

Closing this now, since it's become obsolete with #91378 (Use UUIDs for Catalog IDs).

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Case-insensitivity of catalog IDs #90541