bpy.ops.screen.area_join not working anymore #90731

New Issue

Oleg · 2021-08-17T14:10:23+02:00

Oleg commented

2021-08-17 14:10:23 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-16 16:57, hash: 4dba206011
Worked: 2.93.3 Release Candidate, branch: master, commit date: 2021-08-12 15:05, hash: 1eeae9be15

Short description of error
It seems that area_join operator no longer working after adding new join behavior.

Exact steps for others to reproduce the error

Open Scripting tab
Run following command and press "T" to refresh the area

bpy.ops.screen.area_join(cursor=(C.area.x, C.area.y + C.area.height))

Expected result - Python Console should joint into View 3D area

2.93.3	3.0
Blender 2021-08-18 10-20-29.mp4	Blender 2021-08-18 10-18-09.mp4

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-16 16:57, hash: `4dba206011` Worked: 2.93.3 Release Candidate, branch: master, commit date: 2021-08-12 15:05, hash: `1eeae9be15` **Short description of error** It seems that area_join operator no longer working after adding new join behavior. **Exact steps for others to reproduce the error** - Open Scripting tab - Run following command and press "T" to refresh the area > bpy.ops.screen.area_join(cursor=(C.area.x, C.area.y + C.area.height)) - Expected result - Python Console should joint into View 3D area --- | 2.93.3 | 3.0 | | -- | -- | | [Blender 2021-08-18 10-20-29.mp4](https://archive.blender.org/developer/F10287145/Blender_2021-08-18_10-20-29.mp4) | [Blender 2021-08-18 10-18-09.mp4](https://archive.blender.org/developer/F10287136/Blender_2021-08-18_10-18-09.mp4) |

👍 1

Oleg commented

2021-08-17 14:10:23 +02:00

Added subscriber: @DotBow

Pratik Borhade commented

2021-08-17 14:51:25 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-08-17 14:52:18 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Harley Acheson commented

2021-08-17 15:39:08 +02:00

Added subscriber: @Harley

Harley Acheson commented

2021-08-17 15:39:08 +02:00

Sorry, but not that familiar with using Python for this, so could you explain a bit better how this worked in earlier versions? Your “cursor” here is specifying a singular location at the top-left of one area. The code there has always started at the cursor location and expanded out to find two areas to join. But it could find 0-4 areas depending on where that point is. So I think you’d also have to pass a join direction for it to know what to do, otherwise how do you specify which area is subsumed by the other?

Oleg commented

2021-08-17 16:52:50 +02:00

In #90731#1207529, @Harley wrote:
Sorry, but not that familiar with using Python for this, so could you explain a bit better how this worked in earlier versions? Your “cursor” here is specifying a singular location at the top-left of one area. The code there has always started at the cursor location and expanded out to find two areas to join. But it could find 0-4 areas depending on where that point is. So I think you’d also have to pass a join direction for it to know what to do, otherwise how do you specify which area is subsumed by the other?

It uses active area as a starting point, so you should only specify a second one using cursor location. It is super weird and unintuitive, but it is what it is...

Here is the doc page:
https://docs.blender.org/api/2.93/bpy.ops.screen.html?highlight=area_join#bpy.ops.screen.area_join

> In #90731#1207529, @Harley wrote: > Sorry, but not that familiar with using Python for this, so could you explain a bit better how this worked in earlier versions? Your “cursor” here is specifying a singular location at the top-left of one area. The code there has always started at the cursor location and expanded out to find two areas to join. But it could find 0-4 areas depending on where that point is. So I think you’d also have to pass a join direction for it to know what to do, otherwise how do you specify which area is subsumed by the other? It uses active area as a starting point, so you should only specify a second one using cursor location. It is super weird and unintuitive, but it is what it is... Here is the doc page: https://docs.blender.org/api/2.93/bpy.ops.screen.html?highlight=area_join#bpy.ops.screen.area_join

Harley Acheson commented

2021-08-17 17:38:36 +02:00

@DotBow - It uses active area as a starting point, so you should only specify a second one using cursor location. It is super weird and unintuitive, but it is what it is...

AFAIK it has always been a bit broken, in that the C source not only requires a point (that can be used to locate multiple area neighbors) but also a direction to merge from and to. When called from python the only parameter is that cursor location which isn't enough to do so. When running your example in 2.93 it closes Console (but only seen after forcing a screen draw) and I can't see how you could merge in a different direction.

I think the only real way to fix area_join for python is to add a "Direction" property so in your example you'd also supply a direction='South' (or similar) and could use 'North" top merge Console into 3DView. Or obviously you could use a cursor location at Console right edge and "East" to merge Control into the text editor area. Sound Reasonable?

> @DotBow - It uses active area as a starting point, so you should only specify a second one using cursor location. It is super weird and unintuitive, but it is what it is... AFAIK it has always been a bit broken, in that the C source not only requires a point (that can be used to locate multiple area neighbors) but also a direction to merge from and to. When called from python the only parameter is that cursor location which isn't enough to do so. When running your example in 2.93 it closes Console (but only seen after forcing a screen draw) and I can't see how you could merge in a different direction. I think the only real way to fix area_join for python is to add a "Direction" property so in your example you'd also supply a direction='South' (or similar) and could use 'North" top merge Console into 3DView. Or obviously you could use a cursor location at Console right edge and "East" to merge Control into the text editor area. Sound Reasonable?

Oleg commented

2021-08-17 18:10:51 +02:00

@Harley yes, that's true - there is no way to set direction, so the only way I found for my add-on is to swap areas and after join them.
Yes, using area corner position and direction sounds like a great way to improve an operator!

@Harley yes, that's true - there is no way to set direction, so the only way I found for my add-on is to swap areas and after join them. Yes, using area corner position and direction sounds like a great way to improve an operator!

Harley Acheson commented

2021-08-18 17:00:43 +02:00

Interesting is that for both "Join" and new "Close", I'm pretty sure I can get them working as you want from python, except for the specific example you are showing here. So far I'm not finding a way of having Console destroy itself this way without a ton of hurt. I see solutions that will work with all other areas, but not situations where Console (or Text editor running a script) can close themselves. Not sure if that is a major issue though and I can show a nice error message in this situation.

Interesting is that for both "Join" and new "Close", I'm pretty sure I can get them working as you want from python, **except** for the specific example you are showing here. So far I'm not finding a way of having Console destroy *itself* this way without a ton of hurt. I see solutions that will work with all other areas, but not situations where Console (or Text editor running a script) can close themselves. Not sure if that is a major issue though and I can show a nice error message in this situation.

Oleg commented

2021-08-18 18:31:11 +02:00

In #90731#1208042, @Harley wrote:
Interesting is that for both "Join" and new "Close", I'm pretty sure I can get them working as you want from python, except for the specific example you are showing here. So far I'm not finding a way of having Console destroy itself this way without a ton of hurt. I see solutions that will work with all other areas, but not situations where Console (or Text editor running a script) can close themselves. Not sure if that is a major issue though and I can show a nice error message in this situation.

I used it from Console only for quick demonstration purposes, it's not a real life case.

> In #90731#1208042, @Harley wrote: > Interesting is that for both "Join" and new "Close", I'm pretty sure I can get them working as you want from python, **except** for the specific example you are showing here. So far I'm not finding a way of having Console destroy *itself* this way without a ton of hurt. I see solutions that will work with all other areas, but not situations where Console (or Text editor running a script) can close themselves. Not sure if that is a major issue though and I can show a nice error message in this situation. I used it from Console only for quick demonstration purposes, it's not a real life case.

Oleg commented

2021-09-06 22:55:34 +02:00

Using new operator from D12307 works like a charm!
Thanks @Harley !

Using new operator from [D12307](https://archive.blender.org/developer/D12307) works like a charm! Thanks @Harley !

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

bpy.ops.screen.area_join not working anymore #90731