You can copy-paste a collection instance into its source collection (creating recursion) #91128

New Issue

Philipp Oeser · 2021-09-02T15:55:36+02:00

Philipp Oeser commented

2021-09-02 15:55:36 +02:00

System Information
Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.34.9000 64 Bits
Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.31

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-29 21:39, hash: b42354672e
Worked: never

Short description of error
You can copy-paste a collection instance into its source collection (creating recursion)

Exact steps for others to reproduce the error
copy_paste_instance_to_source_collection.blend

open file
{key Ctrl C}
{key Ctrl V}
this will put the instance in its source collection (creating recursion -- which should be avoided)

Dragging and dropping is already prevented in the Outliner.
There is a check in collection_object_add here https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/collection.c$1074
But that fails to detect equality if instance comes from the pastebuffer.

**System Information** Operating system: Linux-5.13.0-0.rc6.45.fc35.x86_64-x86_64-with-glibc2.34.9000 64 Bits Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 465.31 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-29 21:39, hash: `b42354672e` Worked: never **Short description of error** You can copy-paste a collection instance into its source collection (creating recursion) **Exact steps for others to reproduce the error** [copy_paste_instance_to_source_collection.blend](https://archive.blender.org/developer/F10363287/copy_paste_instance_to_source_collection.blend) - open file - {key Ctrl C} - {key Ctrl V} - this will put the instance in its source collection (creating recursion -- which should be avoided) Dragging and dropping is already prevented in the Outliner. There is a check in `collection_object_add` here https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/collection.c$1074 But that fails to detect equality if instance comes from the pastebuffer.

Philipp Oeser commented

2021-09-02 15:55:36 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-09-02 15:55:58 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-09-02 15:55:58 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2021-09-03 12:55:35 +02:00

Changed status from 'Confirmed' to: 'Needs User Info'

Bastien Montagne commented

2021-09-03 12:55:35 +02:00

Am not sure I am following here... AFAIK copy/paste of IDs in 3DView uses temp blend file + append, so it's not pasting the same ID, but a new one (as you can see from the names, Collection.001)...

Am not sure I am following here... AFAIK copy/paste of IDs in 3DView uses temp blend file + append, so it's not pasting the same ID, but a new one (as you can see from the names, `Collection.001`)...

Philipp Oeser commented

2021-09-03 13:54:49 +02:00

Yeah, but you still shouldnt be allowed to put the new ID into its source collection.
Same thing can be done just coping [no copy-paste] the instance (so you get the name Collection.001 also), try drag-dropping that into the collection --> is forbidden.

Yeah, but you still shouldnt be allowed to put the new ID into its source collection. Same thing can be done just coping [no copy-paste] the instance (so you get the name `Collection.001` also), try drag-dropping that into the collection --> is forbidden.

Philipp Oeser commented

2021-09-03 13:55:15 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-09-03 14:16:41 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Archived'

Philipp Oeser closed this issue

2021-09-03 14:16:41 +02:00

Philipp Oeser commented

2021-09-03 14:16:41 +02:00

Ah sorry (not my day today), you are right, this is not the same as duplicating the instance.
And yes, this is not recursion.

Ah sorry (not my day today), you are right, this is not the same as duplicating the instance. And yes, this is not recursion.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

You can copy-paste a collection instance into its source collection (creating recursion) #91128