Custom property settings not preserved when changing its type #91256

New Issue

Demeter Dzadik · 2021-09-08T12:10:27+02:00

Demeter Dzadik commented

2021-09-08 12:10:27 +02:00

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-07 23:23, hash: 7beb4a0e0a

Exact steps for others to reproduce the error

Add integer property to default cube with a custom min/max/default value, and Is Library Overridable enabled.
C.object['prop'] = 2.0
The property's settings are all lost.

IIRC, before the refactor, an integer property could have floats as its min/max so this would be allowed. Might be a bit of a pain point with the new system, but I think doing a best effort conversion between types would be nice when possible (even if some data is lost going from float to int, losing some data is better than losing all data).

#91256-2021-09-08_12.54.49.mp4

Test File:
#91256.blend

**Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-07 23:23, hash: `7beb4a0e0a` **Exact steps for others to reproduce the error** - Add integer property to default cube with a custom min/max/default value, and Is Library Overridable enabled. ![image.png](https://archive.blender.org/developer/F10385321/image.png) - `C.object['prop'] = 2.0` - The property's settings are all lost. ![image.png](https://archive.blender.org/developer/F10385350/image.png) IIRC, before the refactor, an integer property could have floats as its min/max so this would be allowed. Might be a bit of a pain point with the new system, but I think doing a best effort conversion between types would be nice when possible (even if some data is lost going from float to int, losing some data is better than losing all data). [#91256-2021-09-08_12.54.49.mp4](https://archive.blender.org/developer/F10385458/T91256-2021-09-08_12.54.49.mp4) Test File: [#91256.blend](https://archive.blender.org/developer/F10386343/T91256.blend)

Demeter Dzadik commented

2021-09-08 12:10:27 +02:00

Added subscriber: @Mets

Pratik Borhade commented

2021-09-08 12:27:10 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-09-08 12:27:10 +02:00

Broken: version: 3.0.0 Alpha, branch: studio-sprite-fright

Hi @Mets , I am not able to reproduce this on master branch: 7beb4a0e0a49fdee3c4b98bcf9287ab72aaebda5.
May be this happens only on studio-sprite-fright branch?

> Broken: version: 3.0.0 Alpha, branch: studio-sprite-fright Hi @Mets , I am not able to reproduce this on master branch: `7beb4a0e0a49fdee3c4b98bcf9287ab72aaebda5`. May be this happens only on `studio-sprite-fright` branch?

Demeter Dzadik commented

2021-09-08 12:32:45 +02:00

Yep, probably, I suspect somehow our "critical fixes only" branch got branched off just before a bunch of critical fixes got into master, lol. I poked Hans in DM's with the same theory, it's probably gonna be a matter of just pushing a few commits from master to the sprites branch, I hope.

Demeter Dzadik commented

2021-09-08 12:55:46 +02:00

I could reproduce it on the latest master from the buildbot though! #91256-2021-09-08_12.54.49.mp4

I could reproduce it on the latest master from the buildbot though! [#91256-2021-09-08_12.54.49.mp4](https://archive.blender.org/developer/F10385458/T91256-2021-09-08_12.54.49.mp4)

Pratik Borhade commented

2021-09-08 14:02:24 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2021-09-08 22:26:16 +02:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-09-08 22:26:16 +02:00

Thanks for the report. Working with the existing custom property operator was becoming problematic, so I refactored it to have a type drop-down and included the changes you suggest here in that WIP patch: D12435

Thanks for the report. Working with the existing custom property operator was becoming problematic, so I refactored it to have a type drop-down and included the changes you suggest here in that WIP patch: [D12435](https://archive.blender.org/developer/D12435)

blender-admin commented

2021-09-23 04:56:54 +02:00

This issue was referenced by bf948b2cef

This issue was referenced by bf948b2cef3ba340a6bba5e7bd7f4911c9a9275a

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Custom property settings not preserved when changing its type #91256