Selection in the 3d view is broken in build from Xcode 13 #91680

New Issue

William Reynish · 2021-09-24T14:23:08+02:00

William Reynish commented

2021-09-24 14:23:08 +02:00

System Information
Operating system: macOS-11.6-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 5500M OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.6.20

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-24 06:41, hash: fc7beac8d6
Worked: (newest version of Blender that worked as expected)

Short description of error
Using the default keymap, clicking to select items in the 3d view doesn't work

Exact steps for others to reproduce the error

Compile Blender using Clang 13. See #91680#1225851
Open latest master using Factory settings, is Blender Default keymap set to left click select
Click on the default camera or light
Nothing happens

Box select still works, but single clicking is broken. Bug also applies to the IC keymap.

**System Information** Operating system: macOS-11.6-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 5500M OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.6.20 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-09-24 06:41, hash: `fc7beac8d6` Worked: (newest version of Blender that worked as expected) **Short description of error** Using the default keymap, clicking to select items in the 3d view doesn't work **Exact steps for others to reproduce the error** - Compile Blender using Clang 13. See #91680#1225851 - Open latest master using Factory settings, is Blender Default keymap set to left click select - Click on the default camera or light - Nothing happens Box select still works, but single clicking is broken. Bug also applies to the IC keymap.

William Reynish commented

2021-09-24 14:23:08 +02:00

Added subscriber: @WilliamReynish

blender-admin commented

2021-09-24 14:23:08 +02:00

#95464 was marked as duplicate of this issue

blender-admin commented

2021-09-24 14:23:08 +02:00

#94319 was marked as duplicate of this issue

blender-admin commented

2021-09-24 14:23:08 +02:00

#93041 was marked as duplicate of this issue

blender-admin commented

2021-09-24 14:23:08 +02:00

#91772 was marked as duplicate of this issue

William Reynish commented

2021-09-24 14:26:56 +02:00

Seems likely this could have been causes by bffda4185d or d431b91995, or another recent keymap commit?

Seems likely this could have been causes by bffda4185dc7 or d431b91995da, or another recent keymap commit?

Ari Sea commented

2021-09-25 04:49:43 +02:00

Added subscriber: @PhlixFer

Ari Sea commented

2021-09-25 04:49:43 +02:00

I have a very similar problem, though I still can select objects; it's just that the selection "hitbox" is offset from the actual rendered mesh. Strangely, selecting in edit mode still works as expected...
Blender version: 3.0.0 Alpha, branch: master, commit date: 2021-09-24 19:18, hash: a3027fb094

Screen Recording 2021-09-25 at 08.48.48.mov

I have a very similar problem, though I still can select objects; it's just that the selection "hitbox" is offset from the actual rendered mesh. Strangely, selecting in edit mode still works as expected... Blender version: 3.0.0 Alpha, branch: master, commit date: 2021-09-24 19:18, hash: a3027fb09416 [Screen Recording 2021-09-25 at 08.48.48.mov](https://archive.blender.org/developer/F10580668/Screen_Recording_2021-09-25_at_08.48.48.mov)

Michael commented

2021-09-25 19:35:44 +02:00

Added subscriber: @michael64

Michael commented

2021-09-25 19:35:44 +02:00

This bug is likely caused by the architecture independent stage -O2 optimization of the clang version 13 compiler that ships with Xcode 13.

I compiled Blender 2.93.0 with Xcode 13 and the same selection bug appears
so it's not caused by recent Blender source changes.

I compiled the most recent version with Xcode 13 for x86_64 and ran it via Rosatta and the selection bug appears as well so it is not an arm64 architecture issue.

Changing the optimization of only CMAKE_C_FLAGS_RELEASE from -O2 to -O1
in build_files/cmake/platform/platform_apple.cmake and recompiling makes the bug go away.

Bisecting between the optimized and unoptimized binary object files of the Blender I could locate the miscompiled file as source/blender/editors/space_view3d/view3d_view.c.
Leaving CMAKE_C_FLAGS_RELEASE as is at -O2 and adding
"#pragma clang optimize off" allowed narrowing down the miscompiled function to
be view3d_winmatrix_set in view3d_view.c.
This change works for me if you'd like to try:

diff --git a/source/blender/editors/space_view3d/view3d_view.c b/source/blender/editors/space_view3d/view3d_view.c
index f5da7c14a88..c14d521ad6d 100644
--- a/source/blender/editors/space_view3d/view3d_view.c
+++ b/source/blender/editors/space_view3d/view3d_view.c
@@ -699,6 +699,10 @@ void VIEW3D_OT_object_as_camera(wmOperatorType *ot)
 /**
  * \param rect: optional for picking (can be NULL).
  */
+
+#if defined(__clang__) && (__clang_major__ > 12)
+#pragma clang optimize off
+#endif
 void view3d_winmatrix_set(Depsgraph *depsgraph,
                           ARegion *region,
                           const View3D *v3d,
@@ -747,6 +751,9 @@ void view3d_winmatrix_set(Depsgraph *depsgraph,
   /* update matrix in 3d view region */
   GPU_matrix_projection_get(rv3d->winmat);
 }
+#if defined(__clang__) && (__clang_major__ > 12)
+#pragma clang optimize on
+#endif

 static void obmat_to_viewmat(RegionView3D *rv3d, Object *ob)
 {

I am not advocating to commit this patch to fix a compiler bug.
Compiling with Xcode 12.5.1 does not produce this error.
If somebody would like to report this issue with the clang project or file
a radar please do so.

The source of this bug could be found by compiling the Open Source
equivalent of clang-1205.0.22.11 from source then compiling
Blender with this clang and saving
build_darwin_release/source/blender/editors/space_view3d/CMakeFiles/bf_editor_space_view3d.dir/view3d_view.c.o
Compiling clang-1300.0.29.3 from source should result
in the miscompiled view3d_view.c.o.
Bisecting the clang sources and looking for the version
that produces the defective view3d_view.c.o should
give us the clang revision where that introduces the error.
If somebody wants to pinpoint the error in clang please do.
Maybe it is even fixed in the most recent clang development version.
If I am bored next Saturday maybe I'll do this myself.

This bug is likely caused by the architecture independent stage -O2 optimization of the clang version 13 compiler that ships with Xcode 13. I compiled Blender 2.93.0 with Xcode 13 and the same selection bug appears so it's not caused by recent Blender source changes. I compiled the most recent version with Xcode 13 for x86_64 and ran it via Rosatta and the selection bug appears as well so it is not an arm64 architecture issue. Changing the optimization of only CMAKE_C_FLAGS_RELEASE from -O2 to -O1 in build_files/cmake/platform/platform_apple.cmake and recompiling makes the bug go away. Bisecting between the optimized and unoptimized binary object files of the Blender I could locate the miscompiled file as source/blender/editors/space_view3d/view3d_view.c. Leaving CMAKE_C_FLAGS_RELEASE as is at -O2 and adding "#pragma clang optimize off" allowed narrowing down the miscompiled function to be view3d_winmatrix_set in view3d_view.c. This change works for me if you'd like to try: **** ``` diff --git a/source/blender/editors/space_view3d/view3d_view.c b/source/blender/editors/space_view3d/view3d_view.c index f5da7c14a88..c14d521ad6d 100644 --- a/source/blender/editors/space_view3d/view3d_view.c +++ b/source/blender/editors/space_view3d/view3d_view.c @@ -699,6 +699,10 @@ void VIEW3D_OT_object_as_camera(wmOperatorType *ot) /** * \param rect: optional for picking (can be NULL). */ + +#if defined(__clang__) && (__clang_major__ > 12) +#pragma clang optimize off +#endif void view3d_winmatrix_set(Depsgraph *depsgraph, ARegion *region, const View3D *v3d, @@ -747,6 +751,9 @@ void view3d_winmatrix_set(Depsgraph *depsgraph, /* update matrix in 3d view region */ GPU_matrix_projection_get(rv3d->winmat); } +#if defined(__clang__) && (__clang_major__ > 12) +#pragma clang optimize on +#endif static void obmat_to_viewmat(RegionView3D *rv3d, Object *ob) { ``` **** I am not advocating to commit this patch to fix a compiler bug. Compiling with Xcode 12.5.1 does not produce this error. If somebody would like to report this issue with the clang project or file a radar please do so. The source of this bug could be found by compiling the Open Source equivalent of clang-1205.0.22.11 from source then compiling Blender with this clang and saving build_darwin_release/source/blender/editors/space_view3d/CMakeFiles/bf_editor_space_view3d.dir/view3d_view.c.o Compiling clang-1300.0.29.3 from source should result in the miscompiled view3d_view.c.o. Bisecting the clang sources and looking for the version that produces the defective view3d_view.c.o should give us the clang revision where that introduces the error. If somebody wants to pinpoint the error in clang please do. Maybe it is even fixed in the most recent clang development version. If I am bored next Saturday maybe I'll do this myself.

Germano Cavalcante commented

2021-09-27 22:29:18 +02:00

Added subscribers: @ankitm, @mano-wii

Germano Cavalcante commented

2021-09-27 22:29:18 +02:00

From the description this appears to be a serious regression.
So I'm setting it as high priority even though I can't replicate the problem on an Apple M1 with macOS-11.5.2. (At least with a build from the buildbot).

@ankitm, could you confirm this?

@michael64 nice investigation,
if the problem is confirmed on other hardware and new clang development version doesn't solve it, i feel that we may have to apply the workaround for Blender 3.0.

From the description this appears to be a serious regression. So I'm setting it as high priority even though I can't replicate the problem on an `Apple M1` with `macOS-11.5.2`. (At least with a build from the buildbot). @ankitm, could you confirm this? @michael64 nice investigation, if the problem is confirmed on other hardware and new clang development version doesn't solve it, i feel that we may have to apply the workaround for Blender 3.0.

Ankit Meel commented

2021-09-28 06:13:36 +02:00

Cannot redo on downloaded blender c53ffda8a4 Intel i5, Intel HD 6000, macOS 10.14, nor on macOS 11.4, Radeon Pro 5300M.

Cannot redo on downloaded blender c53ffda8a4 Intel i5, Intel HD 6000, macOS 10.14, nor on macOS 11.4, Radeon Pro 5300M.

Pratik Borhade commented

2021-09-28 10:39:04 +02:00

Added subscribers: @Robw, @PratikPB2123

William Reynish commented

2021-09-28 13:09:53 +02:00

Nice find. Indeed, builds from the buildbot appear to work correctly, maybe they are not using Xcode 13?

Germano Cavalcante changed title from ~~Selection in the 3d view is broken~~ to Selection in the 3d view is broken in build from Xcode 13

2021-09-28 14:02:26 +02:00

Michael commented

2021-09-28 15:02:51 +02:00

The buildbot for darwin uses Xcode 12.4 for x86_64 and arm64 at the moment which luckily does not produce the error for the daily build.
One can find the exact compiler and Xcode version in the generated stdout file of the compile-code stage (nr. 6).
The files from a daily build are https://builder.blender.org/admin/#/builders/31/builds/1858/steps/6/logs/stdio (arm64)
and https://builder.blender.org/admin/#/builders/9/builds/1892/steps/6/logs/stdio (x86_64)
A search for "compiler identification" currently yields:

The C compiler identification is AppleClang 12.0.0.12000032
The CXX compiler identification is AppleClang 12.0.0.12000032

A search for "Detected" yields the following:

Detected OS X 11.1 and Xcode 12.4 at /Applications/Xcode.app/Contents/Developer
SDKs Directory: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs
Detected OSX_SYSROOT: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk

The buildbot for darwin uses Xcode 12.4 for x86_64 and arm64 at the moment which luckily does not produce the error for the daily build. One can find the exact compiler and Xcode version in the generated stdout file of the compile-code stage (nr. 6). The files from a daily build are https://builder.blender.org/admin/#/builders/31/builds/1858/steps/6/logs/stdio (arm64) and https://builder.blender.org/admin/#/builders/9/builds/1892/steps/6/logs/stdio (x86_64) A search for "compiler identification" currently yields: - The C compiler identification is AppleClang 12.0.0.12000032 - The CXX compiler identification is AppleClang 12.0.0.12000032 A search for "Detected" yields the following: - Detected OS X 11.1 and Xcode 12.4 at /Applications/Xcode.app/Contents/Developer - SDKs Directory: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs - Detected OSX_SYSROOT: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk

Ankit Meel commented

2021-09-28 17:07:26 +02:00

I compiled with clang+llvm-13.0.0-rc3-x86_64-apple-darwin.tar.xz from LLVM project releases + Xcode 11.3.1 and don't see an error

Ankit Meel commented

2021-09-29 09:27:58 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Ankit Meel commented

2021-09-29 09:27:58 +02:00

Added subscriber: @ponderz

Ankit Meel commented

2021-09-29 09:27:58 +02:00

Confirming due to multiple reports.
Not a high priority IMO since an Xcode minor version upgrade might fix the issue & updating buildbot to Xcode 13 is not imminent. CC @ponderz
For a workaround, download a different Xcode from https://developer.apple.com/download/all/

Confirming due to multiple reports. Not a high priority IMO since an Xcode minor version upgrade might fix the issue & updating buildbot to Xcode 13 is not imminent. CC @ponderz For a workaround, download a different Xcode from https://developer.apple.com/download/all/

Rob van Wees commented

2021-09-30 11:33:43 +02:00

Can confirm, compiling with Xcode 12.5.1 does indeed remove the object selection issue in the 3d view

-- Detected OS X 11.3 and Xcode 12.5.1 at /Applications/Xcode.app/Contents/Developer

Can confirm, compiling with Xcode 12.5.1 does indeed remove the object selection issue in the 3d view ``` -- Detected OS X 11.3 and Xcode 12.5.1 at /Applications/Xcode.app/Contents/Developer ```

Pratik Borhade commented

2021-11-15 11:56:22 +01:00

Added subscriber: @adamhenderson

Charles Wardlaw commented

2021-12-06 18:43:46 +01:00

Added subscriber: @CharlesWardlaw

Charles Wardlaw commented

2021-12-06 18:43:46 +01:00

I was pointed at this ticket by @ankitm in the chat, and just wanted to confirm that I've hit the same issue (XCode 13.1). Going to try reverting.

Guido commented

2021-12-07 14:56:20 +01:00

Added subscriber: @Nurb2Kea

Guido commented

2021-12-07 15:04:27 +01:00

Using terminal with this https://wiki.blender.org/wiki/Building_Blender/Mac guide, always ends up without the ability to select.
I can't select the objet left, right, top, aside and direct. BUT I can select it when selecting it underneath itself.
Feels like that everything is abobe 0 can't be selected and vice versa.

macos 12.0.1, up to date brew, tried xcode 13.0 -13.1 used with blender builds 3.0 and 3.1

Using terminal with this https://wiki.blender.org/wiki/Building_Blender/Mac guide, always ends up without the ability to select. I can't select the objet left, right, top, aside and direct. BUT I can select it when selecting it underneath itself. Feels like that everything is abobe 0 can't be selected and vice versa. macos 12.0.1, up to date brew, tried xcode 13.0 -13.1 used with blender builds 3.0 and 3.1

Charles Wardlaw commented

2021-12-07 15:22:47 +01:00

So after a long bit of downloading, unpacking, and experimenting: it's not possible on macOS 12 to revert to an earlier Xcode. =/ The command-line tools similarly will not install, claiming the OS to be "too new."

My next trick is to attempt a build with homebrew llvm@12, but the first attempts at that yesterday were disastrous.

So after a long bit of downloading, unpacking, and experimenting: it's not possible on macOS 12 to revert to an earlier Xcode. =/ The command-line tools similarly will not install, claiming the OS to be "too new." My next trick is to attempt a build with homebrew llvm@12, but the first attempts at that yesterday were disastrous.

Ankit Meel commented

2021-12-07 16:37:32 +01:00

@CharlesWardlaw See D12210: Use LLVM toolchain to get std::filesystem on how to use LLVM toolchain.

or if you don't want to modify source code, follow the steps to create toolchain and then use https://developer.blender.org/F9413084 with modifications for your system.

Tagging eevee & Viewport for an investigation in case our code is at fault.

@CharlesWardlaw See [D12210: Use LLVM toolchain to get std::filesystem](https://archive.blender.org/developer/D12210) on how to use LLVM toolchain. or if you don't want to modify source code, follow the steps to create toolchain and then use https://developer.blender.org/F9413084 with modifications for your system. Tagging eevee & Viewport for an investigation in case our code is at fault.

Aled Brown commented

2021-12-07 17:00:12 +01:00

Added subscriber: @AledBrown

Steve Hanff commented

2021-12-07 19:25:20 +01:00

Added subscriber: @Steve-Hanff

blender-admin commented

2021-12-08 15:40:09 +01:00

This issue was referenced by 8ca4d20878

This issue was referenced by 8ca4d208783399ec7bc49587c82e306104d928f9

blender-admin commented

2021-12-08 15:40:09 +01:00

This issue was referenced by 98bb8e6955

This issue was referenced by 98bb8e6955b12a97dcded315bab68bd9d3310d29

blender-admin commented

2021-12-08 15:40:09 +01:00

This issue was referenced by 39ebb8be4d

This issue was referenced by 39ebb8be4d5916a71e012ac339b029641b31f10b

blender-admin commented

2021-12-08 15:40:09 +01:00

This issue was referenced by 22cf8b9532

This issue was referenced by 22cf8b9532568ee47ef1c6b7bd60bf9e8a50b508

Brecht Van Lommel commented

2021-12-08 15:45:51 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue

2021-12-08 15:45:51 +01:00

Brecht Van Lommel self-assigned this 2021-12-08 15:45:51 +01:00

Brecht Van Lommel commented

2021-12-08 15:49:35 +01:00

I commit a workaround now, thanks @michael64 for tracking down the cause.

Also backported to 2.83, 2.93, and put on the list for a potential 3.0.1.

I commit a workaround now, thanks @michael64 for tracking down the cause. Also backported to 2.83, 2.93, and put on the list for a potential 3.0.1.

Guido commented

2021-12-08 22:06:02 +01:00

Here is the terminal log from compiling blender on macos 12.0.1 Intel and Terminal and Xcode 13.1 with this guide https://wiki.blender.org/wiki/Building_Blender/Mac

When searching this log for 'warning:' you will find a lot. Not sure if that is right/supposed to be like that!?

The log is log, so juat search for 'warning:'
This is just for info on my/user side compiling.

Thanks in advance

compile log blender 7 dec 2021.txt

Here is the terminal log from compiling blender on macos 12.0.1 Intel and Terminal and Xcode 13.1 with this guide https://wiki.blender.org/wiki/Building_Blender/Mac When searching this log for 'warning:' you will find a lot. Not sure if that is right/supposed to be like that!? The log is log, so juat search for 'warning:' This is just for info on my/user side compiling. Thanks in advance [compile log blender 7 dec 2021.txt](https://archive.blender.org/developer/F12713072/compile_log_blender_7_dec_2021.txt)

Brecht Van Lommel commented

2021-12-08 22:16:52 +01:00

You can ignore the warnings, that's expected.

Though I'm not sure why that is relevant to this task, are you saying the problem still exists with the very latest master for you, or is it just an unrelated question?

You can ignore the warnings, that's expected. Though I'm not sure why that is relevant to this task, are you saying the problem still exists with the very latest master for you, or is it just an unrelated question?

Guido commented

2021-12-08 23:48:37 +01:00

This was a related question. I thought maybe the warnings coming up because of a misconfig of my workflow.
I just compiled it, and it works fine now. THX Brecht :-)

This was a related question. I thought maybe the warnings coming up because of a misconfig of my workflow. I just compiled it, and it works fine now. THX Brecht :-)

Guido commented

2021-12-14 18:58:20 +01:00

Just for Information on todays macos updates:

I updated to macOS 12.1, xcode 13.2 and brew. Two files where missing, but after new cloning into blender-git folder compiling went fine and all working. Even the former selecting issue.
xcode had to be installed manually because of an apple appstore issue.

Anyways it all works, here the files listed that where missing after only updating the OS and xcode and not blender-git folder.(Part of the log::)

In file included from /Users/NURB/blender-git/blender/extern/audaspace/plugins/openal/OpenALDevice.cpp:17:
/Users/NURB/blender-git/blender/extern/audaspace/plugins/openal/OpenALDevice.h:36:10: fatal error: 'al.h' file not found

include <al.h>

       ^~~~~~

[ 19%] Building CXX object extern/audaspace/CMakeFiles/audaspace.dir/plugins/openal/OpenALReader.cpp.o
In file included from /Users/NURB/blender-git/blender/extern/audaspace/plugins/openal/OpenALReader.cpp:17:
/Users/NURB/blender-git/blender/extern/audaspace/plugins/openal/OpenALReader.h:31:10: fatal error: 'alc.h' file not found

include <alc.h>

       ^~~~~~~

[ 19%] Building CXX object extern/bullet2/CMakeFiles/extern_bullet.dir/src/LinearMath/btGeometryUtil.cpp.o
1 error generated.
make- [x]: *** [extern/audaspace/CMakeFiles/audaspace.dir/plugins/openal/OpenALDevice.cpp.o] Error 1
make- [x]: *** Waiting for unfinished jobs....
1 error generated.

[ 21%] Built target extern_ceres
make- [x]: *** [all] Error 2
make: *** [all] Error 2

Just for Information on todays macos updates: I updated to macOS 12.1, xcode 13.2 and brew. Two files where missing, but after new cloning into blender-git folder compiling went fine and all working. Even the former selecting issue. xcode had to be installed manually because of an apple appstore issue. Anyways it all works, here the files listed that where missing after only updating the OS and xcode and not blender-git folder.(Part of the log::) In file included from /Users/NURB/blender-git/blender/extern/audaspace/plugins/openal/OpenALDevice.cpp:17: /Users/NURB/blender-git/blender/extern/audaspace/plugins/openal/OpenALDevice.h:36:10: fatal error: 'al.h' file not found # include <al.h> ``` ^~~~~~ ``` [ 19%] Building CXX object extern/audaspace/CMakeFiles/audaspace.dir/plugins/openal/OpenALReader.cpp.o In file included from /Users/NURB/blender-git/blender/extern/audaspace/plugins/openal/OpenALReader.cpp:17: /Users/NURB/blender-git/blender/extern/audaspace/plugins/openal/OpenALReader.h:31:10: fatal error: 'alc.h' file not found # include <alc.h> ``` ^~~~~~~ ``` [ 19%] Building CXX object extern/bullet2/CMakeFiles/extern_bullet.dir/src/LinearMath/btGeometryUtil.cpp.o 1 error generated. make- [x]: *** [extern/audaspace/CMakeFiles/audaspace.dir/plugins/openal/OpenALDevice.cpp.o] Error 1 make- [x]: *** Waiting for unfinished jobs.... 1 error generated. [ 21%] Built target extern_ceres make- [x]: *** [all] Error 2 make: *** [all] Error 2

Ankit Meel commented

2021-12-14 19:19:17 +01:00

@Nurb2Kea please post build issues at https://devtalk.blender.org/c/blender/building-blender/11