Crash when renaming bone if parented to curve #92083

Closed
opened 2021-10-10 10:19:30 +02:00 by Keen Foong · 9 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.41

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-10-09 19:40, hash: 79425ed326
Worked: 2.93.4, branch: master, commit date: 2021-08-31 09:23, hash: b7205031ce

Short description of error
When attempting to rename a bone, Blender crashes if it has been parented to a curve through the armature modifier.

Exact steps for others to reproduce the error
CoGPdKSp4O.gif
renamebonecrash1.blend

  1. Ctrl-P to parent nurbs path to armature
  2. Rename any bone

In the gif I've set it to envelope but it doesn't need to be, just for display purposes only.

Tested on a version of 2.93 and it works there.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.41 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-10-09 19:40, hash: `79425ed326` Worked: 2.93.4, branch: master, commit date: 2021-08-31 09:23, hash: `b7205031ce` **Short description of error** When attempting to rename a bone, Blender crashes if it has been parented to a curve through the armature modifier. **Exact steps for others to reproduce the error** ![CoGPdKSp4O.gif](https://archive.blender.org/developer/F10929529/CoGPdKSp4O.gif) [renamebonecrash1.blend](https://archive.blender.org/developer/F10929473/renamebonecrash1.blend) 1. Ctrl-P to parent nurbs path to armature 2. Rename any bone In the gif I've set it to envelope but it doesn't need to be, just for display purposes only. Tested on a version of 2.93 and it works there.
Author

Added subscriber: @kfoong

Added subscriber: @kfoong
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Hi, thanks for the report. Can reproduce on master

blender.exe         :0x00007FF6617D0BA0  BLI_findstring C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\listbase.c:667
blender.exe         :0x00007FF6612CB070  ED_armature_bone_rename C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\armature\armature_naming.c:270
blender.exe         :0x00007FF6611AFAE0  PoseBone_name_set C:\Users\Pratik\Desktop\BlenderOSP\2019_lite_ninja\source\blender\makesrna\intern\rna_pose_gen.c:718
blender.exe         :0x00007FF661163E20  RNA_property_string_set C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\makesrna\intern\rna_access.c:3320
blender.exe         :0x00007FF660E0BBF0  ui_but_string_set C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface.c:3167
blender.exe         :0x00007FF660E22E90  ui_apply_but_TEX C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:1222
blender.exe         :0x00007FF660E225C0  ui_apply_but C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:2315
blender.exe         :0x00007FF660E210A0  button_activate_exit C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:8598
blender.exe         :0x00007FF660E2B4D0  ui_handle_button_event C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:9410
blender.exe         :0x00007FF660E2C2A0  ui_handle_menu_button C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:10140
blender.exe         :0x00007FF660E2C430  ui_handle_menu_event C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:10778
blender.exe         :0x00007FF660E2D450  ui_handle_menus_recursive C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:11280
blender.exe         :0x00007FF660E31F60  ui_popup_handler C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:11495
blender.exe         :0x00007FF660B82620  wm_handlers_do_intern C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3048
blender.exe         :0x00007FF660B81C90  wm_handlers_do C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3167
blender.exe         :0x00007FF660B7F090  wm_event_do_handlers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3661
blender.exe         :0x00007FF660B697C0  WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:650
blender.exe         :0x00007FF660B64FC0  main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:563
blender.exe         :0x00007FF6618C73A8  __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
KERNEL32.DLL        :0x00007FFA55A87020  BaseThreadInitThunk
ntdll.dll           :0x00007FFA572E2630  RtlUserThreadStart```
Hi, thanks for the report. Can reproduce on master ```lines blender.exe :0x00007FF6617D0BA0 BLI_findstring C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\listbase.c:667 blender.exe :0x00007FF6612CB070 ED_armature_bone_rename C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\armature\armature_naming.c:270 blender.exe :0x00007FF6611AFAE0 PoseBone_name_set C:\Users\Pratik\Desktop\BlenderOSP\2019_lite_ninja\source\blender\makesrna\intern\rna_pose_gen.c:718 blender.exe :0x00007FF661163E20 RNA_property_string_set C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\makesrna\intern\rna_access.c:3320 blender.exe :0x00007FF660E0BBF0 ui_but_string_set C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface.c:3167 blender.exe :0x00007FF660E22E90 ui_apply_but_TEX C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:1222 blender.exe :0x00007FF660E225C0 ui_apply_but C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:2315 blender.exe :0x00007FF660E210A0 button_activate_exit C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:8598 blender.exe :0x00007FF660E2B4D0 ui_handle_button_event C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:9410 blender.exe :0x00007FF660E2C2A0 ui_handle_menu_button C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:10140 blender.exe :0x00007FF660E2C430 ui_handle_menu_event C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:10778 blender.exe :0x00007FF660E2D450 ui_handle_menus_recursive C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:11280 blender.exe :0x00007FF660E31F60 ui_popup_handler C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\interface\interface_handlers.c:11495 blender.exe :0x00007FF660B82620 wm_handlers_do_intern C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3048 blender.exe :0x00007FF660B81C90 wm_handlers_do C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3167 blender.exe :0x00007FF660B7F090 wm_event_do_handlers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:3661 blender.exe :0x00007FF660B697C0 WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:650 blender.exe :0x00007FF660B64FC0 main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:563 blender.exe :0x00007FF6618C73A8 __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 KERNEL32.DLL :0x00007FFA55A87020 BaseThreadInitThunk ntdll.dll :0x00007FFA572E2630 RtlUserThreadStart```
Member

Added subscribers: @HooglyBoogly, @lichtwerk

Added subscribers: @HooglyBoogly, @lichtwerk
Philipp Oeser self-assigned this 2021-10-15 11:01:08 +02:00
Member

This is caused by 3b6ee8cee7

Since rigging curves with armatures only works with envelopes (if I am not mistaken), this stirs up the question again why we actually give the choice for vertex groups in parenting.
So this might not be something users face often, nevertheless it should not crash imho, will dare setting to High prio since it is a recent regression.

Bandaid fix incoming.

CC @HooglyBoogly

This is caused by 3b6ee8cee7 Since rigging curves with armatures only works with envelopes (if I am not mistaken), this stirs up the question again why we actually give the choice for vertex groups in parenting. So this might not be something users face often, nevertheless it should not crash imho, will dare setting to High prio since it is a recent regression. Bandaid fix incoming. CC @HooglyBoogly

This issue was referenced by 7bf9c70b14

This issue was referenced by 7bf9c70b1402ba8d11889ea1adaca688bc58bb21
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Author

Just tested this and it's working thanks!

Just tested this and it's working thanks!
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#92083
No description provided.