Geometry Nodes: Attribute Capture crash when joining curves #92848

Closed
opened 2021-11-05 12:37:21 +01:00 by Rox Ya · 9 comments

Blender Version
Broken: blender-3.0.0-beta+v30.11392829adfe-windows.amd64-release is when the problem started
Worked: blender-3.0.0-beta+v30.348d7c35a9f9-windows.amd64-release
Caused by 18392cef17

Short Description
Create two curves and put them into Join Geometry. Add two Attribute Capture nodes after one of the curves, one set to Point and one set to Spline. Now most blender actions will create a crash (changing slider values for example). If both are Point or both Spline it doesn't happen.

Steps to Reproduce

  • Opening the attached file may make it crash
  • If not, dragging sliders in the modifier panel will do it almost instantly.

image.png

geonodes-woven-baskets crash test.crash.txt

geonodes-woven-baskets crash test.blend

**Blender Version** Broken: blender-3.0.0-beta+v30.11392829adfe-windows.amd64-release is when the problem started Worked: blender-3.0.0-beta+v30.348d7c35a9f9-windows.amd64-release Caused by 18392cef17 **Short Description** Create two curves and put them into Join Geometry. Add two Attribute Capture nodes after one of the curves, one set to Point and one set to Spline. Now most blender actions will create a crash (changing slider values for example). If both are Point or both Spline it doesn't happen. **Steps to Reproduce** - Opening the attached file may make it crash - If not, dragging sliders in the modifier panel will do it almost instantly. ![image.png](https://archive.blender.org/developer/F11729462/image.png) [geonodes-woven-baskets crash test.crash.txt](https://archive.blender.org/developer/F11729482/geonodes-woven-baskets_crash_test.crash.txt) [geonodes-woven-baskets crash test.blend](https://archive.blender.org/developer/F11729493/geonodes-woven-baskets_crash_test.blend)
Author

Added subscriber: @Martin-M-4

Added subscriber: @Martin-M-4
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Hi, thanks for the report. I can reproduce the crash on master: 3364a5bea6c977069210c3325111dc28051ee1cb

Will search for the culprit commit.

blender.exe         :0x00007FF651AB04D0  blender::bke::CustomDataAttributes::reorder C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\attribute_access.cc:852
blender.exe         :0x00007FF651E20140  blender::nodes::join_curve_attributes C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\nodes\geometry\nodes\node_geo_join_geometry.cc:431
blender.exe         :0x00007FF651E20560  blender::nodes::join_curve_components C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\nodes\geometry\nodes\node_geo_join_geometry.cc:472
blender.exe         :0x00007FF651E1F5D0  blender::nodes::geo_node_join_geometry_exec C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\nodes\geometry\nodes\node_geo_join_geometry.cc:509
blender.exe         :0x00007FF651D87190  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::execute_node C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:906
blender.exe         :0x00007FF651D89510  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::node_task_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:726
blender.exe         :0x00007FF651D89D80  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::run_node_from_task_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:708
blender.exe         :0x00007FF65258BFF0  BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:485
blender.exe         :0x00007FF651D841F0  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::with_locked_node<<lambda_c73e6ad3f7ee86 C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:1556
blender.exe         :0x00007FF651D89510  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::node_task_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:727
blender.exe         :0x00007FF651D89D80  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::run_node_from_task_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:708
blender.exe         :0x00007FF65258BFF0  BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:485
blender.exe         :0x00007FF651D83AA0  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::with_locked_node<<lambda_53d139213e9881 C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:1556
blender.exe         :0x00007FF651D83DE0  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::with_locked_node<<lambda_97e59d60c46e6e C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:1550
blender.exe         :0x00007FF651D89DB0  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::schedule_initial_nodes C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:652
blender.exe         :0x00007FF651D86760  blender::modifiers::geometry_nodes::GeometryNodesEvaluator::execute C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:457
blender.exe         :0x00007FF651D865D0  blender::modifiers::geometry_nodes::evaluate_geometry_nodes C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:1731
blender.exe         :0x00007FF651D46100  compute_geometry C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes.cc:1000
blender.exe         :0x00007FF651D48930  modifyGeometry C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes.cc:1100
blender.exe         :0x00007FF651A02020  curve_calc_modifiers_post C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\displist.cc:903
blender.exe         :0x00007FF651A02D70  evaluate_curve_type_object C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\displist.cc:1492
blender.exe         :0x00007FF651A04A80  BKE_displist_make_curveTypes C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\displist.cc:1517
blender.exe         :0x00007FF651A918D0  BKE_object_handle_data_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\object_update.c:228
blender.exe         :0x00007FF651A91660  BKE_object_eval_uber_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\object_update.c:396
blender.exe         :0x00007FF651C741E0  blender::deg::`anonymous namespace'::evaluate_node C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:120
blender.exe         :0x00007FF651C74190  blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:132
blender.exe         :0x00007FF65258BFF0  BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:485
blender.exe         :0x00007FF651C74280  blender::deg::`anonymous namespace'::schedule_node_to_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:79
blender.exe         :0x00007FF651C73A60  blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:299
blender.exe         :0x00007FF651C73A60  blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:306
blender.exe         :0x00007FF651C73A60  blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:306
blender.exe         :0x00007FF65258C110  BLI_task_pool_work_and_wait C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:500
blender.exe         :0x00007FF651C73D10  blender::deg::deg_evaluate_on_refresh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:408
blender.exe         :0x00007FF651960080  scene_graph_update_tagged C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\scene.c:2571
blender.exe         :0x00007FF65189FD30  wm_event_do_notifiers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:618
blender.exe         :0x00007FF651889800  WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:658
blender.exe         :0x00007FF651884FD0  main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:562
blender.exe         :0x00007FF65264C538  __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
KERNEL32.DLL        :0x00007FF88FEC7020  BaseThreadInitThunk
ntdll.dll           :0x00007FF8900A2630  RtlUserThreadStart```
Hi, thanks for the report. I can reproduce the crash on master: `3364a5bea6c977069210c3325111dc28051ee1cb` Will search for the culprit commit. ```lines blender.exe :0x00007FF651AB04D0 blender::bke::CustomDataAttributes::reorder C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\attribute_access.cc:852 blender.exe :0x00007FF651E20140 blender::nodes::join_curve_attributes C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\nodes\geometry\nodes\node_geo_join_geometry.cc:431 blender.exe :0x00007FF651E20560 blender::nodes::join_curve_components C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\nodes\geometry\nodes\node_geo_join_geometry.cc:472 blender.exe :0x00007FF651E1F5D0 blender::nodes::geo_node_join_geometry_exec C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\nodes\geometry\nodes\node_geo_join_geometry.cc:509 blender.exe :0x00007FF651D87190 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::execute_node C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:906 blender.exe :0x00007FF651D89510 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::node_task_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:726 blender.exe :0x00007FF651D89D80 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::run_node_from_task_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:708 blender.exe :0x00007FF65258BFF0 BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:485 blender.exe :0x00007FF651D841F0 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::with_locked_node<<lambda_c73e6ad3f7ee86 C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:1556 blender.exe :0x00007FF651D89510 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::node_task_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:727 blender.exe :0x00007FF651D89D80 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::run_node_from_task_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:708 blender.exe :0x00007FF65258BFF0 BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:485 blender.exe :0x00007FF651D83AA0 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::with_locked_node<<lambda_53d139213e9881 C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:1556 blender.exe :0x00007FF651D83DE0 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::with_locked_node<<lambda_97e59d60c46e6e C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:1550 blender.exe :0x00007FF651D89DB0 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::schedule_initial_nodes C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:652 blender.exe :0x00007FF651D86760 blender::modifiers::geometry_nodes::GeometryNodesEvaluator::execute C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:457 blender.exe :0x00007FF651D865D0 blender::modifiers::geometry_nodes::evaluate_geometry_nodes C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc:1731 blender.exe :0x00007FF651D46100 compute_geometry C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes.cc:1000 blender.exe :0x00007FF651D48930 modifyGeometry C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_nodes.cc:1100 blender.exe :0x00007FF651A02020 curve_calc_modifiers_post C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\displist.cc:903 blender.exe :0x00007FF651A02D70 evaluate_curve_type_object C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\displist.cc:1492 blender.exe :0x00007FF651A04A80 BKE_displist_make_curveTypes C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\displist.cc:1517 blender.exe :0x00007FF651A918D0 BKE_object_handle_data_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\object_update.c:228 blender.exe :0x00007FF651A91660 BKE_object_eval_uber_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\object_update.c:396 blender.exe :0x00007FF651C741E0 blender::deg::`anonymous namespace'::evaluate_node C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:120 blender.exe :0x00007FF651C74190 blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:132 blender.exe :0x00007FF65258BFF0 BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:485 blender.exe :0x00007FF651C74280 blender::deg::`anonymous namespace'::schedule_node_to_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:79 blender.exe :0x00007FF651C73A60 blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:299 blender.exe :0x00007FF651C73A60 blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:306 blender.exe :0x00007FF651C73A60 blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:306 blender.exe :0x00007FF65258C110 BLI_task_pool_work_and_wait C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:500 blender.exe :0x00007FF651C73D10 blender::deg::deg_evaluate_on_refresh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:408 blender.exe :0x00007FF651960080 scene_graph_update_tagged C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\scene.c:2571 blender.exe :0x00007FF65189FD30 wm_event_do_notifiers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:618 blender.exe :0x00007FF651889800 WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:658 blender.exe :0x00007FF651884FD0 main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:562 blender.exe :0x00007FF65264C538 __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 KERNEL32.DLL :0x00007FF88FEC7020 BaseThreadInitThunk ntdll.dll :0x00007FF8900A2630 RtlUserThreadStart```
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

Caused by 18392cef17
cc @HooglyBoogly

Caused by 18392cef17 cc @HooglyBoogly
Hans Goudey self-assigned this 2021-11-05 15:02:27 +01:00
Member

Thanks for the report and the testing. I'll look into this.

Thanks for the report and the testing. I'll look into this.

This issue was referenced by 594ee5f160

This issue was referenced by 594ee5f160dd7cbe29d7c406299629ddfacb39ad
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#92848
No description provided.