HIP does not render OpenVDB Cloud #93045

Closed
opened 2021-11-12 20:32:29 +01:00 by Thomas Dinges · 15 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: Radeon RX 5500 XT ATI Technologies Inc. 4.5.14802 Core Profile Context 21.Q4 30.0.14002.136

Blender Version
Broken: version: 3.1.0 Alpha, branch: master (modified), commit date: 2021-11-11 13:54, hash: 06a74e7816
Broken: version: 3.0.0 Beta

Short description of error
Open the wdas_cloud.blend benchmark file from SVN. https://svn.blender.org/svnroot/bf-blender/trunk/lib/benchmarks/cycles/wdas_cloud/ and render with HIP. The volume object is not rendered, only the blue sky is.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: Radeon RX 5500 XT ATI Technologies Inc. 4.5.14802 Core Profile Context 21.Q4 30.0.14002.136 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master (modified), commit date: 2021-11-11 13:54, hash: `06a74e7816` Broken: version: 3.0.0 Beta **Short description of error** Open the wdas_cloud.blend benchmark file from SVN. https://svn.blender.org/svnroot/bf-blender/trunk/lib/benchmarks/cycles/wdas_cloud/ and render with HIP. The volume object is not rendered, only the blue sky is.
Author
Owner

Added subscriber: @ThomasDinges

Added subscriber: @ThomasDinges
Author
Owner

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @brecht

Added subscriber: @brecht

May be the same issue as {#92984}?

Though not necessarily since this is a sparse volume and the other is a dense volume.

May be the same issue as {#92984}? Though not necessarily since this is a sparse volume and the other is a dense volume.
Author
Owner

It doesn't crash in the wdas_cloud file though. It just renders a blue sky, without volume object. Regular volumes render fine though (For example: Cube with a checker texture and Principled Volume shader).

It doesn't crash in the wdas_cloud file though. It just renders a blue sky, without volume object. Regular volumes render fine though (For example: Cube with a checker texture and Principled Volume shader).

Added subscriber: @leesonw

Added subscriber: @leesonw

@ThomasDinges, @leesonw.

I noticed the NanoVDB flag is not defined for HIP kernel compilation. Can you test if this helps (patch for blender-v3.0-release branch)?

diff --git a/intern/cycles/kernel/CMakeLists.txt b/intern/cycles/kernel/CMakeLists.txt
index 29ff69d..1a254f5 100644
--- a/intern/cycles/kernel/CMakeLists.txt
+++ b/intern/cycles/kernel/CMakeLists.txt
@@ -565,6 +565,12 @@ if(WITH_CYCLES_HIP_BINARIES AND WITH_CYCLES_DEVICE_HIP)
       set(name ${name}_experimental)
     endif()
 
+    if(WITH_NANOVDB)
+      set(hip_flags ${hip_flags}
+        -D WITH_NANOVDB
+        -I "${NANOVDB_INCLUDE_DIR}")
+    endif()
+
     if(WITH_CYCLES_DEBUG)
       set(hip_flags ${hip_flags} -D __KERNEL_DEBUG__)
     endif()
@ThomasDinges, @leesonw. I noticed the NanoVDB flag is not defined for HIP kernel compilation. Can you test if this helps (patch for `blender-v3.0-release` branch)? ``` diff --git a/intern/cycles/kernel/CMakeLists.txt b/intern/cycles/kernel/CMakeLists.txt index 29ff69d..1a254f5 100644 --- a/intern/cycles/kernel/CMakeLists.txt +++ b/intern/cycles/kernel/CMakeLists.txt @@ -565,6 +565,12 @@ if(WITH_CYCLES_HIP_BINARIES AND WITH_CYCLES_DEVICE_HIP) set(name ${name}_experimental) endif() + if(WITH_NANOVDB) + set(hip_flags ${hip_flags} + -D WITH_NANOVDB + -I "${NANOVDB_INCLUDE_DIR}") + endif() + if(WITH_CYCLES_DEBUG) set(hip_flags ${hip_flags} -D __KERNEL_DEBUG__) endif() ```
Author
Owner

@brecht Your CMakeLists change and https://developer.blender.org/P2601 together compile and render fine for me. wdas_cloud.blend renders as expected on HIP now.

@brecht Your CMakeLists change and https://developer.blender.org/P2601 together compile and render fine for me. wdas_cloud.blend renders as expected on HIP now.

This issue was referenced by blender/cycles@a735fa22ec

This issue was referenced by blender/cycles@a735fa22ecc9a8de53de18f4376fa4427de2ad07

This issue was referenced by bd2e3bb7bd

This issue was referenced by bd2e3bb7bd06bcbb2134e4853a72ab28f5f332b9

This issue was referenced by None@62754

This issue was referenced by None@62754

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Brecht Van Lommel self-assigned this 2021-11-18 13:39:39 +01:00
Upstream patch: https://github.com/AcademySoftwareFoundation/openvdb/pull/1253

Can someone help me how to apply this things ? I just compiled Blender 3.6 and openvdb cloud isn't rendering . Yes I read this whole conversation but can't get to understand cause the lack of knowledge . What exactly I have to do ?

Can someone help me how to apply this things ? I just compiled Blender 3.6 and openvdb cloud isn't rendering . Yes I read this whole conversation but can't get to understand cause the lack of knowledge . What exactly I have to do ?

All the changes are part of Blender and OpenVDB now, it should work without the need for applying custom patches. First thing to check would be if it works with the official releases and daily builds, if that fails you can make a bug report.

If there is only an issue with your own build, you can get help for that on https://devtalk.blender.org/c/building-blender/11 or https://blender.chat/channel/blender-builds.

All the changes are part of Blender and OpenVDB now, it should work without the need for applying custom patches. First thing to check would be if it works with the official releases and daily builds, if that fails you can make a bug report. If there is only an issue with your own build, you can get help for that on https://devtalk.blender.org/c/building-blender/11 or https://blender.chat/channel/blender-builds.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#93045
No description provided.