The X or Delete button does not work in the outliner (Blender File) #93401

New Issue

Oxicid · 2021-11-26T11:39:29+01:00

Oxicid commented

2021-11-26 11:39:29 +01:00

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.68

Blender Version
Broken: version: 2.93.6, branch: master, commit date: 2021-11-16 14:54, hash: c842a90e2f
Worked: (newest version of Blender that worked as expected)

Short description of error
[The X or Delete button does not work in the outliner (Blender File)]

Exact steps for others to reproduce the error

Open default startup file
{nav Outliner >Display Mode > Blender File}
In outliner {nav Brush > RMB > Delete > RMB > Assign Shortcut > X}
Attempt to delete any brush with hotkey (will not delete brush)
Change hotkey (eg {key Shift X}) and now attempt to delete brush with hotkey

when you press X items in:

Broken	Brushes, Cameras, Images, Lights, Line Styles, Materials, Meshes, Palettes, Workspaces, Worlds
worked	Collections, Objects, Scenes

Delete X Button.blend.py

{F12271213}]

**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.68 **Blender Version** Broken: version: 2.93.6, branch: master, commit date: 2021-11-16 14:54, hash: `c842a90e2f` Worked: (newest version of Blender that worked as expected) **Short description of error** [The X or Delete button does not work in the outliner (Blender File)] **Exact steps for others to reproduce the error** - Open default startup file - {nav Outliner >Display Mode > Blender File} - In outliner {nav Brush > RMB > Delete > RMB > Assign Shortcut > X} - Attempt to delete any brush with hotkey (will not delete brush) - Change hotkey (eg {key Shift X}) and now attempt to delete brush with hotkey when you press X items in: | Broken | Brushes, Cameras, Images, Lights, Line Styles, Materials, Meshes, Palettes, Workspaces, Worlds | | -- | -- | | worked | Collections, Objects, Scenes | ![X Button.png](https://archive.blender.org/developer/F12271212/X_Button.png) [Delete _X_ Button.blend.py](https://archive.blender.org/developer/F12271211/Delete__X__Button.blend.py) {[F12271213](https://archive.blender.org/developer/F12271213/Delete__X__Button.blend)}]

Oxicid commented

2021-11-26 11:39:29 +01:00

Added subscriber: @Oxicid

blender-admin commented

2021-11-26 11:39:29 +01:00

#94660 was marked as duplicate of this issue

Pratik Borhade commented

2021-11-26 12:21:20 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-11-26 12:46:52 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-11-26 13:59:59 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-11-26 13:59:59 +01:00

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-11-26 13:59:59 +01:00

Think this has caused confusion before (but it is still working somewhat as intended).

Underlying issue is that Delete is not the same for all IDs.

Collections and object have a unified delete operator since 26c0ca3aa7: Outliner_OT_delete
The context menu still does this differently (see OUTLINER_IDOP_DELETE , id_delete_fn).
The X icon is not too helpful here (since it implies that might be a shortcut).

If you assign {key X} to the context menu Delete, this conflicts with the {key X} that is already assigned to Outliner_OT_delete.
And you still end up calling Outliner_OT_delete [which does not work on anything but collections and objects].
I never really fully understood priorities in shortcuts, so assigning a shortcut that is already taken elsewhere might work, often times it does not though (and the "original" operator is still called).

So, while the order/priorities of shortcuts is not entirely clear to me, I think this report just boils down to the fact that we have conflicting shortcuts here.
To fully classify this, I guess we still need input from #user_interface devs (but to me, this does not look like a bug).

Think this has caused confusion before (but it is still working somewhat as intended). Underlying issue is that `Delete` is not the same for all IDs. Collections and object have a unified delete operator since 26c0ca3aa7: `Outliner_OT_delete` The context menu still does this differently (see `OUTLINER_IDOP_DELETE` , `id_delete_fn`). The `X` icon is not too helpful here (since it implies that might be a shortcut). If you assign {key X} to the context menu `Delete`, this conflicts with the {key X} that is already assigned to `Outliner_OT_delete`. And you still end up calling `Outliner_OT_delete` [which does not work on anything but collections and objects]. I never really fully understood priorities in shortcuts, so assigning a shortcut that is already taken elsewhere might work, often times it does not though (and the "original" operator is still called). So, while the order/priorities of shortcuts is not entirely clear to me, I think this report just boils down to the fact that we have conflicting shortcuts here. To fully classify this, I guess we still need input from #user_interface devs (but to me, this does not look like a bug).

Philipp Oeser commented

2022-01-05 15:33:39 +01:00

Added subscriber: @Rawalanche

Ludvik Koutny commented

2022-01-05 16:00:02 +01:00

So if this is not a bug, then what is the proper way to assign delete operator to any keyboard shortcut which would work in Blender File mode?

Philipp Oeser commented

2022-01-05 16:01:44 +01:00

{key Shift X} will work

Ludvik Koutny commented

2022-01-05 16:21:37 +01:00

In #93401#1283314, @lichtwerk wrote:
{key Shift X} will work

Ah, yes, it does. Confusingly, though, inability to assign same keyboard shortcut to conceptually the same operation should be considered a bug. Otherwise, by the same logic, users should not be able to use Delete key to both delete objects in object mode and mesh elements in mesh edit mode, since both are different operators yet both of these are called in the different modes of the same editor.

> In #93401#1283314, @lichtwerk wrote: > {key Shift X} will work Ah, yes, it does. Confusingly, though, inability to assign same keyboard shortcut to conceptually the same operation should be considered a bug. Otherwise, by the same logic, users should not be able to use Delete key to both delete objects in object mode and mesh elements in mesh edit mode, since both are different operators yet both of these are called in the different modes of the same editor.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

The X or Delete button does not work in the outliner (Blender File) #93401