ANT Landscape Tools - Landscape Eroder not working #93422

Closed
opened 2021-11-27 12:05:48 +01:00 by EliteArmedForce · 58 comments

System Information
Operating system: Ubuntu 20.04.3 LTS
CPU: Intel i5-4210U (4) @ 2.700GHz
Graphics card: AMD ATI Radeon HD 8550M / R5 M230
RAM: 12GB

Blender Version
Broken:
Blender v3.00 release candidate, 2fb8c6805a98, 2021-11-27
Worked:
Blender v2.93.6 release -Works perfectly in this version with similar steps

Short description of error
Runtime error of VertexGroup when creating 'capacity'(i think). In addition, missing necessary VertexGroups of the mesh after clicking "Landscape Eroder" uch as rainmap, avalanced, sediment etc.

File "/home/USER/Program/Blender/BlenderLauncher/daily/blender-3.0.0-candidate+daily.2fb8c6805a98/3.0/scripts/addons/ant_landscape/ant_functions.py", line 1062, in execute
ob.vertex_groups.active = vg

RuntimeError: Error: VertexGroup 'capacity' not found in object 'Landscape'


location: <unknown location>:-1```
Error screenshot:
![Screenshot from 2021-11-27 14-56-29_gimp.png](https://archive.blender.org/developer/F12406835/Screenshot_from_2021-11-27_14-56-29_gimp.png)
[error.blend](https://archive.blender.org/developer/F12406906/error.blend)
**Exact steps for others to reproduce the error**
Based on the default startup or an attached .blend file (as simple as possible).
- Ofc after hide/delete the default cube and activate the A.N.T. Landscape addon.
- Add Mesh -> Landscape (default, as in .blend file attached)
- Open "N" panel, then navigate to "Create" subpanel
- In "Landscape Tools", click "Landscape Eroder" which gives an error.

**Output without error**
Tested in v2.93.6. Repeated same steps.
![Screenshot from 2021-11-27 14-56-29_gimp.png](https://archive.blender.org/developer/F12406769/Screenshot_from_2021-11-27_14-56-29_gimp.png)
[works.blend](https://archive.blender.org/developer/F12406925/works.blend)
**System Information** Operating system: Ubuntu 20.04.3 LTS CPU: Intel i5-4210U (4) @ 2.700GHz Graphics card: AMD ATI Radeon HD 8550M / R5 M230 RAM: 12GB **Blender Version** Broken: Blender v3.00 release candidate, 2fb8c6805a98, 2021-11-27 Worked: Blender v2.93.6 release -Works perfectly in this version with similar steps **Short description of error** Runtime error of VertexGroup when creating 'capacity'(i think). In addition, missing necessary VertexGroups of the mesh after clicking "Landscape Eroder" uch as rainmap, avalanced, sediment etc. ```Python: Traceback (most recent call last): ``` File "/home/__USER__/Program/Blender/BlenderLauncher/daily/blender-3.0.0-candidate+daily.2fb8c6805a98/3.0/scripts/addons/ant_landscape/ant_functions.py", line 1062, in execute ob.vertex_groups.active = vg ``` RuntimeError: Error: VertexGroup 'capacity' not found in object 'Landscape' location: <unknown location>:-1``` Error screenshot: ![Screenshot from 2021-11-27 14-56-29_gimp.png](https://archive.blender.org/developer/F12406835/Screenshot_from_2021-11-27_14-56-29_gimp.png) [error.blend](https://archive.blender.org/developer/F12406906/error.blend) **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). - Ofc after hide/delete the default cube and activate the A.N.T. Landscape addon. - Add Mesh -> Landscape (default, as in .blend file attached) - Open "N" panel, then navigate to "Create" subpanel - In "Landscape Tools", click "Landscape Eroder" which gives an error. **Output without error** Tested in v2.93.6. Repeated same steps. ![Screenshot from 2021-11-27 14-56-29_gimp.png](https://archive.blender.org/developer/F12406769/Screenshot_from_2021-11-27_14-56-29_gimp.png) [works.blend](https://archive.blender.org/developer/F12406925/works.blend)

Added subscriber: @EliteArmedForce

Added subscriber: @EliteArmedForce

#102839 was marked as duplicate of this issue

#102839 was marked as duplicate of this issue

#100233 was marked as duplicate of this issue

#100233 was marked as duplicate of this issue

#100059 was marked as duplicate of this issue

#100059 was marked as duplicate of this issue

#100037 was marked as duplicate of this issue

#100037 was marked as duplicate of this issue

#99632 was marked as duplicate of this issue

#99632 was marked as duplicate of this issue

#98809 was marked as duplicate of this issue

#98809 was marked as duplicate of this issue

#97748 was marked as duplicate of this issue

#97748 was marked as duplicate of this issue

#96947 was marked as duplicate of this issue

#96947 was marked as duplicate of this issue

#96928 was marked as duplicate of this issue

#96928 was marked as duplicate of this issue

#96069 was marked as duplicate of this issue

#96069 was marked as duplicate of this issue

#95690 was marked as duplicate of this issue

#95690 was marked as duplicate of this issue

#95485 was marked as duplicate of this issue

#95485 was marked as duplicate of this issue

#95351 was marked as duplicate of this issue

#95351 was marked as duplicate of this issue

#95294 was marked as duplicate of this issue

#95294 was marked as duplicate of this issue

#94537 was marked as duplicate of this issue

#94537 was marked as duplicate of this issue

#94483 was marked as duplicate of this issue

#94483 was marked as duplicate of this issue

#94393 was marked as duplicate of this issue

#94393 was marked as duplicate of this issue

blender/documentation#93955 was marked as duplicate of this issue

blender/documentation#93955 was marked as duplicate of this issue

#93709 was marked as duplicate of this issue

#93709 was marked as duplicate of this issue

#93571 was marked as duplicate of this issue

#93571 was marked as duplicate of this issue
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscribers: @Joseph-Leaderbrand, @PratikPB2123

Added subscribers: @Joseph-Leaderbrand, @PratikPB2123

Added subscriber: @valera-8

Added subscriber: @valera-8

Vertex groups are lost after ant_functions.py, line 1006:

979        g = Grid.fromBlenderMesh(me, vg, self.Ef)
980
981        me = bpy.data.meshes.new(me.name)
...
1005        g.toBlenderMesh(me)
1006        ob.data = me
Vertex groups are lost after ant_functions.py, line 1006: ``` 979 g = Grid.fromBlenderMesh(me, vg, self.Ef) 980 981 me = bpy.data.meshes.new(me.name) ... 1005 g.toBlenderMesh(me) 1006 ob.data = me ```
Member

Added subscribers: @21xx1, @JacobMerrill-1

Added subscribers: @21xx1, @JacobMerrill-1
Member

Added subscriber: @Amoeba-1

Added subscriber: @Amoeba-1

Added subscriber: @muhuk

Added subscriber: @muhuk
Member

Added subscribers: @Yiming-Du, @renderluz-2

Added subscribers: @Yiming-Du, @renderluz-2
Member

Added subscriber: @Eliot-Mack

Added subscriber: @Eliot-Mack

Added subscriber: @DayWalkerDesign

Added subscriber: @DayWalkerDesign

Added subscriber: @christof.kueng

Added subscriber: @christof.kueng

Added subscriber: @glenncg

Added subscriber: @glenncg
Member

Added subscriber: @JeremyCooke

Added subscriber: @JeremyCooke
Member

Added subscriber: @jinsculpt

Added subscriber: @jinsculpt

Added subscriber: @MikeBlend01

Added subscriber: @MikeBlend01

Added subscriber: @Aditya-Nimje

Added subscriber: @Aditya-Nimje
Aditya Nimje self-assigned this 2022-03-01 17:03:55 +01:00

hey did you find the solution for it ?

hey did you find the solution for it ?

I did't understand the solution. Please explain it with steps or send me a short video how to do it.

I did't understand the solution. Please explain it with steps or send me a short video how to do it.

Added subscriber: @Alpi

Added subscriber: @Alpi

Hey i have also the same problem, how can i solve this? Update i found the solution here
https://developer.blender.org/T74604

Hey i have also the same problem, how can i solve this? Update i found the solution here https://developer.blender.org/T74604

Added subscriber: @KenAckerman

Added subscriber: @KenAckerman

In #93422#1315613, @Aditya-Nimje wrote:
hey did you find the solution for it ?

are u asking me(op)? as I find no reply to ur question or user mentions

> In #93422#1315613, @Aditya-Nimje wrote: > hey did you find the solution for it ? are u asking me(op)? as I find no reply to ur question or user mentions
Member

Added subscriber: @sammedia

Added subscriber: @sammedia
Member

Added subscriber: @billhails

Added subscriber: @billhails
Member

re #74604#1284952
@billhails hi, can you submit the patch at https://developer.blender.org/differential/diff/create/?
Or you want me to do this for you?

re #74604#1284952 @billhails hi, can you submit the patch at https://developer.blender.org/differential/diff/create/? Or you want me to do this for you?

In #93422#1333713, @PratikPB2123 wrote:
re #74604#1284952
@billhails hi, can you submit the patch at https://developer.blender.org/differential/diff/create/?
Or you want me to do this for you?

Hi sorry I wasn't paying attention. It's fine for you to submit my fix if you like, I don't have a lot of spare time.

> In #93422#1333713, @PratikPB2123 wrote: > re #74604#1284952 > @billhails hi, can you submit the patch at https://developer.blender.org/differential/diff/create/? > Or you want me to do this for you? Hi sorry I wasn't paying attention. It's fine for you to submit my fix if you like, I don't have a lot of spare time.

Added subscriber: @andyg

Added subscriber: @andyg

Added subscriber: @JmDigital

Added subscriber: @JmDigital
Member

Added subscriber: @Kurovis

Added subscriber: @Kurovis
Member

@billhails hi, I've made the patch for you D15432: Fix #93422: ANT Landscape Tools - Landscape Eroder not working
Can you describe your exact changes in patch description?

@billhails hi, I've made the patch for you [D15432: Fix #93422: ANT Landscape Tools - Landscape Eroder not working](https://archive.blender.org/developer/D15432) Can you describe your exact changes in patch description?

Hi, sorry I've not been very active, having trouble finding the patch description, I followed the link to https://developer.blender.org/D15432 but I'm not familiar with this tool, Ok If I add it here...


A breaking change to the python API means that assigning a new mesh to an object's data now deletes the object's vertex_groups.
The original code was expecting the vertex groups to remain intact after assigning the new eroded mesh.
This patch simply saves the vertex groups before assigning the mesh, then puts them back afterwards.
Other than that there is pure refactoring to reduce the size and complexity of the code.
The actual fix is on lines 966-979.

Hi, sorry I've not been very active, having trouble finding the patch description, I followed the link to https://developer.blender.org/D15432 but I'm not familiar with this tool, Ok If I add it here... ---- A breaking change to the python API means that assigning a new mesh to an object's data now deletes the object's vertex_groups. The original code was expecting the vertex groups to remain intact after assigning the new eroded mesh. This patch simply saves the vertex groups before assigning the mesh, then puts them back afterwards. Other than that there is pure refactoring to reduce the size and complexity of the code. The actual fix is on lines 966-979. ----

Added subscriber: @AnnaRoshchina

Added subscriber: @AnnaRoshchina

This issue was referenced by bff8295be5

This issue was referenced by bff8295be576ae2a2cb2c989157ec9fdcaa21c0a

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'

Added subscribers: @Library_Keeper, @ThomasDinges

Added subscribers: @Library_Keeper, @ThomasDinges

Added subscriber: @Abhay-Kasavkar

Added subscriber: @Abhay-Kasavkar
Member

Added subscribers: @Joseph-Mann, @deadpin

Added subscribers: @Joseph-Mann, @deadpin
Sign in to join this conversation.
No Milestone
No project
No Assignees
13 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#93422
No description provided.