Make switching between custom and generated preview more clear #93536

New Issue

Simon Thommes · 2021-12-01T10:57:11+01:00

Simon Thommes commented

2021-12-01 10:57:11 +01:00

System Information
Operating system: Linux-5.11.0-7620-generic-x86_64-with-glibc2.33 64 Bits
Graphics card: AMD NAVY_FLOUNDER (DRM 3.40.0, 5.11.0-7620-generic, LLVM 11.0.1) AMD 4.6 (Core Profile) Mesa 21.0.1

Blender Version
Broken: version: 3.0.0 Release Candidate, branch: master, commit date: 2021-11-29 10:04, hash: b31250feba
Worked: -

Short description of error
When using a thumbnail image from disk, refreshing the thumbnail will not only reload the image from disk, but also downscale its resolution to 128 pixels (or maybe less ?).

In this example I am using a 256px resolution thumbnail.
asset_browser_thumbnail_reload_128px-2021-12-01_10.52.47.mp4

Exact steps for others to reproduce the error
Make asset with 256px thumbnail on disk and press the refresh button.

Thumbnail used

**System Information** Operating system: Linux-5.11.0-7620-generic-x86_64-with-glibc2.33 64 Bits Graphics card: AMD NAVY_FLOUNDER (DRM 3.40.0, 5.11.0-7620-generic, LLVM 11.0.1) AMD 4.6 (Core Profile) Mesa 21.0.1 **Blender Version** Broken: version: 3.0.0 Release Candidate, branch: master, commit date: 2021-11-29 10:04, hash: `b31250feba` Worked: - **Short description of error** When using a thumbnail image from disk, refreshing the thumbnail will not only reload the image from disk, but also downscale its resolution to 128 pixels (or maybe less ?). In this example I am using a 256px resolution thumbnail. [asset_browser_thumbnail_reload_128px-2021-12-01_10.52.47.mp4](https://archive.blender.org/developer/F12672405/asset_browser_thumbnail_reload_128px-2021-12-01_10.52.47.mp4) **Exact steps for others to reproduce the error** Make asset with 256px thumbnail on disk and press the refresh button. **Thumbnail used** ![planks_herringbone.png](https://archive.blender.org/developer/F12672483/planks_herringbone.png)

Simon Thommes commented

2021-12-01 10:57:11 +01:00

Added subscriber: @SimonThommes

Simon Thommes changed title from ~~Asset Browser - Refreshing thumbnail from disk forces resolution to 128px~~ to Asset Browser - Refreshing thumbnail from disk caps resolution

2021-12-01 10:59:57 +01:00

Pratik Borhade commented

2021-12-01 11:31:05 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-12-01 11:46:35 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Julian Eisel commented

2021-12-01 20:18:04 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2021-12-01 20:18:04 +01:00

Hmm, the reloading should actually trigger a regeneration of the automatic preview, otherwise there is no way to get back to that after setting a custom one (except using {nav Clear Data-Block Previews} which clears all previews of a given data-block type). I thought it already behaved that way. So either this broke recently or I made assumptions without confirming them.

I'm actually also wondering though, should there be anything preventing you from regenerating a preview after having selected a custom one? The refresh button is not the most explanatory thing, so people may misunderstand things. OTOH there is undo support for preview changes.

Hmm, the reloading should actually trigger a regeneration of the automatic preview, otherwise there is no way to get back to that after setting a custom one (except using {nav Clear Data-Block Previews} which clears all previews of a given data-block type). I thought it already behaved that way. So either this broke recently or I made assumptions without confirming them. I'm actually also wondering though, should there be anything preventing you from regenerating a preview after having selected a custom one? The refresh button is not the most explanatory thing, so people may misunderstand things. OTOH there is undo support for preview changes.

Simon Thommes commented

2021-12-02 11:06:04 +01:00

Yeah, that makes sense, there should definitely be a way to get the automatic preview back! But yeah, the icon suggests more a reloading from disk for me.
Upon testing it now, the button also seems to regenerate rather than reload from disk. But in the video I am sure that it's not doing that. I'm not sure how to reproduce that though.

Yeah, that makes sense, there should definitely be a way to get the automatic preview back! But yeah, the icon suggests more a reloading from disk for me. Upon testing it now, the button also seems to regenerate rather than reload from disk. But in the video I am sure that it's not doing that. I'm not sure how to reproduce that though.

Julian Eisel commented

2021-12-09 15:57:13 +01:00

Changing to design task, since we have to figure out how to allow switching between custom and automatic previews.

Julian Eisel changed title from ~~Asset Browser - Refreshing thumbnail from disk caps resolution~~ to Make switching between custom and generated preview more clear

2021-12-09 20:51:03 +01:00

Simon Thommes commented

2021-12-10 11:06:43 +01:00

I just want to point out, that in my case in the video the refresh button in fact just down-scales the custom thumbnail instead of regenerating the default preview. There is a difference in scale and there is a rim light on the right that the custom preview doesn't have.

So while I agree that this should be a design topic, in my case this is also simply a bug afaict.

I just want to point out, that in my case in the video the refresh button in fact just down-scales the custom thumbnail instead of regenerating the default preview. There is a difference in scale and there is a rim light on the right that the custom preview doesn't have. So while I agree that this should be a design topic, in my case this is also simply a bug afaict.

Julian Eisel commented

2021-12-10 12:36:14 +01:00

Hmmm, is it possible that you had an edited preview.blend in use still? Just to rule that out first.

Simon Thommes commented

2022-01-03 10:25:29 +01:00

Sorry for the late response, holidays got in the way :D
It is possible, but I'm relatively certain that this was on master. But if this issue has not appeared again we can also just abandon this issue until it happens again.

Sorry for the late response, holidays got in the way :D It is possible, but I'm relatively certain that this was on master. But if this issue has not appeared again we can also just abandon this issue until it happens again.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Make switching between custom and generated preview more clear #93536