Graph Editor: Box Select 'Include Handles' not working correctly #94093

Open
opened 2021-12-15 04:51:01 +01:00 by Kevin C. Burke · 4 comments
Contributor

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 497.09

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca30557
Worked: N/A (tested in 2.9.3 to same results)

Short description of error
In the Graph Editor, use Box Select to select keyframes. In the Redo Panel, check/uncheck Include Handles. Expected behavior would be to include/exclude Handles with box selection.
Include_Handles.gif

Exact steps for others to reproduce the error

  1. Activate Box Select Tool
  2. Box select keyframes and handles.
  3. Toggle "Include Handles" in Redo Panel
    Result: handles are included in both states

Additional notes
If both handles and the key are selected, the checkbox doesn't work. However if I have one handle and a key or just one handle, it toggles the selection. It is still not expected behavior though as it also will select other key control points, changing the selection. This behavior changes again when View > Only Selected Keyframe Handles is checked. The Include Handles checkbox then toggles the visibility of the selected keyframes.

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 497.09 **Blender Version** Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: `f1cca30557` Worked: N/A (tested in 2.9.3 to same results) **Short description of error** In the Graph Editor, use **Box Select** to select keyframes. In the Redo Panel, check/uncheck **Include Handles**. Expected behavior would be to include/exclude Handles with box selection. ![Include_Handles.gif](https://archive.blender.org/developer/F12744390/Include_Handles.gif) **Exact steps for others to reproduce the error** 1. Activate Box Select Tool 2. Box select keyframes and handles. 3. Toggle "Include Handles" in Redo Panel Result: handles are included in both states **Additional notes** If both handles and the key are selected, the checkbox doesn't work. However if I have one handle and a key or just one handle, it toggles the selection. It is still not expected behavior though as it also will select other key control points, changing the selection. This behavior changes again when **View > Only Selected Keyframe Handles** is checked. The **Include Handles** checkbox then toggles the visibility of the selected keyframes.
Author
Contributor

Added subscriber: @KevinCBurke

Added subscriber: @KevinCBurke
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:35:15 +01:00

I had a look at this.
Blenders logic goes like this atm. if include handles is enabled it checks which handles to select.
If not it just selects everything.

So the logic is kind of flipped from what you expect.
I don't think this is easily fixable especially with the code in keyframes_edit.cc being super complicated. (KEYFRAME_OK_CHECKS macro being one of offenders)

Needs a nice refactor and a clear design on how things should work

I had a look at this. Blenders logic goes like this atm. if include handles is enabled it checks which handles to select. If not it just selects everything. So the logic is kind of flipped from what you expect. I don't think this is easily fixable especially with the code in `keyframes_edit.cc` being super complicated. (`KEYFRAME_OK_CHECKS` macro being one of offenders) Needs a nice refactor and a clear design on how things should work
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#94093
No description provided.