Outliner: Sync Selection off not working when clicking LMB on data object name #94117

Open
opened 2021-12-15 16:53:35 +01:00 by Garek · 5 comments

Blender Version
Broken: version: 3.0.0, branch: master (modified), commit date: 2021-12-02 18:35, hash: f1cca30557
Broken: version: 2.91.2 (works correctly on meshes for some reason till worked version)
Worked: version: 2.82

Short description of error
When Sync Selection is off it's still possible to sync selection by clicking on object data name (+ small margin). Additionaly clicking on object data name will sync it with relevant slot in Properties editor. This bugged area becomes slightly longer to the left when active, see video.

Exact steps for others to reproduce the error

  1. Open default scene.
  2. Turn off Sync Selection on Outliner.
  3. Deselect onjects in your scene by clicking on empty space in 3D Viewport.
  4. Select objects or object data in outliner without clicking on their name - see that Sync Selection is off
  5. Select objects or object data in outliner by clicking in their name - see that now parent onject is selected in Outliner aswell as in 3D Viewport.
    Outliner Sync Selection off bug 2021-12-15 20-45-35-213.mp4
**Blender Version** Broken: version: 3.0.0, branch: master (modified), commit date: 2021-12-02 18:35, hash: `f1cca30557` Broken: version: 2.91.2 (works correctly on meshes for some reason till worked version) Worked: version: 2.82 **Short description of error** When `Sync Selection` is off it's still possible to sync selection by clicking on object data name (+ small margin). Additionaly clicking on object data name will sync it with relevant slot in Properties editor. This bugged area becomes slightly longer to the left when active, see video. **Exact steps for others to reproduce the error** 1. Open default scene. 2. Turn off `Sync Selection` on Outliner. 3. Deselect onjects in your scene by clicking on empty space in 3D Viewport. 4. Select objects or object data in outliner without clicking on their name - see that `Sync Selection` is off 5. Select objects or object data in outliner by clicking in their name - see that now parent onject is selected in Outliner aswell as in 3D Viewport. [Outliner Sync Selection off bug 2021-12-15 20-45-35-213.mp4](https://archive.blender.org/developer/F12748678/Outliner_Sync_Selection_off_bug_2021-12-15_20-45-35-213.mp4)
Author

Added subscriber: @Garek

Added subscriber: @Garek
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'
Member

Hi, did some investigation yesterday. From current code this looks expected.
Parent element will be selected if Sync selection is enabled or clicked over name (i.e. if flag OL_ITEM_SELECT_DATA is set)
Both conditions are mentioned in do_outliner_item_activate_tree_element function call (https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_outliner/outliner_select.c$1469)
With either condition true, it will select parent elem (if any) i.e. set TSE_SELECTED (in function tree_element_object_activate)

Here I don't quite understand purpose of checking click position: whether clicked on object name or over empty space.
Also, with sync selection off (I think) selection state should be completely decoupled.

I can fix this but will let developers decide if this is actually a bug.

Hi, did some investigation yesterday. From current code this looks expected. Parent element will be selected if Sync selection is enabled or clicked over name (i.e. if flag `OL_ITEM_SELECT_DATA` is set) Both conditions are mentioned in `do_outliner_item_activate_tree_element` function call (https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_outliner/outliner_select.c$1469) With either condition true, it will select parent elem (if any) i.e. set `TSE_SELECTED` (in function `tree_element_object_activate`) Here I don't quite understand purpose of checking click position: whether clicked on object name or over empty space. Also, with sync selection off (I think) selection state should be completely decoupled. I can fix this but will let developers decide if this is actually a bug.
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:22:37 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#94117
No description provided.