Setting Masking->Stencil Mask->Stencil Image crashes Blender. Includes fix #95981

New Issue

Jeff Dierstein · 2022-02-23T06:44:01+01:00

Jeff Dierstein commented

2022-02-23 06:44:01 +01:00

System Information
Operating system: Linux-5.4.0-100-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: NVIDIA GeForce GTX 750 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.103.01

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-02-23 01:31, hash: c6df7266c7
Worked: 3.0.1 (Think the issue started sometime in the 3.1.0 Alpha cycle)

Caused by 9d3f35a0bf look at that :)

Short description of error
Setting Stencil Mask->Stencil Image either by creating a new image or selecting an existing image will immediate crash Blender.
Bug affects both linux and windows and is 100% reproducible on my system.

Exact steps for others to reproduce the error
mask_tool_crash_02.blend

Load the attached .blend file (Optional:switch to the mask tool)
In the 3D view, scroll the tool tab down to Masking->Stencil Mask->Stencil Image
Click the 'New' button then click 'Ok' to accept the defaults
crash straight to the desktop

I've also attached the error message that you'll receive after the crash if you start blender via a terminal or cmd prompt.

stencil_masking_error_01.txt

It explains the problem: the smoothstep function is now interpreting "0" as an integer, rather than assuming it's a float.

The Fix

Edit: blender-git/blender/source/blender/draw/engines/overlay/shaders/paint_texture_frag.glsl

simply change line 18 from:
float mask_step = smoothstep(0, 3.0, mask.r + mask.g + mask.b);
to:
float mask_step = smoothstep(0.0, 3.0, mask.r + mask.g + mask.b);

I've tested this by locally compiling a version of Blender with this change and it creates a binary that works as expected and does not crash when setting the stencil mask.

**System Information** Operating system: Linux-5.4.0-100-generic-x86_64-with-glibc2.31 64 Bits Graphics card: NVIDIA GeForce GTX 750 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.103.01 **Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-02-23 01:31, hash: `c6df7266c7` Worked: 3.0.1 (Think the issue started sometime in the 3.1.0 Alpha cycle) Caused by 9d3f35a0bf look at that :) **Short description of error** Setting Stencil Mask->Stencil Image either by creating a new image or selecting an existing image will immediate crash Blender. Bug affects both linux and windows and is 100% reproducible on my system. **Exact steps for others to reproduce the error** [mask_tool_crash_02.blend](https://archive.blender.org/developer/F12883687/mask_tool_crash_02.blend) 1) Load the attached .blend file (Optional:switch to the mask tool) 2) In the 3D view, scroll the tool tab down to Masking->Stencil Mask->Stencil Image 3) Click the 'New' button then click 'Ok' to accept the defaults 4) crash straight to the desktop I've also attached the error message that you'll receive after the crash if you start blender via a terminal or cmd prompt. [stencil_masking_error_01.txt](https://archive.blender.org/developer/F12883686/stencil_masking_error_01.txt) It explains the problem: the smoothstep function is now interpreting "0" as an integer, rather than assuming it's a float. **The Fix** Edit: blender-git/blender/source/blender/draw/engines/overlay/shaders/paint_texture_frag.glsl simply change line 18 from: float mask_step = smoothstep(0, 3.0, mask.r + mask.g + mask.b); to: float mask_step = smoothstep(0.0, 3.0, mask.r + mask.g + mask.b); I've tested this by locally compiling a version of Blender with this change and it creates a binary that works as expected and does not crash when setting the stencil mask.

Jeff Dierstein commented

2022-02-23 06:44:01 +01:00

Added subscriber: @elkmug

Pratik Borhade commented

2022-02-23 07:14:26 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-02-23 08:15:03 +01:00

Doesn't crash on latest master 165b030b19
Perhaps crash is specific for NVIDIA GPU?

Operating system : Windows-10-10.0.18362-SP0 64 Bits
Graphics card : AMD Radeon(TM) 535 ATI Technologies .
Graphics card: Intel(R) UHD Graphics 620 Intel 4.5.0 - Build 26.20.100.7323```

Doesn't crash on latest master 165b030b19718694eaf33d6602034ed88fdd31a1 Perhaps crash is specific for NVIDIA GPU? ```System Information Operating system : Windows-10-10.0.18362-SP0 64 Bits Graphics card : AMD Radeon(TM) 535 ATI Technologies . Graphics card: Intel(R) UHD Graphics 620 Intel 4.5.0 - Build 26.20.100.7323```

Philipp Oeser commented

2022-02-23 08:32:57 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-02-23 08:32:57 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-02-23 08:32:57 +01:00

Can confirm. Will check.

Omar Emara commented

2022-02-23 08:35:09 +01:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-02-23 08:35:09 +01:00

Even if the implicit conversion is guaranteed by the specification, this seems like an easy fix.
@elkmug If you are interested in submitting your fix as patch, check https://wiki.blender.org/wiki/Process/Contributing_Code.

Even if the implicit conversion is guaranteed by the specification, this seems like an easy fix. @elkmug If you are interested in submitting your fix as patch, check https://wiki.blender.org/wiki/Process/Contributing_Code.

Philipp Oeser commented

2022-02-23 08:58:57 +01:00

Added subscriber: @Jeroen-Bakker

Philipp Oeser commented

2022-02-23 08:58:57 +01:00

Caused by 9d3f35a0bf look at that :)

CC @Jeroen-Bakker

Caused by 9d3f35a0bf look at that :) CC @Jeroen-Bakker

Jeroen Bakker self-assigned this 2022-02-28 08:20:40 +01:00

Jeroen Bakker commented

2022-02-28 08:39:44 +01:00

Not able to reproduce, but it is known that some drivers don't handle implicit conversions that well. Will apply the fix. Thanks!
Interesting that this was already there for 2 years...

Not able to reproduce, but it is known that some drivers don't handle implicit conversions that well. Will apply the fix. Thanks! Interesting that this was already there for 2 years...

blender-admin commented

2022-02-28 08:40:59 +01:00

This issue was referenced by 2a644deaa7

This issue was referenced by 2a644deaa7b2a94c3c6b73c5fdac59b524337c80

Jeroen Bakker commented

2022-02-28 09:06:10 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2022-02-28 09:06:10 +01:00

Thomas Dinges added this to the 3.1 milestone 2023-02-08 15:52:45 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Setting Masking->Stencil Mask->Stencil Image crashes Blender. Includes fix #95981