Creating texture with canvas menu (sculpt mode, paint tool) leading to shader fail (fuchsia) #97519

New Issue

Vyacheslav Kobozev · 2022-04-21T19:47:51+02:00

2022-04-21 19:47:51 +02:00

System Information
Operating system: Windows-8.1-6.3.9600-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 473.04

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-20 19:32, hash: b67ccc333a

Short description of error
Select cube,
go to sculpt mode
select paint tool
open canvas menu

create new material slot.
for me it produces fucsia usually but sometimes work properly

Even saving and reverting file sometimes produces fuchsia (wrong shader cached?)
This never happen, if I create image node manually.
2022-04-21_20-37-29.mp4
2022-04-21_20-45-37.mp4

**System Information** Operating system: Windows-8.1-6.3.9600-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 473.04 **Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-20 19:32, hash: `b67ccc333a` **Short description of error** Select cube, go to sculpt mode select paint tool open canvas menu ![изображение.png](https://archive.blender.org/developer/F13014722/изображение.png) create new material slot. for me it produces fucsia usually but sometimes work properly Even saving and reverting file sometimes produces fuchsia (wrong shader cached?) This never happen, if I create image node manually. [2022-04-21_20-37-29.mp4](https://archive.blender.org/developer/F13014716/2022-04-21_20-37-29.mp4) [2022-04-21_20-45-37.mp4](https://archive.blender.org/developer/F13014728/2022-04-21_20-45-37.mp4)

Vyacheslav Kobozev commented

2022-04-21 19:47:51 +02:00

Added subscriber: @Vyach

Pratik Borhade commented

2022-04-22 13:35:39 +02:00

Added subscribers: @JosephEagar, @PratikPB2123

Pratik Borhade commented

2022-04-22 13:35:39 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-04-22 13:35:39 +02:00

Hi, thanks for the report. I can confirm.
This is still an experimental feature (Canvas panel doesn't show up without Sculpt texture paint feature).

Hi, thanks for the report. I can confirm. This is still an experimental feature (Canvas panel doesn't show up without `Sculpt texture paint` feature).

Philipp Oeser commented

2022-04-22 14:36:49 +02:00

Added subscribers: @JulienKaspar, @Jeroen-Bakker, @brecht, @lichtwerk

Philipp Oeser commented

2022-04-22 14:36:49 +02:00

CC @JulienKaspar
CC @Jeroen-Bakker
CC @brecht

CC @JulienKaspar CC @Jeroen-Bakker CC @brecht

Philipp Oeser commented

2022-05-05 15:55:03 +02:00

Will raise prio since this is basically unusable (even it does not happen 100% of the time, the chance is pretty high on my side -- it is > 50% I would say)

This is what I get then:

ERROR (gpu.shader): GPU_material_compile VertShader: 
      | 
  203 | layout(location = 15) in vec4 a;
      | 
      | Error: C0000: syntax error, unexpected reserved word "layout", expecting ';' at token "layout"
      | 
 2258 | var_attrs.v0 = attr_load_vec4(a);
      | 
      | Error: C1503: undefined variable "a"

ERROR (gpu.shader): GPU_material_compile FragShader: 
      | 
  203 | in codegen_iface{
      | 
      | Error: C7537: OpenGL does not allow 'inout' after a type specifier
      | Error: C1014: "codegen_iface" is not a function
      | Error: C1004: in and out only apply to formal parameters "codegen_iface"
      | 
  205 | }
      | 
      | Error: C1016: expression type incompatible with function return type
      | 
  203 | in codegen_iface{
      | 
      | Error: C1108: function "codegen_iface" has no statements
      | 
  205 | }
      | 
      | Error: C3009: layout qualifier 'binding', incompatible with 'codegen_iface'
      | 
  206 | var_attrs;
      | 
      | Error: C0000: syntax error, unexpected ';', expecting "::" at token ";"
      | 
 7792 | differentiate_texco(var_attrs.v0, tmp2);
      | 
      | Error: C1503: undefined variable "var_attrs"
      | 
 7795 | mapping_mat4(tmp2, node_tree.u4, node_tree.u5, node_tree.u6, node_tree.u7, node_tree.u8, node_tree.u9, tmp10);
      | 
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | 
 7799 | node_tex_image_linear(tmp10, samp0, tmp13, tmp14);
      | 
      | Error: C1503: undefined variable "samp0"
      | 
 7816 | node_bsdf_principled(tmp16, node_tree.u20, node_tree.u21, node_tree.u22, node_tree.u23, node_tree.u24, node_tree.u25, node_tree.u26, node_tree.u27, node_tree.u28, node_tree.u29, node_tree.u30, node_tree.u31, node_tree.u32, node_tree.u33, node_tree.u34, node_tree.u35, node_tree.u36, node_tree.u37, node_tree.u38, node_tree.u39, node_tree.u40, tmp17, tmp18, cons43, node_tree.u44, cons45, cons46, cons47, cons48, node_tree.u49, tmp50);
      | 
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"
      | Error: C1503: undefined variable "node_tree"

Will raise prio since this is basically unusable (even it does not happen 100% of the time, the chance is pretty high on my side -- it is > 50% I would say) This is what I get then: ``` ERROR (gpu.shader): GPU_material_compile VertShader: | 203 | layout(location = 15) in vec4 a; | | Error: C0000: syntax error, unexpected reserved word "layout", expecting ';' at token "layout" | 2258 | var_attrs.v0 = attr_load_vec4(a); | | Error: C1503: undefined variable "a" ERROR (gpu.shader): GPU_material_compile FragShader: | 203 | in codegen_iface{ | | Error: C7537: OpenGL does not allow 'inout' after a type specifier | Error: C1014: "codegen_iface" is not a function | Error: C1004: in and out only apply to formal parameters "codegen_iface" | 205 | } | | Error: C1016: expression type incompatible with function return type | 203 | in codegen_iface{ | | Error: C1108: function "codegen_iface" has no statements | 205 | } | | Error: C3009: layout qualifier 'binding', incompatible with 'codegen_iface' | 206 | var_attrs; | | Error: C0000: syntax error, unexpected ';', expecting "::" at token ";" | 7792 | differentiate_texco(var_attrs.v0, tmp2); | | Error: C1503: undefined variable "var_attrs" | 7795 | mapping_mat4(tmp2, node_tree.u4, node_tree.u5, node_tree.u6, node_tree.u7, node_tree.u8, node_tree.u9, tmp10); | | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | 7799 | node_tex_image_linear(tmp10, samp0, tmp13, tmp14); | | Error: C1503: undefined variable "samp0" | 7816 | node_bsdf_principled(tmp16, node_tree.u20, node_tree.u21, node_tree.u22, node_tree.u23, node_tree.u24, node_tree.u25, node_tree.u26, node_tree.u27, node_tree.u28, node_tree.u29, node_tree.u30, node_tree.u31, node_tree.u32, node_tree.u33, node_tree.u34, node_tree.u35, node_tree.u36, node_tree.u37, node_tree.u38, node_tree.u39, node_tree.u40, tmp17, tmp18, cons43, node_tree.u44, cons45, cons46, cons47, cons48, node_tree.u49, tmp50); | | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" | Error: C1503: undefined variable "node_tree" ```

Clément Foucault commented

2022-05-07 18:57:43 +02:00

Added subscriber: @fclem

Clément Foucault commented

2022-05-07 18:57:43 +02:00

@lichtwerk Can you try to reproduce with this small patch and paste the resulting output here?

index 83fc34a3278..772053b9e9f 100644
    - a/source/blender/gpu/intern/gpu_shader_log.cc
+++ b/source/blender/gpu/intern/gpu_shader_log.cc
@@ -28,7 +28,7 @@ namespace blender::gpu {
  * \{ */
 
 /* Number of lines before and after the error line to print for compilation errors. */
- #define DEBUG_CONTEXT_LINES 0
+#define DEBUG_CONTEXT_LINES 2
 /**
  * Print dependencies sources list before the shader report.
  * Useful to debug include order or missing dependencies.```

@lichtwerk Can you try to reproduce with this small patch and paste the resulting output here? ```diff --git a/source/blender/gpu/intern/gpu_shader_log.cc b/source/blender/gpu/intern/gpu_shader_log.cc index 83fc34a3278..772053b9e9f 100644 - a/source/blender/gpu/intern/gpu_shader_log.cc +++ b/source/blender/gpu/intern/gpu_shader_log.cc @@ -28,7 +28,7 @@ namespace blender::gpu { * \{ */ /* Number of lines before and after the error line to print for compilation errors. */ - #define DEBUG_CONTEXT_LINES 0 +#define DEBUG_CONTEXT_LINES 2 /** * Print dependencies sources list before the shader report. * Useful to debug include order or missing dependencies.```

Philipp Oeser commented

2022-05-10 14:27:26 +02:00

As of 3893ba5d67, this might have gotten a bit better, but now we dont have an immediate update? "Compiling Shaders 1" is stalled in the statistics top left and you only see the texture update in the viewport after some interaction in the viewport (rotating, zooming, doing an actual paint stroke)

As of 3893ba5d67, this might have gotten a bit better, but now we dont have an immediate update? "Compiling Shaders 1" is stalled in the statistics top left and you only see the texture update in the viewport after some interaction in the viewport (rotating, zooming, doing an actual paint stroke)

Philipp Oeser commented

2022-05-10 14:35:12 +02:00

Changed status from 'Confirmed' to: 'Needs User Info'

Philipp Oeser commented

2022-05-10 14:35:12 +02:00

In #97519#1355906, @lichtwerk wrote:
As of 3893ba5d67, this might have gotten a bit better, but now we dont have an immediate update? "Compiling Shaders 1" is stalled in the statistics top left and you only see the texture update in the viewport after some interaction in the viewport (rotating, zooming, doing an actual paint stroke)

Made a new report, see #98018 (Missing viewport update after creating texture with canvas menu (sculpt mode, paint tool))

@JulienKaspar , @Vyach can you confirm the original problem is gone?

> In #97519#1355906, @lichtwerk wrote: > As of 3893ba5d67, this might have gotten a bit better, but now we dont have an immediate update? "Compiling Shaders 1" is stalled in the statistics top left and you only see the texture update in the viewport after some interaction in the viewport (rotating, zooming, doing an actual paint stroke) Made a new report, see #98018 (Missing viewport update after creating texture with canvas menu (sculpt mode, paint tool)) @JulienKaspar , @Vyach can you confirm the original problem is gone?

Philipp Oeser commented

2022-05-10 14:39:16 +02:00

0f7da9a72f or 6e2b0a38f0 might have fixed this

0f7da9a72f or 6e2b0a38f0 might have fixed this

Julien Kaspar commented

2022-05-10 14:45:23 +02:00

@lichtwerk I cannot reproduce the original issue anymore.