Regression: Previous strokes appears when drawing after undo with layer brush #97520

Closed
opened 2022-04-21 21:06:06 +02:00 by Burak · 17 comments

System Information
Operating system: Windows-10-10.0.22593-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.15

Blender Version
Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: cc66d1020c
Worked: 3.0.0
Was working prior to cfa53e0fbe

Short description of error
It seems like Undo operation doesn't work with Layer Tool properly.
Previous brush stoke is also seen when drawing after undo

Steps to Reproduce

  • Open default sculpting file
  • Switch to edit mode
  • With every face selected: {ctrl F > Shade smooth}
  • Switch back to sculpt mode (and change to viewport render)
  • Select layer brush from toolbar
  • draw a line and undo
  • Apply brush over same area (You'll also see the previous brush stroke)
**System Information** Operating system: Windows-10-10.0.22593-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.15 **Blender Version** Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: `cc66d1020c` Worked: 3.0.0 Was working prior to cfa53e0fbe **Short description of error** It seems like Undo operation doesn't work with Layer Tool properly. Previous brush stoke is also seen when drawing after undo **Steps to Reproduce** - Open default sculpting file - Switch to edit mode - With every face selected: {ctrl F > Shade smooth} - Switch back to sculpt mode (and change to viewport render) - Select layer brush from toolbar - draw a line and undo - Apply brush over same area (You'll also see the previous brush stroke)
Author

Added subscriber: @Burak

Added subscriber: @Burak
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'
Member

Hi, thanks for the report. I'm not able to reproduce this from scratch (tested on both 3.1.2 and 3.2).
Are you able to reproduce this in default sculpting file (File > New > Sculpting)?
Or do you have this problem in particular file only? If so, please attach that file

Hi, thanks for the report. I'm not able to reproduce this from scratch (tested on both 3.1.2 and 3.2). Are you able to reproduce this in default sculpting file (File > New > Sculpting)? Or do you have this problem in particular file only? If so, please attach that file
Author

I checked, and it happening in these conditions.

Default Sculpting File
while "Shade Smooth" applied and
in "Material Preview" or "Rendered" viewport shading.

I checked, and it happening in these conditions. Default Sculpting File while "Shade Smooth" applied and in "Material Preview" or "Rendered" viewport shading.
Author

And it's not just a visual thing, it affects geometry too.
zazaza.png

Layer Sculpting Tool.blend

And it's not just a visual thing, it affects geometry too. ![zazaza.png](https://archive.blender.org/developer/F13016650/zazaza.png) [Layer Sculpting Tool.blend](https://archive.blender.org/developer/F13016652/Layer_Sculpting_Tool.blend)
Member

Hi, still I'm not able to reproduce in your file (and neither from scratch).

Can you try factory settings?: {nav File > Defaults > Load Factory Settings}
Is it possible to upload screen recording if problem remains with factory settings?

Hi, still I'm not able to reproduce in your file (and neither from scratch). Can you try factory settings?: {nav File > Defaults > Load Factory Settings} Is it possible to upload screen recording if problem remains with factory settings?
Author

Hi, I recorded the process after I have loaded factory settings. Both on working pc and laptop It's happening.

VID-20220426-WA0004.mp4

Hi, I recorded the process after I have loaded factory settings. Both on working pc and laptop It's happening. [VID-20220426-WA0004.mp4](https://archive.blender.org/developer/F13029885/VID-20220426-WA0004.mp4)
Member

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'
Member

Thanks, I can now reproduce this bug.
This issue only appears in rendered and material preview mode (not in solid mode)

Thanks, I can now reproduce this bug. This issue only appears in rendered and material preview mode (not in solid mode)
Pratik Borhade changed title from Sculpting Layer Tool Undo Issue to Regression: Previous strokes appears when drawing after undo with layer brush 2022-04-27 05:14:20 +02:00
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

@HooglyBoogly , can you check?
I'm pretty sure this is caused by cfa53e0fbe

@HooglyBoogly , can you check? I'm pretty sure this is caused by cfa53e0fbe
Member

Changed status from 'Confirmed' to: 'Needs User Info'

Changed status from 'Confirmed' to: 'Needs User Info'
Member

I think I was testing on a wrong build.
Problem doesn't occur on current master.
@Burak , can you check again on latest 3.2 build?: https://builder.blender.org/download/daily

I think I was testing on a wrong build. Problem doesn't occur on current master. @Burak , can you check again on latest 3.2 build?: https://builder.blender.org/download/daily
Author

I checked,

Yes It doesn't occur on 3.2 build. Thank you.

I checked, Yes It doesn't occur on 3.2 build. Thank you.
Member

Changed status from 'Needs User Info' to: 'Resolved'

Changed status from 'Needs User Info' to: 'Resolved'
Pratik Borhade self-assigned this 2022-04-28 12:24:49 +02:00
Member

Will close then. Thanks again for the report!

Will close then. Thanks again for the report!
Pratik Borhade removed their assignment 2022-04-28 12:24:56 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#97520
No description provided.