Compositor: Continously add/remove for cryptomatte. #97907

New Issue

Jeroen Bakker · 2022-05-06T14:49:44+02:00

Jeroen Bakker commented

2022-05-06 14:49:44 +02:00

Source: https://devtalk.blender.org/t/continuous-add-and-remove-for-cryptomatte/24223

PROBLEM

Sometimes when using Cryptomatte the objects to isolate and divide into various passes can be a lot, and the process becomes tedious because you can only Add or Remove one object per time, then go back to the Cryptomatte node and click the + or - icon again, slowing a lot the process. Instead, it would be way more handy being able to select multiple specific objects.

SOLUTION

Have Add and Remove to work with multiple clicks, and then press Esc to go out of the selection mode when needed.

NOTE: although categorized as good first issue, it might require more changes than expected as UI code is shared with color picker. Of course the color picker workflow should not change.

Source: https://devtalk.blender.org/t/continuous-add-and-remove-for-cryptomatte/24223 PROBLEM Sometimes when using Cryptomatte the objects to isolate and divide into various passes can be a lot, and the process becomes tedious because you can only Add or Remove one object per time, then go back to the Cryptomatte node and click the + or - icon again, slowing a lot the process. Instead, it would be way more handy being able to select multiple specific objects. SOLUTION Have Add and Remove to work with multiple clicks, and then press Esc to go out of the selection mode when needed. NOTE: although categorized as good first issue, it might require more changes than expected as UI code is shared with color picker. Of course the color picker workflow should not change.

Jeroen Bakker commented

2022-05-06 14:49:44 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2022-05-06 14:49:44 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker self-assigned this 2022-05-06 16:29:51 +02:00

slwk1d commented

2022-05-07 11:05:26 +02:00

Added subscriber: @Slowwkidd

Jeroen Bakker removed their assignment 2022-05-09 07:56:39 +02:00

Alexey Adamitsky commented

2022-05-13 15:21:17 +02:00

Added subscriber: @AlexeyAdamitsky

Max Edge self-assigned this 2022-05-30 13:00:03 +02:00

Max Edge removed their assignment 2022-05-30 13:56:05 +02:00

Max Edge commented

2022-05-30 13:56:05 +02:00

Added subscriber: @Max-49

Julian Eisel commented

2022-07-12 18:28:52 +02:00

Added subscribers: @pablovazquez, @JulianEisel

Julian Eisel commented

2022-07-12 18:28:52 +02:00

@pablovazquez and I looked at the design of this today. Here are the points we agreed on (already checked with Jeroen, who seemed to agree too).

Esc for ending and confirming the operation is not an option. Allover Blender, Esc (and right-click) means cancel, not confirm.
Esc should actually cancel the operation, i.e. reset the buttons value. I think this isn't the case currently.
Enter is better, however you have to know about this to somehow get out of eyedropper mode without Esc-canceling (because that would make the tool useless).
Instead, the proposal is:
- A simple click will still pick the object under the cursor and ends the eyedropper.
- To pick multiple objects, {key Shift} can be held.
- Releasing {key Shift} and left clicking, or pressing {key Enter} will confirm and end the operation (and not sample another ID, even when mouse hovering one while left clicking).
- The status bar needs to display the shortcuts.

Also, additional changes we could/should do:

The plus and minus icons for the eyedropper should use the eyedropper. Currently it looks like you would add data, not trigger an eyedropper to select existing data. Could be an eyedropper with a smaller plus and minus icon on top.
Replace the eyedropper buttons with superimposed icons.

Now, implementation wise this may make things a bit more difficult. The cryptomatte eyedropper would have to be split off from the normal color eyedropper. IMHO this should be done either way. Then the cryptomatte eyedropper can have its own modal keymap, e.g. see eyedropper_colorband_modal_keymap(). So there will be more work involved, but I think this can still be done by a new developer, if that person can follow C code well enough.

@pablovazquez and I looked at the design of this today. Here are the points we agreed on (already checked with Jeroen, who seemed to agree too). - Esc for ending and confirming the operation is not an option. Allover Blender, Esc (and right-click) means cancel, not confirm. - Esc should actually cancel the operation, i.e. reset the buttons value. I think this isn't the case currently. - Enter is better, however you have to know about this to somehow get out of eyedropper mode without Esc-canceling (because that would make the tool useless). - Instead, the proposal is: - A simple click will still pick the object under the cursor and ends the eyedropper. - To pick multiple objects, {key Shift} can be held. - Releasing {key Shift} and left clicking, or pressing {key Enter} will confirm and end the operation (and not sample another ID, even when mouse hovering one while left clicking). - The status bar needs to display the shortcuts. Also, additional changes we could/should do: - The plus and minus icons for the eyedropper should use the eyedropper. Currently it looks like you would add data, not trigger an eyedropper to select existing data. Could be an eyedropper with a smaller plus and minus icon on top. - Replace the eyedropper buttons with superimposed icons. --- Now, implementation wise this may make things a bit more difficult. The cryptomatte eyedropper would have to be split off from the normal color eyedropper. IMHO this should be done either way. Then the cryptomatte eyedropper can have its own modal keymap, e.g. see `eyedropper_colorband_modal_keymap()`. So there will be more work involved, but I think this can still be done by a new developer, if that person can follow C code well enough.

Jeroen Bakker commented

2022-07-13 11:07:52 +02:00

To ease the development we could split this task into two.

separate the cryptomatte eye dropper from the color eye dropper without any functional changes.
implement the new behavior as described above.

This would keep the changes smaller and would be easier to handle.

To ease the development we could split this task into two. 1. separate the cryptomatte eye dropper from the color eye dropper without any functional changes. 2. implement the new behavior as described above. This would keep the changes smaller and would be easier to handle.

Nacho commented

2022-11-19 00:55:52 +01:00

Added subscriber: @big-nacho

Nacho commented

2022-11-19 00:55:52 +01:00

Hey, new to blender devs here and was hoping to make this my first issue. Not sure about how to proceed regarding splitting tasks or claiming them. Any help on that and any other formalities is welcome :)

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Compositor: Continously add/remove for cryptomatte. #97907