Code cleanup: header files should be self-sufficient #98922

New Issue

Alan Eneev · 2022-06-16T07:03:23+02:00

Alan Eneev commented

2022-06-16 07:03:23 +02:00

Self-sufficient header files are files that can be compiled stand alone.

Having self-sufficient header files allow easier code management. With self-sufficient headers removing an include from a .c or .h file doesn't break some other .h file elsewhere in the code base.

Self-sufficient header files are files that can be compiled stand alone. Having self-sufficient header files allow easier code management. With self-sufficient headers removing an include from a .c or .h file doesn't break some other .h file elsewhere in the code base.

Alan Eneev commented

2022-06-16 07:03:23 +02:00

Added subscriber: @ae

Pratik Borhade commented

2022-06-16 07:14:39 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-06-16 07:14:39 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Pratik Borhade closed this issue

2022-06-16 07:14:39 +02:00

Pratik Borhade commented

2022-06-16 07:14:39 +02:00

Hi, no need to open a separate ticket to describe the patch.
Also- Have you discussed this change with developers before submitting the patch? If not, you can reach them in #blender-coders

Hi, no need to open a separate ticket to describe the patch. Also- Have you discussed this change with developers before submitting the patch? If not, you can reach them in [#blender-coders ](https://blender.chat/channel/blender-coders)

Alan Eneev commented

2022-06-16 07:22:32 +02:00

Thank you, I thought I'd open a ticket to link a series of patches to it.

I started with includes for size_t, in source/ directory, but I suppose there are more issues throughout the code base besides stddef.h and size_t.

I did reach out to #blender-build, but didn't receive a reply yet, and thought I'd do this proactively -- this change wasn't too much work.
And if this patch were to go through, I'd work on making necessary changes to enforce self-contained headers in other parts of the codebase, and adding cmake checks to ensure that new headers are self-contained.

I'll ping #blender-coders, thank you for the poniter.

Thank you, I thought I'd open a ticket to link a series of patches to it. I started with includes for size_t, in source/ directory, but I suppose there are more issues throughout the code base besides stddef.h and size_t. I did reach out to #blender-build, but didn't receive a reply yet, and thought I'd do this proactively -- this change wasn't too much work. And if this patch were to go through, I'd work on making necessary changes to enforce self-contained headers in other parts of the codebase, and adding cmake checks to ensure that new headers are self-contained. I'll ping #blender-coders, thank you for the poniter.

Pratik Borhade commented

2022-06-16 07:30:46 +02:00

I thought I'd open a ticket to link a series of patches to it.

Hi, you can of course open a ticket to track your own changes.
But I would suggest to discuss this with developers before spending hours on any work :)

I did reach out to #blender-build, but didn't receive a reply yet

Blender-builds is not the appropriate channel. That channel is used for reporting build issues.

> I thought I'd open a ticket to link a series of patches to it. Hi, you can of course open a ticket to track your own changes. But I would suggest to discuss this with developers before spending hours on any work :) > I did reach out to #blender-build, but didn't receive a reply yet Blender-builds is not the appropriate channel. That channel is used for reporting build issues.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Code cleanup: header files should be self-sufficient #98922