blender
/
blender
129
397
Fork 571
Code Issues 6.2k Pull Requests 754 Projects 19 Wiki Activity

GPU: Fix performance regression on AMD GPU 

This was caused by a missing check left over during the GL isolation.

Fix T84277 Solid and Wireframe viewport performance hit on AMD Radeon GPUs
This commit is contained in:
Clément Foucault 2021-02-01 13:40:57 +01:00
parent 5e117b1226
commit 03c1c5f3a4
Notes: blender-bot 2023-02-13 20:01:24 +01:00 
Referenced by issue #85314, Flickering visibility of instanced objects
Referenced by issue #84277, Solid and Wireframe viewport performance hit on AMD Radeon GPUs
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/gpu/opengl/gl_drawlist.cc
View File

@ -69,7 +69,6 @@ GLDrawList::GLDrawList(int length)
buffer_id_ = 0;
command_len_ = 0;
command_offset_ = 0;
data_offset_ = 0;
data_size_ = 0;
data_ = nullptr;
@ -81,6 +80,8 @@ GLDrawList::GLDrawList(int length)
/* Indicates MDI is not supported. */
buffer_size_ = 0;
}
/* Force buffer specification on first init. */
data_offset_ = buffer_size_;
}
GLDrawList::~GLDrawList()
@ -104,10 +105,10 @@ void GLDrawList::init()
glBindBuffer(GL_DRAW_INDIRECT_BUFFER, buffer_id_);
/* If buffer is full, orphan buffer data and start fresh. */
// if (command_offset_ >= data_size_) {
glBufferData(GL_DRAW_INDIRECT_BUFFER, buffer_size_, nullptr, GL_DYNAMIC_DRAW);
data_offset_ = 0;
// }
if (data_offset_ >= buffer_size_) {
glBufferData(GL_DRAW_INDIRECT_BUFFER, buffer_size_, nullptr, GL_DYNAMIC_DRAW);
data_offset_ = 0;
}
/* Map the remaining range. */
GLbitfield flag = GL_MAP_WRITE_BIT | GL_MAP_UNSYNCHRONIZED_BIT | GL_MAP_FLUSH_EXPLICIT_BIT;
data_size_ = buffer_size_ - data_offset_;