blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 751 Projects 19 Wiki Activity

Sculpt: Fix T100941: Draw cache invalidation loop 

PBVH draw was invalidating the draw cache even
when disabled (e.g. if modifiers exist).
This commit is contained in:
Joseph Eagar 2022-09-12 11:09:03 -07:00
parent 8af59cdb16
commit 100fe61f7c
Notes: blender-bot 2023-02-14 06:00:50 +01:00 
Referenced by issue #100749, Blender LTS: Maintenance Task 3.3
Referenced by issue #101081, 3.3LTS: crash when entering sculpt mode of a wire mesh if it is a "custom object" of a bone
Referenced by issue #100941, Smear brush gives artifact when the strength  is above 1
Referenced by issue #100906, Regression: Lag in sculpt mode when navigating around an object with modifiers
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/draw/intern/draw_cache_impl_mesh.cc
View File

@ -556,8 +556,7 @@ static bool mesh_batch_cache_valid(Object *object, Mesh *me)
}
if (object->sculpt && object->sculpt->pbvh) {
if (cache->pbvh_is_drawing != BKE_pbvh_is_drawing(object->sculpt->pbvh) ||
BKE_pbvh_draw_cache_invalid(object->sculpt->pbvh)) {
if (cache->pbvh_is_drawing != BKE_pbvh_is_drawing(object->sculpt->pbvh)) {
return false;
}